Message ID | 20231019082147.384723-1-umang.jain@ideasonboard.com (mailing list archive) |
---|---|
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1qtOID-002FNZ-6u; Thu, 19 Oct 2023 08:22:09 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235250AbjJSIWH (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 19 Oct 2023 04:22:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235249AbjJSIWG (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 19 Oct 2023 04:22:06 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB7E9126 for <linux-media@vger.kernel.org>; Thu, 19 Oct 2023 01:22:04 -0700 (PDT) Received: from umang.jainideasonboard.com (unknown [103.251.226.1]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 016D625A; Thu, 19 Oct 2023 10:21:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1697703713; bh=LzjQ3czQq/jljPSeb2fPZh9bsWvb3v3VA3S4TgVmnlE=; h=From:To:Cc:Subject:Date:From; b=ZoPm3K6MYry9ic6T6mlw9gXX07pOXBLn9wH3bn1TwQq1gDbLisQBmx7olqh7ujyKT fpo0CVUXg7mhQJs01ysai4/oIfDt1AC32PDvjNHZhc4bB+7XyFShUyh11HnOjm60Pl 1CpF4MHL69ZCOnOTSVnOWCw77s5UYm3IRyL/YKls= From: Umang Jain <umang.jain@ideasonboard.com> To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefan Wahren <stefan.wahren@i2se.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Dave Stevenson <dave.stevenson@raspberrypi.com>, Dan Carpenter <error27@gmail.com>, Kieran Bingham <kieran.bingham@ideasonboard.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Umang Jain <umang.jain@ideasonboard.com> Subject: [PATCH v1 0/4] staging: vc04: Drop custom logging based on printk Date: Thu, 19 Oct 2023 13:51:43 +0530 Message-Id: <20231019082147.384723-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -4.8 (----) X-LSpam-Report: No, score=-4.8 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3 autolearn=ham autolearn_force=no |
Series |
staging: vc04: Drop custom logging based on printk
|
|
Message
Umang Jain
Oct. 19, 2023, 8:21 a.m. UTC
Hello, This series address the discussion on [1], i.e. removing the printk based logging mechanism and migrate it use dynamic debug. Patch 1/4 targets migration of vchiq_log_error(). Patch 2/4 targets migration of vchiq_log_warning(). ... and so on. This series does not touch debugfs entries which are: DEBUG_INITIALISE, DEBUG_TRACE, DEBUG_VALUE and DEBUG_COUNT. As far as I understand from the previous discussions, those too should be moved to use dynamic debug as well (but is not part of this series yet), as I found there are more moving parts involved. I will build a series on top of this one, to move the debugfs entries to dynamic debug and remove all custom logging remanants (like VCHIQ_LOG_* macros, *_log_levels externs) because they do still tie into vchiq_debugfs.c. [1] https://lore.kernel.org/linux-media/20230913185528.770634-1-umang.jain@ideasonboard.com/ Umang Jain (4): staging: vc04: Convert vchiq_log_error() to use dynamic debug staging: vc04: Convert vchiq_log_warning() to use dynamic debug staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic debug staging: vc04: Convert vchiq_log_trace() to use dynamic debug .../interface/vchiq_arm/vchiq_arm.c | 143 ++++---- .../interface/vchiq_arm/vchiq_connected.c | 2 +- .../interface/vchiq_arm/vchiq_core.c | 329 +++++++++--------- .../interface/vchiq_arm/vchiq_core.h | 53 ++- .../interface/vchiq_arm/vchiq_dev.c | 59 ++-- 5 files changed, 307 insertions(+), 279 deletions(-)
Comments
Quoting Umang Jain (2023-10-19 09:21:43) > Hello, > > This series address the discussion on [1], i.e. removing the printk > based logging mechanism and migrate it use dynamic debug. Thank you - sounds like progress. Is this series also already sufficient to consider the TODO at drivers/staging/vc04_services/interface/TODO as addressed? if so - a patch at the end of the series which removes the todo items would be good to include in the series (and other cleanup series) so that the TODO list gets updated as we progress. -- Kieran > Patch 1/4 targets migration of vchiq_log_error(). > Patch 2/4 targets migration of vchiq_log_warning(). > ... and so on. > > This series does not touch debugfs entries which are: > DEBUG_INITIALISE, DEBUG_TRACE, DEBUG_VALUE and DEBUG_COUNT. As far as I > understand from the previous discussions, those too should be moved > to use dynamic debug as well (but is not part of this series yet), as > I found there are more moving parts involved. I will build a series on > top of this one, to move the debugfs entries to dynamic debug and remove > all custom logging remanants (like VCHIQ_LOG_* macros, *_log_levels externs) > because they do still tie into vchiq_debugfs.c. > > [1] https://lore.kernel.org/linux-media/20230913185528.770634-1-umang.jain@ideasonboard.com/ > > Umang Jain (4): > staging: vc04: Convert vchiq_log_error() to use dynamic debug > staging: vc04: Convert vchiq_log_warning() to use dynamic debug > staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic > debug > staging: vc04: Convert vchiq_log_trace() to use dynamic debug > > .../interface/vchiq_arm/vchiq_arm.c | 143 ++++---- > .../interface/vchiq_arm/vchiq_connected.c | 2 +- > .../interface/vchiq_arm/vchiq_core.c | 329 +++++++++--------- > .../interface/vchiq_arm/vchiq_core.h | 53 ++- > .../interface/vchiq_arm/vchiq_dev.c | 59 ++-- > 5 files changed, 307 insertions(+), 279 deletions(-) > > -- > 2.40.1 >