mbox series

[v2,00/13] imx290: Minor fixes, support for alternate INCK, and more ctrls

Message ID 20230203191811.947697-1-dave.stevenson@raspberrypi.com (mailing list archive)
Headers
Series imx290: Minor fixes, support for alternate INCK, and more ctrls |

Message

Dave Stevenson Feb. 3, 2023, 7:17 p.m. UTC 
  Hi All

This is a small patch set that fixes a number of issues, adds in support
for the alternate input clock frequency option, and expands the control support
for flips and VBLANK/HBLANK.

My source tree has the 2 patches I've just sent for mono support first, but I
believe the two series should apply in either order (true for v1, possibly not
for v2).
There's tree with both patchsets applied at [1]. 

  Dave

Changes since v1:
2/11: Hardcoded colourspace values.
4/11: Missing blank line added.
6/11: s/repitition/repetition/
8/11: Set exposure range on changing mode.
8/11: Alter the initial exposure to be max.
8/11: Split out allowing VMAX to drop to 750 in 720p mode into a new patch.
10/11: Switch to an enum.
10/11: Compute IMX290_EXTCK_FREQ.
10/11: Move EXCK_FREQ and IMX290_INCKSEL7 settings to 
New patch: Add error code to logging in imx290_start_streaming.
Collected R-B tags.

[1] https://github.com/6by9/linux/tree/upstream_imx290

Dave Stevenson (13):
  media: i2c: imx290: Match kernel coding style on whitespace
  media: i2c: imx290: Set the colorspace fields in the format
  media: i2c: imx290: Add V4L2_SUBDEV_FL_HAS_EVENTS and subscribe hooks
  media: i2c: imx290: Fix the pixel rate at 148.5Mpix/s
  media: i2c: imx290: Support 60fps in 2 lane operation
  media: i2c: imx290: Use CSI timings as per datasheet
  media: i2c: imx290: Convert V4L2_CID_HBLANK to read/write
  media: i2c: imx290: Convert V4L2_CID_VBLANK to read/write
  media: i2c: imx290: VMAX is mode dependent
  media: i2c: imx290: Remove duplicated write to IMX290_CTRL_07
  media: i2c: imx290: Add support for 74.25MHz external clock
  media: i2c: imx290: Add support for H & V Flips
  media: i2c: imx290: Add the error code to logs in start_streaming

 drivers/media/i2c/imx290.c | 464 +++++++++++++++++++++++++++++--------
 1 file changed, 365 insertions(+), 99 deletions(-)

Comments

Laurent Pinchart Feb. 7, 2023, 1:55 a.m. UTC | #1 
Hi Dave,

On Fri, Feb 03, 2023 at 07:17:58PM +0000, Dave Stevenson wrote:
> Hi All
> 
> This is a small patch set that fixes a number of issues, adds in support
> for the alternate input clock frequency option, and expands the control support
> for flips and VBLANK/HBLANK.
> 
> My source tree has the 2 patches I've just sent for mono support first, but I
> believe the two series should apply in either order (true for v1, possibly not
> for v2).
> There's tree with both patchsets applied at [1]. 

This is a great series, thank you for upstreaming it.

Patch 04/13 conflicts with the latest media tree, but the conflict is
easy to fix. I've taken the whole series in my tree to test it when I'll
get access to hardware at the end of this week, I can then post a v3
with the review comments addressed. As for the other imx290 series
you've submitted, feel free to beat me to it if you want to.

> Changes since v1:
> 2/11: Hardcoded colourspace values.
> 4/11: Missing blank line added.
> 6/11: s/repitition/repetition/
> 8/11: Set exposure range on changing mode.
> 8/11: Alter the initial exposure to be max.
> 8/11: Split out allowing VMAX to drop to 750 in 720p mode into a new patch.
> 10/11: Switch to an enum.
> 10/11: Compute IMX290_EXTCK_FREQ.
> 10/11: Move EXCK_FREQ and IMX290_INCKSEL7 settings to 
> New patch: Add error code to logging in imx290_start_streaming.
> Collected R-B tags.
> 
> [1] https://github.com/6by9/linux/tree/upstream_imx290
> 
> Dave Stevenson (13):
>   media: i2c: imx290: Match kernel coding style on whitespace
>   media: i2c: imx290: Set the colorspace fields in the format
>   media: i2c: imx290: Add V4L2_SUBDEV_FL_HAS_EVENTS and subscribe hooks
>   media: i2c: imx290: Fix the pixel rate at 148.5Mpix/s
>   media: i2c: imx290: Support 60fps in 2 lane operation
>   media: i2c: imx290: Use CSI timings as per datasheet
>   media: i2c: imx290: Convert V4L2_CID_HBLANK to read/write
>   media: i2c: imx290: Convert V4L2_CID_VBLANK to read/write
>   media: i2c: imx290: VMAX is mode dependent
>   media: i2c: imx290: Remove duplicated write to IMX290_CTRL_07
>   media: i2c: imx290: Add support for 74.25MHz external clock
>   media: i2c: imx290: Add support for H & V Flips
>   media: i2c: imx290: Add the error code to logs in start_streaming
> 
>  drivers/media/i2c/imx290.c | 464 +++++++++++++++++++++++++++++--------
>  1 file changed, 365 insertions(+), 99 deletions(-)