Message ID | 20210326143458.508959-1-lee.jones@linaro.org (mailing list archive) |
---|---|
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1lPnYv-00GWu4-M5; Fri, 26 Mar 2021 14:35:47 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230237AbhCZOfO (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 26 Mar 2021 10:35:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230044AbhCZOfD (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 26 Mar 2021 10:35:03 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2873C0613B3 for <linux-media@vger.kernel.org>; Fri, 26 Mar 2021 07:35:02 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id p19so3115823wmq.1 for <linux-media@vger.kernel.org>; Fri, 26 Mar 2021 07:35:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VoFNqvJqV3TdL84vFoklC/P+s5SxY+mp4X8TTiNgMtE=; b=P+VsgdwqxC7S+r3aEF02+Phf4siu0/ukHmkddSss85wkzBu4EICPyZs9fP4AJk7kdQ a5dW6dH70JwYO457Ljil7DbwsUtsiPgUC1cMner3cAcl4d3LlgxctQIOREK/EMxLUV8F q54mo9DrRKtujvY75fE8ck0i45ZCiT0WTzJ/DSCCjOOggIX97lR/7mCEjPO7bFzSGPwD qPd+6jvSgAZG2KTUf0sbZVGUUUFLu3eCBc+TbxiPuO09l8pI8Ug4ZrgnfaZniN+UZ0Z6 4G9n6eLtW0aHwoxyD6JuqeqHKz6R/GPtIksun4/V53szdCuUiSdL6rlV+Ri/BAgTJrjP pP0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VoFNqvJqV3TdL84vFoklC/P+s5SxY+mp4X8TTiNgMtE=; b=RWRDSBUMI1MISt6Bxrq/FANHt9OvNyGcRqsFtu1wymjfHxyjVtc7PAcfsmXUl48LVa hfVkrb+7Fe4yH8VLBSJ8Xughf+jjSd/fS29gB974tZAZ+vFzJisQGu0JPHTenGlKlv61 L/G/sBVdoSEBsfeNVULIaRx/4UhO10KmQEDuaQm/rn2I5f33CCFO0aqHe/9Hx02q4fM4 BQmLTmm7gFM7OFhLtXyA5B19jfiYe0IMd45CgAsXlQ6FZG0ru/mIQ5wsXMGrhR8uvyFw UvrUaNrl3Bxn2o9o0N9WY2fB8S7KjxjARm6CGtQA0yoTJiZpOiyB2WMcySzHGktnIZS1 +wPQ== X-Gm-Message-State: AOAM530ttW29LUT6MEgWhwAauFla/WWYEkJNK6CzbMIxKgXw6PU6P7PN Tqb7t2QXzg/TWCgN3F4EoJFYeQ== X-Google-Smtp-Source: ABdhPJwVQ28g1uJ1l+3b8N6u3arMMfkW6TtopkB+1sfuYd5LjRqBrN12fvh40SnvFHqZ/sewwpeOGw== X-Received: by 2002:a1c:6a05:: with SMTP id f5mr13383680wmc.184.1616769301335; Fri, 26 Mar 2021 07:35:01 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:00 -0700 (PDT) From: Lee Jones <lee.jones@linaro.org> To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Alexandre Torgue <alexandre.torgue@foss.st.com>, Anssi Hannula <anssi.hannula@gmail.com>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, =?utf-8?q?Bruno_Pr?= =?utf-8?q?=C3=A9mont?= <bonbons@linux-vserver.org>, =?utf-8?q?Christian_K?= =?utf-8?q?=C3=B6nig?= <christian.koenig@amd.com>, Daniel Drubin <daniel.drubin@intel.com>, Dario Pagani <dario.pagani.146+linuxk@gmail.com>, dri-devel@lists.freedesktop.org, Henrik Rydberg <rydberg@bitmath.org>, Jiri Kosina <jikos@kernel.org>, Jonathan Cameron <jic23@kernel.org>, Kai-Heng Feng <kai.heng.feng@canonical.com>, Kim Kuparinen <kimi.h.kuparinen@gmail.com>, =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= <kw@linux.com>, linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-usb@vger.kernel.org, Lopez Casado <nlopezcasad@logitech.com>, "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>, Masaki Ota <masaki.ota@jp.alps.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, message to <vojtech@ucw.cz>, Michael Haboustak <mike-@cinci.rr.com>, Rushikesh S Kadam <rushikesh.s.kadam@intel.com>, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, Sumit Semwal <sumit.semwal@linaro.org>, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <uwe@kleine-koenig.org>, Vojtech Pavlik <vojtech@suse.cz>, Zhang Lixu <lixu.zhang@intel.com> Subject: [RESEND 00/25] Rid W=1 warnings from HID Date: Fri, 26 Mar 2021 14:34:32 +0000 Message-Id: <20210326143458.508959-1-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
Rid W=1 warnings from HID
|
|
Message
Lee Jones
March 26, 2021, 2:34 p.m. UTC
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (25): HID: intel-ish-hid: Remove unused variable 'err' HID: ishtp-hid-client: Move variable to where it's actually used HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' HID: intel-ish: Supply some missing param descriptions HID: intel-ish: Fix a naming disparity and a formatting error HID: usbhid: Repair a formatting issue in a struct description HID: intel-ish-hid: Fix a little doc-rot HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses HID: hid-alps: Correct struct misnaming HID: intel-ish-hid: Fix potential copy/paste error HID: hid-core: Fix incorrect function name in header HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in header HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() HID: hid-kye: Fix incorrect function name for kye_tablet_enable() HID: hid-picolcd_core: Remove unused variable 'ret' HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote abuses HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses HID: hid-uclogic-params: Ensure function names are present and correct in kernel-doc headers HID: hid-sensor-custom: Remove unused variable 'ret' HID: wacom_sys: Demote kernel-doc abuse HID: hid-sensor-hub: Remove unused struct member 'quirks' HID: hid-sensor-hub: Move 'hsdev' description to correct struct definition HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning drivers/hid/hid-alps.c | 2 +- drivers/hid/hid-core.c | 2 +- drivers/hid/hid-kye.c | 2 +- drivers/hid/hid-logitech-hidpp.c | 7 +-- drivers/hid/hid-picolcd_core.c | 5 +-- drivers/hid/hid-sensor-custom.c | 5 +-- drivers/hid/hid-sensor-hub.c | 4 +- drivers/hid/hid-thrustmaster.c | 24 +++++------ drivers/hid/hid-uclogic-params.c | 8 ++-- drivers/hid/hid-uclogic-rdesc.c | 2 +- drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +- drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++---------- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++-- drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +--- drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++- drivers/hid/intel-ish-hid/ishtp/client.c | 5 +-- drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +- drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +- drivers/hid/usbhid/hid-pidff.c | 4 +- drivers/hid/usbhid/usbkbd.c | 2 +- drivers/hid/wacom_sys.c | 2 +- include/linux/intel-ish-client-if.h | 8 +++- 24 files changed, 90 insertions(+), 81 deletions(-) Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Anssi Hannula <anssi.hannula@gmail.com> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cc: "Bruno Prémont" <bonbons@linux-vserver.org> Cc: "Christian König" <christian.koenig@amd.com> Cc: Daniel Drubin <daniel.drubin@intel.com> Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com> Cc: dri-devel@lists.freedesktop.org Cc: Henrik Rydberg <rydberg@bitmath.org> Cc: Jiri Kosina <jikos@kernel.org> Cc: Jonathan Cameron <jic23@kernel.org> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com> Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com> Cc: "Krzysztof Wilczyński" <kw@linux.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: linaro-mm-sig@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-iio@vger.kernel.org Cc: linux-input@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-usb@vger.kernel.org Cc: Lopez Casado <nlopezcasad@logitech.com> Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu> Cc: Masaki Ota <masaki.ota@jp.alps.com> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: message to <vojtech@ucw.cz> Cc: Michael Haboustak <mike-@cinci.rr.com> Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org> Cc: Vojtech Pavlik <vojtech@suse.cz> Cc: Zhang Lixu <lixu.zhang@intel.com>
Comments
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. [RESEND] contains no functional changes. Only 18 of 25 patches actually made it to the list during the first attempt. Lee Jones (25): HID: intel-ish-hid: Remove unused variable 'err' HID: ishtp-hid-client: Move variable to where it's actually used HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' HID: intel-ish: Supply some missing param descriptions HID: intel-ish: Fix a naming disparity and a formatting error HID: usbhid: Repair a formatting issue in a struct description HID: intel-ish-hid: Fix a little doc-rot HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses HID: hid-alps: Correct struct misnaming HID: intel-ish-hid: Fix potential copy/paste error HID: hid-core: Fix incorrect function name in header HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in header HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() HID: hid-kye: Fix incorrect function name for kye_tablet_enable() HID: hid-picolcd_core: Remove unused variable 'ret' HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote abuses HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses HID: hid-uclogic-params: Ensure function names are present and correct in kernel-doc headers HID: hid-sensor-custom: Remove unused variable 'ret' HID: wacom_sys: Demote kernel-doc abuse HID: hid-sensor-hub: Remove unused struct member 'quirks' HID: hid-sensor-hub: Move 'hsdev' description to correct struct definition HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning drivers/hid/hid-alps.c | 2 +- drivers/hid/hid-core.c | 2 +- drivers/hid/hid-kye.c | 2 +- drivers/hid/hid-logitech-hidpp.c | 7 +-- drivers/hid/hid-picolcd_core.c | 5 +-- drivers/hid/hid-sensor-custom.c | 5 +-- drivers/hid/hid-sensor-hub.c | 4 +- drivers/hid/hid-thrustmaster.c | 24 +++++------ drivers/hid/hid-uclogic-params.c | 8 ++-- drivers/hid/hid-uclogic-rdesc.c | 2 +- drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +- drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++---------- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++-- drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +--- drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++- drivers/hid/intel-ish-hid/ishtp/client.c | 5 +-- drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +- drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +- drivers/hid/usbhid/hid-pidff.c | 4 +- drivers/hid/usbhid/usbkbd.c | 2 +- drivers/hid/wacom_sys.c | 2 +- include/linux/intel-ish-client-if.h | 8 +++- 24 files changed, 90 insertions(+), 81 deletions(-) Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Anssi Hannula <anssi.hannula@gmail.com> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cc: "Bruno Prémont" <bonbons@linux-vserver.org> Cc: "Christian König" <christian.koenig@amd.com> Cc: Daniel Drubin <daniel.drubin@intel.com> Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com> Cc: dri-devel@lists.freedesktop.org Cc: Henrik Rydberg <rydberg@bitmath.org> Cc: Jiri Kosina <jikos@kernel.org> Cc: Jonathan Cameron <jic23@kernel.org> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com> Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com> Cc: "Krzysztof Wilczyński" <kw@linux.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: linaro-mm-sig@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-iio@vger.kernel.org Cc: linux-input@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-usb@vger.kernel.org Cc: Lopez Casado <nlopezcasad@logitech.com> Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu> Cc: Masaki Ota <masaki.ota@jp.alps.com> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: message to <vojtech@ucw.cz> Cc: Michael Haboustak <mike-@cinci.rr.com> Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org> Cc: Vojtech Pavlik <vojtech@suse.cz> Cc: Zhang Lixu <lixu.zhang@intel.com>
On Fri, 26 Mar 2021, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (25): > HID: intel-ish-hid: Remove unused variable 'err' > HID: ishtp-hid-client: Move variable to where it's actually used > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' > HID: intel-ish: Supply some missing param descriptions > HID: intel-ish: Fix a naming disparity and a formatting error > HID: usbhid: Repair a formatting issue in a struct description > HID: intel-ish-hid: Fix a little doc-rot > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses > HID: hid-alps: Correct struct misnaming > HID: intel-ish-hid: Fix potential copy/paste error > HID: hid-core: Fix incorrect function name in header > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in > header > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() > HID: hid-kye: Fix incorrect function name for kye_tablet_enable() > HID: hid-picolcd_core: Remove unused variable 'ret' > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote > abuses > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses > HID: hid-uclogic-params: Ensure function names are present and correct > in kernel-doc headers > HID: hid-sensor-custom: Remove unused variable 'ret' > HID: wacom_sys: Demote kernel-doc abuse > HID: hid-sensor-hub: Remove unused struct member 'quirks' > HID: hid-sensor-hub: Move 'hsdev' description to correct struct > definition > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning These have been on the list for a couple of weeks now. Is there anything I can do to help expedite their merge? I'm concerned since -rc6 has just been released.
On Tue, Apr 6, 2021 at 10:56 AM Lee Jones <lee.jones@linaro.org> wrote: > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Lee Jones (25): > > HID: intel-ish-hid: Remove unused variable 'err' > > HID: ishtp-hid-client: Move variable to where it's actually used > > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' > > HID: intel-ish: Supply some missing param descriptions > > HID: intel-ish: Fix a naming disparity and a formatting error > > HID: usbhid: Repair a formatting issue in a struct description > > HID: intel-ish-hid: Fix a little doc-rot > > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses > > HID: hid-alps: Correct struct misnaming > > HID: intel-ish-hid: Fix potential copy/paste error > > HID: hid-core: Fix incorrect function name in header > > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in > > header > > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() > > HID: hid-kye: Fix incorrect function name for kye_tablet_enable() > > HID: hid-picolcd_core: Remove unused variable 'ret' > > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote > > abuses > > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs > > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses > > HID: hid-uclogic-params: Ensure function names are present and correct > > in kernel-doc headers > > HID: hid-sensor-custom: Remove unused variable 'ret' > > HID: wacom_sys: Demote kernel-doc abuse > > HID: hid-sensor-hub: Remove unused struct member 'quirks' > > HID: hid-sensor-hub: Move 'hsdev' description to correct struct > > definition > > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues > > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning > > These have been on the list for a couple of weeks now. > > Is there anything I can do to help expedite their merge? > > I'm concerned since -rc6 has just been released. Sorry for the delay. I am currently queuing them locally and running a few tests on them. I don't expect anything to happen, but better be safe than anything. FWIW, I am splitting the series in 3: - 11 patches for intel ish are going to be queued in for-5.13/intel-ish - the thrustmaster one in for-5.13/thrustmaster - the rest (13 patches) will be sent in for-5.13/warnings. Cheers, Benjamin
On Wed, 07 Apr 2021, Benjamin Tissoires wrote: > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones <lee.jones@linaro.org> wrote: > > > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly riddled with > > > niggly little warnings. > > > > > > Lee Jones (25): > > > HID: intel-ish-hid: Remove unused variable 'err' > > > HID: ishtp-hid-client: Move variable to where it's actually used > > > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' > > > HID: intel-ish: Supply some missing param descriptions > > > HID: intel-ish: Fix a naming disparity and a formatting error > > > HID: usbhid: Repair a formatting issue in a struct description > > > HID: intel-ish-hid: Fix a little doc-rot > > > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses > > > HID: hid-alps: Correct struct misnaming > > > HID: intel-ish-hid: Fix potential copy/paste error > > > HID: hid-core: Fix incorrect function name in header > > > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in > > > header > > > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() > > > HID: hid-kye: Fix incorrect function name for kye_tablet_enable() > > > HID: hid-picolcd_core: Remove unused variable 'ret' > > > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote > > > abuses > > > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs > > > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses > > > HID: hid-uclogic-params: Ensure function names are present and correct > > > in kernel-doc headers > > > HID: hid-sensor-custom: Remove unused variable 'ret' > > > HID: wacom_sys: Demote kernel-doc abuse > > > HID: hid-sensor-hub: Remove unused struct member 'quirks' > > > HID: hid-sensor-hub: Move 'hsdev' description to correct struct > > > definition > > > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues > > > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning > > > > These have been on the list for a couple of weeks now. > > > > Is there anything I can do to help expedite their merge? > > > > I'm concerned since -rc6 has just been released. > > Sorry for the delay. > > I am currently queuing them locally and running a few tests on them. I > don't expect anything to happen, but better be safe than anything. > > FWIW, I am splitting the series in 3: > - 11 patches for intel ish are going to be queued in for-5.13/intel-ish > - the thrustmaster one in for-5.13/thrustmaster > - the rest (13 patches) will be sent in for-5.13/warnings. Sounds good to me. Thanks Benjamin.
On Thu, Apr 8, 2021 at 9:06 AM Lee Jones <lee.jones@linaro.org> wrote: > > On Wed, 07 Apr 2021, Benjamin Tissoires wrote: > > > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > > > Lee Jones (25): > > > > HID: intel-ish-hid: Remove unused variable 'err' > > > > HID: ishtp-hid-client: Move variable to where it's actually used > > > > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' > > > > HID: intel-ish: Supply some missing param descriptions > > > > HID: intel-ish: Fix a naming disparity and a formatting error > > > > HID: usbhid: Repair a formatting issue in a struct description > > > > HID: intel-ish-hid: Fix a little doc-rot > > > > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses > > > > HID: hid-alps: Correct struct misnaming > > > > HID: intel-ish-hid: Fix potential copy/paste error > > > > HID: hid-core: Fix incorrect function name in header > > > > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in > > > > header > > > > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() > > > > HID: hid-kye: Fix incorrect function name for kye_tablet_enable() > > > > HID: hid-picolcd_core: Remove unused variable 'ret' > > > > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote > > > > abuses > > > > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs > > > > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses > > > > HID: hid-uclogic-params: Ensure function names are present and correct > > > > in kernel-doc headers > > > > HID: hid-sensor-custom: Remove unused variable 'ret' > > > > HID: wacom_sys: Demote kernel-doc abuse > > > > HID: hid-sensor-hub: Remove unused struct member 'quirks' > > > > HID: hid-sensor-hub: Move 'hsdev' description to correct struct > > > > definition > > > > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues > > > > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning > > > > > > These have been on the list for a couple of weeks now. > > > > > > Is there anything I can do to help expedite their merge? > > > > > > I'm concerned since -rc6 has just been released. > > > > Sorry for the delay. > > > > I am currently queuing them locally and running a few tests on them. I > > don't expect anything to happen, but better be safe than anything. > > > > FWIW, I am splitting the series in 3: > > - 11 patches for intel ish are going to be queued in for-5.13/intel-ish > > - the thrustmaster one in for-5.13/thrustmaster > > - the rest (13 patches) will be sent in for-5.13/warnings. > > Sounds good to me. Thanks Benjamin. > After a few attempts at fixing my CI, I have now pushed this series as mentioned previously. Cheers, Benjamin