Message ID | 20210118110448.275389-1-heiko@sntech.de (mailing list archive) |
---|---|
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1l1SMh-002nm1-Qv; Mon, 18 Jan 2021 11:06:32 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389375AbhARLGN (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 18 Jan 2021 06:06:13 -0500 Received: from gloria.sntech.de ([185.11.138.130]:46790 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389260AbhARLFe (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 18 Jan 2021 06:05:34 -0500 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <heiko@sntech.de>) id 1l1SL4-0003HM-5g; Mon, 18 Jan 2021 12:04:50 +0100 From: Heiko Stuebner <heiko@sntech.de> To: dafna.hirschfeld@collabora.com, helen.koike@collabora.com, linux-media@vger.kernel.org, mchehab@kernel.org, Laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl Cc: linux-rockchip@lists.infradead.org, ezequiel@collabora.com, christoph.muellner@theobroma-systems.com, heiko@sntech.de, tfiga@chromium.org Subject: [PATCH v6 0/4] Fix the rkisp1 userspace API for later IP versions Date: Mon, 18 Jan 2021 12:04:44 +0100 Message-Id: <20210118110448.275389-1-heiko@sntech.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.4 (--) X-LSpam-Report: No, score=-2.4 required=5.0 tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
Fix the rkisp1 userspace API for later IP versions
|
|
Message
Heiko Stuebner
Jan. 18, 2021, 11:04 a.m. UTC
This NEEDs to go into 5.11 while we can still adapt the uapi during its RC-cycle. When looking into supporting the rkisp1 of the px30 I noticed that some fields got bigger in the uapi, caused by bigger number of samples for example for histograms or gamma values. The rkisp1 was destaged with 5.11-rc1 so we have still time during the 5.11 cycle to fix that without big hassles. This was discussed previously in a mail [0] and a rfc series [1] and this two-part series now splits out the important parts that really should become part of a 5.11-rc and thus the final 5.11. changes since v5: - move grid reduction for V10 to separate patch (Hans) - fix commit message (histogram size 28 -> 25) in patch4 (Hans) changes since v4: - set GAMMA_OUT to the real 25 instead of the 28 with 3 spares (Dafna) - start RKISP_Vxx enum with 10 for RKISP_V10 to make output easier and also allow userspace to differentiate between old (= 0) and newer driver variants (Dafna, Laurent) changes since v3: - add patch fixing the original histogram size comment - make comments in uapi more verbose (Hans) - fix wording in admin guide (Hans) - document version <-> soc in uapi as well (easier for people) (Dafna) changes since v2: - actually zero the correct sizes for u16 values (hist-bins) (kernel-test-robot) changes since v1: - drop duplicate isp_ver storage, hw_revision is enough (Dafna) - document multiple maximum sizes in uapi (Hans) - document usage of hw_revision field (Hans) - zero fields transmitted to userspace before adding data (Hans) - use _V10 field sizes when filling fields, as there is only v10 for now changes since rfc: - move rkisp1_version enum into uapo - show version in media-api hw_revision - introduce constants for versions and make max use the biggest Heiko Stuebner (4): media: rockchip: rkisp1: fix comment about number of histogram sub-windows media: rockchip: rkisp1: reduce number of histogram grid elements in uapi media: rockchip: rkisp1: carry ip version information media: rockchip: rkisp1: extend uapi array sizes Documentation/admin-guide/media/rkisp1.rst | 16 ++++ .../platform/rockchip/rkisp1/rkisp1-dev.c | 21 +++--- .../platform/rockchip/rkisp1/rkisp1-params.c | 2 +- .../platform/rockchip/rkisp1/rkisp1-stats.c | 12 ++- include/uapi/linux/rkisp1-config.h | 75 +++++++++++++++++-- 5 files changed, 106 insertions(+), 20 deletions(-)
Comments
On 18/01/2021 12:04, Heiko Stuebner wrote: > This NEEDs to go into 5.11 while we can still adapt the uapi > during its RC-cycle. > > > When looking into supporting the rkisp1 of the px30 I noticed that > some fields got bigger in the uapi, caused by bigger number of samples > for example for histograms or gamma values. > > The rkisp1 was destaged with 5.11-rc1 so we have still time during > the 5.11 cycle to fix that without big hassles. > > This was discussed previously in a mail [0] and a rfc series [1] > and this two-part series now splits out the important parts that > really should become part of a 5.11-rc and thus the final 5.11. Nice! If there are no more comments, then I plan a PR for 5.11 on Wednesday. Regards, Hans > > changes since v5: > - move grid reduction for V10 to separate patch (Hans) > - fix commit message (histogram size 28 -> 25) in patch4 (Hans) > > changes since v4: > - set GAMMA_OUT to the real 25 instead of the 28 with 3 spares (Dafna) > - start RKISP_Vxx enum with 10 for RKISP_V10 to make output > easier and also allow userspace to differentiate between old (= 0) > and newer driver variants (Dafna, Laurent) > > changes since v3: > - add patch fixing the original histogram size comment > - make comments in uapi more verbose (Hans) > - fix wording in admin guide (Hans) > - document version <-> soc in uapi as well (easier for people) (Dafna) > > changes since v2: > - actually zero the correct sizes for u16 values (hist-bins) > (kernel-test-robot) > > changes since v1: > - drop duplicate isp_ver storage, hw_revision is enough (Dafna) > - document multiple maximum sizes in uapi (Hans) > - document usage of hw_revision field (Hans) > - zero fields transmitted to userspace before adding data (Hans) > - use _V10 field sizes when filling fields, as there is only v10 for now > > changes since rfc: > - move rkisp1_version enum into uapo > - show version in media-api hw_revision > - introduce constants for versions and make max use the biggest > > > Heiko Stuebner (4): > media: rockchip: rkisp1: fix comment about number of histogram > sub-windows > media: rockchip: rkisp1: reduce number of histogram grid elements in > uapi > media: rockchip: rkisp1: carry ip version information > media: rockchip: rkisp1: extend uapi array sizes > > Documentation/admin-guide/media/rkisp1.rst | 16 ++++ > .../platform/rockchip/rkisp1/rkisp1-dev.c | 21 +++--- > .../platform/rockchip/rkisp1/rkisp1-params.c | 2 +- > .../platform/rockchip/rkisp1/rkisp1-stats.c | 12 ++- > include/uapi/linux/rkisp1-config.h | 75 +++++++++++++++++-- > 5 files changed, 106 insertions(+), 20 deletions(-) >