[00/19,Set,2] Rid W=1 warnings from GPU

Message ID 20201106214949.2042120-1-lee.jones@linaro.org (mailing list archive)
Headers
Series Rid W=1 warnings from GPU |

Message

Lee Jones Nov. 6, 2020, 9:49 p.m. UTC
  This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

There are 5000 warnings to work through.  It will take a couple more
sets.  Although, ("drm/amd/display/dc/basics/fixpt31_32: Move
variables to where they're used") does take care of 2000 of them!

Lee Jones (19):
  drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header
  drm/r128/ati_pcigart: Source file headers are not good candidates for
    kernel-doc
  drm/selftests/test-drm_dp_mst_helper: Move
    'sideband_msg_req_encode_decode' onto the heap
  drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks
  drm/mga/mga_state: Remove unused variable 'buf_priv'
  drm/radeon/atom: Move prototype into shared location
  drm/radeon/radeon_kms: Include header containing our own prototypes
  drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions
  drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format
  drm/radeon/radeon: Move prototype into shared header
  drm/radeon/radeon_drv: Source file headers are not good candidates for
    kernel-doc
  drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're
    used
  drm/radeon/radeon_drv: Move prototypes to a shared headerfile
  drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr'
    params
  drm/radeon: Move prototypes to shared header
  drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device
    dev_info' from the stack
  drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param
  drm/radeon/atombios_crtc: Remove description of non-existent function
    param 'encoder'
  drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops'

 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |   2 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c       | 104 +++++++++---------
 .../drm/amd/display/dc/basics/fixpt31_32.c    |   5 +
 .../gpu/drm/amd/display/include/fixed31_32.h  |   6 -
 drivers/gpu/drm/mga/mga_dma.c                 |  10 +-
 drivers/gpu/drm/mga/mga_state.c               |   2 -
 drivers/gpu/drm/omapdrm/omap_dmm_tiler.c      |   6 +-
 drivers/gpu/drm/omapdrm/omap_gem.c            |   3 +-
 drivers/gpu/drm/r128/ati_pcigart.c            |   2 +-
 drivers/gpu/drm/radeon/atom.h                 |   6 +
 drivers/gpu/drm/radeon/atombios_crtc.c        |   1 -
 drivers/gpu/drm/radeon/atombios_encoders.c    |   4 -
 drivers/gpu/drm/radeon/radeon.h               |   6 +
 drivers/gpu/drm/radeon/radeon_device.c        |   1 +
 drivers/gpu/drm/radeon/radeon_device.h        |  32 ++++++
 drivers/gpu/drm/radeon/radeon_display.c       |   4 -
 drivers/gpu/drm/radeon/radeon_drv.c           |  11 +-
 drivers/gpu/drm/radeon/radeon_drv.h           |   7 ++
 drivers/gpu/drm/radeon/radeon_kms.c           |   3 +-
 .../drm/selftests/test-drm_dp_mst_helper.c    |  11 +-
 drivers/gpu/drm/ttm/ttm_range_manager.c       |   2 +-
 drivers/gpu/drm/v3d/v3d_drv.c                 |  36 ------
 22 files changed, 138 insertions(+), 126 deletions(-)
 create mode 100644 drivers/gpu/drm/radeon/radeon_device.h

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: Andy Gross <andy.gross@ti.com>
Cc: by <jhartmann@precisioninsight.com>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: Eric Anholt <eric@anholt.net>
Cc: Faith <faith@valinux.com>
Cc: Gareth Hughes <gareth@valinux.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Jeff Hartmann <jhartmann@valinux.com>
Cc: Keith Whitwell <keith@tungstengraphics.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-media@vger.kernel.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Rob Clark <rob.clark@linaro.org>
Cc: Rob Clark <rob@ti.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
  

Comments

Sam Ravnborg Nov. 6, 2020, 10:26 p.m. UTC | #1
Hi Lee and DRM folks.

On Fri, Nov 06, 2020 at 09:49:30PM +0000, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 
> There are 5000 warnings to work through.  It will take a couple more
> sets.  Although, ("drm/amd/display/dc/basics/fixpt31_32: Move
> variables to where they're used") does take care of 2000 of them!
> 
> Lee Jones (19):
>   drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header
>   drm/r128/ati_pcigart: Source file headers are not good candidates for
>     kernel-doc
Applied

>   drm/selftests/test-drm_dp_mst_helper: Move
>     'sideband_msg_req_encode_decode' onto the heap
>   drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks
>   drm/mga/mga_state: Remove unused variable 'buf_priv'
Applied x2

>   drm/radeon/atom: Move prototype into shared location
>   drm/radeon/radeon_kms: Include header containing our own prototypes
>   drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions
>   drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format
>   drm/radeon/radeon: Move prototype into shared header
>   drm/radeon/radeon_drv: Source file headers are not good candidates for
>     kernel-doc
>   drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're
>     used
>   drm/radeon/radeon_drv: Move prototypes to a shared headerfile
>   drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr'
>     params
>   drm/radeon: Move prototypes to shared header
>   drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device
>     dev_info' from the stack
>   drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param
>   drm/radeon/atombios_crtc: Remove description of non-existent function
>     param 'encoder'
>   drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops'

I have applied the three patches that has no obvious maintainer as indicated
above. I assume the respective maintaines to pick radeon, omapdrm, ttm,
amd, v3d and selftest patches.

	Sam
  
Christian König Nov. 7, 2020, 12:18 p.m. UTC | #2
Well that's quite a patch set.

First of all can you separate this a bit more by driver? I'm assuming we 
maintainers are supposed to pick that up and apply it.

radeon and amdgpu can stick together since that is mostly Alex and me, 
but I'm not sure if we want to do some of the suggested changes to radeon.

Going to pick up the single TTM change for upstreaming.

Thanks,
Christian.

Am 06.11.20 um 22:49 schrieb Lee Jones:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> There are 5000 warnings to work through.  It will take a couple more
> sets.  Although, ("drm/amd/display/dc/basics/fixpt31_32: Move
> variables to where they're used") does take care of 2000 of them!
>
> Lee Jones (19):
>    drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header
>    drm/r128/ati_pcigart: Source file headers are not good candidates for
>      kernel-doc
>    drm/selftests/test-drm_dp_mst_helper: Move
>      'sideband_msg_req_encode_decode' onto the heap
>    drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks
>    drm/mga/mga_state: Remove unused variable 'buf_priv'
>    drm/radeon/atom: Move prototype into shared location
>    drm/radeon/radeon_kms: Include header containing our own prototypes
>    drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions
>    drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format
>    drm/radeon/radeon: Move prototype into shared header
>    drm/radeon/radeon_drv: Source file headers are not good candidates for
>      kernel-doc
>    drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're
>      used
>    drm/radeon/radeon_drv: Move prototypes to a shared headerfile
>    drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr'
>      params
>    drm/radeon: Move prototypes to shared header
>    drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device
>      dev_info' from the stack
>    drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param
>    drm/radeon/atombios_crtc: Remove description of non-existent function
>      param 'encoder'
>    drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops'
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |   2 +
>   drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c       | 104 +++++++++---------
>   .../drm/amd/display/dc/basics/fixpt31_32.c    |   5 +
>   .../gpu/drm/amd/display/include/fixed31_32.h  |   6 -
>   drivers/gpu/drm/mga/mga_dma.c                 |  10 +-
>   drivers/gpu/drm/mga/mga_state.c               |   2 -
>   drivers/gpu/drm/omapdrm/omap_dmm_tiler.c      |   6 +-
>   drivers/gpu/drm/omapdrm/omap_gem.c            |   3 +-
>   drivers/gpu/drm/r128/ati_pcigart.c            |   2 +-
>   drivers/gpu/drm/radeon/atom.h                 |   6 +
>   drivers/gpu/drm/radeon/atombios_crtc.c        |   1 -
>   drivers/gpu/drm/radeon/atombios_encoders.c    |   4 -
>   drivers/gpu/drm/radeon/radeon.h               |   6 +
>   drivers/gpu/drm/radeon/radeon_device.c        |   1 +
>   drivers/gpu/drm/radeon/radeon_device.h        |  32 ++++++
>   drivers/gpu/drm/radeon/radeon_display.c       |   4 -
>   drivers/gpu/drm/radeon/radeon_drv.c           |  11 +-
>   drivers/gpu/drm/radeon/radeon_drv.h           |   7 ++
>   drivers/gpu/drm/radeon/radeon_kms.c           |   3 +-
>   .../drm/selftests/test-drm_dp_mst_helper.c    |  11 +-
>   drivers/gpu/drm/ttm/ttm_range_manager.c       |   2 +-
>   drivers/gpu/drm/v3d/v3d_drv.c                 |  36 ------
>   22 files changed, 138 insertions(+), 126 deletions(-)
>   create mode 100644 drivers/gpu/drm/radeon/radeon_device.h
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: Andy Gross <andy.gross@ti.com>
> Cc: by <jhartmann@precisioninsight.com>
> Cc: Christian Koenig <christian.koenig@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Faith <faith@valinux.com>
> Cc: Gareth Hughes <gareth@valinux.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Huang Rui <ray.huang@amd.com>
> Cc: Jeff Hartmann <jhartmann@valinux.com>
> Cc: Keith Whitwell <keith@tungstengraphics.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-media@vger.kernel.org
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Rob Clark <rob.clark@linaro.org>
> Cc: Rob Clark <rob@ti.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
  
Lee Jones Nov. 7, 2020, 3:07 p.m. UTC | #3
On Sat, 07 Nov 2020, Christian König wrote:

> Well that's quite a patch set.
> 
> First of all can you separate this a bit more by driver? I'm assuming we
> maintainers are supposed to pick that up and apply it.

I'm not sure what would achieve?  It's not a pull-request.

Either way, patches should be applied individually.

> radeon and amdgpu can stick together since that is mostly Alex and me, but
> I'm not sure if we want to do some of the suggested changes to radeon.

That's fine.  Just review, providing your reasons as to why they are
not suitable and we'll work through the issues together, patch by
patch.

> Going to pick up the single TTM change for upstreaming.

Thanks.

> Am 06.11.20 um 22:49 schrieb Lee Jones:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> > 
> > There are 5000 warnings to work through.  It will take a couple more
> > sets.  Although, ("drm/amd/display/dc/basics/fixpt31_32: Move
> > variables to where they're used") does take care of 2000 of them!
> > 
> > Lee Jones (19):
> >    drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header
> >    drm/r128/ati_pcigart: Source file headers are not good candidates for
> >      kernel-doc
> >    drm/selftests/test-drm_dp_mst_helper: Move
> >      'sideband_msg_req_encode_decode' onto the heap
> >    drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks
> >    drm/mga/mga_state: Remove unused variable 'buf_priv'
> >    drm/radeon/atom: Move prototype into shared location
> >    drm/radeon/radeon_kms: Include header containing our own prototypes
> >    drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions
> >    drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format
> >    drm/radeon/radeon: Move prototype into shared header
> >    drm/radeon/radeon_drv: Source file headers are not good candidates for
> >      kernel-doc
> >    drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're
> >      used
> >    drm/radeon/radeon_drv: Move prototypes to a shared headerfile
> >    drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr'
> >      params
> >    drm/radeon: Move prototypes to shared header
> >    drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device
> >      dev_info' from the stack
> >    drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param
> >    drm/radeon/atombios_crtc: Remove description of non-existent function
> >      param 'encoder'
> >    drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops'
> > 
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |   2 +
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c       | 104 +++++++++---------
> >   .../drm/amd/display/dc/basics/fixpt31_32.c    |   5 +
> >   .../gpu/drm/amd/display/include/fixed31_32.h  |   6 -
> >   drivers/gpu/drm/mga/mga_dma.c                 |  10 +-
> >   drivers/gpu/drm/mga/mga_state.c               |   2 -
> >   drivers/gpu/drm/omapdrm/omap_dmm_tiler.c      |   6 +-
> >   drivers/gpu/drm/omapdrm/omap_gem.c            |   3 +-
> >   drivers/gpu/drm/r128/ati_pcigart.c            |   2 +-
> >   drivers/gpu/drm/radeon/atom.h                 |   6 +
> >   drivers/gpu/drm/radeon/atombios_crtc.c        |   1 -
> >   drivers/gpu/drm/radeon/atombios_encoders.c    |   4 -
> >   drivers/gpu/drm/radeon/radeon.h               |   6 +
> >   drivers/gpu/drm/radeon/radeon_device.c        |   1 +
> >   drivers/gpu/drm/radeon/radeon_device.h        |  32 ++++++
> >   drivers/gpu/drm/radeon/radeon_display.c       |   4 -
> >   drivers/gpu/drm/radeon/radeon_drv.c           |  11 +-
> >   drivers/gpu/drm/radeon/radeon_drv.h           |   7 ++
> >   drivers/gpu/drm/radeon/radeon_kms.c           |   3 +-
> >   .../drm/selftests/test-drm_dp_mst_helper.c    |  11 +-
> >   drivers/gpu/drm/ttm/ttm_range_manager.c       |   2 +-
> >   drivers/gpu/drm/v3d/v3d_drv.c                 |  36 ------
> >   22 files changed, 138 insertions(+), 126 deletions(-)
> >   create mode 100644 drivers/gpu/drm/radeon/radeon_device.h
> > 
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: amd-gfx@lists.freedesktop.org
> > Cc: Andy Gross <andy.gross@ti.com>
> > Cc: by <jhartmann@precisioninsight.com>
> > Cc: Christian Koenig <christian.koenig@amd.com>
> > Cc: "Christian König" <christian.koenig@amd.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: Eric Anholt <eric@anholt.net>
> > Cc: Faith <faith@valinux.com>
> > Cc: Gareth Hughes <gareth@valinux.com>
> > Cc: Harry Wentland <harry.wentland@amd.com>
> > Cc: Huang Rui <ray.huang@amd.com>
> > Cc: Jeff Hartmann <jhartmann@valinux.com>
> > Cc: Keith Whitwell <keith@tungstengraphics.com>
> > Cc: Leo Li <sunpeng.li@amd.com>
> > Cc: linaro-mm-sig@lists.linaro.org
> > Cc: linux-media@vger.kernel.org
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Rob Clark <rob.clark@linaro.org>
> > Cc: Rob Clark <rob@ti.com>
> > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
  
Sam Ravnborg Nov. 7, 2020, 5:34 p.m. UTC | #4
Hi Christian.

> I'm not sure if we want to do some of the suggested changes to radeon.

All patches for radeon looks good to me except "drm/radeon/radeon: Move
prototype into shared header".

Acked-by: Sam Ravnborg <sam@ravnborg.org>
from me to have them applied (except the shared header one).
I can reply to the individual patches if you like.

	Sam
  
Lee Jones Nov. 7, 2020, 6:41 p.m. UTC | #5
On Sat, 07 Nov 2020, Sam Ravnborg wrote:

> Hi Christian.
> 
> > I'm not sure if we want to do some of the suggested changes to radeon.
> 
> All patches for radeon looks good to me except "drm/radeon/radeon: Move
> prototype into shared header".

Was that the one where the prototype needs moving to radeon.h?

> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> from me to have them applied (except the shared header one).

Thanks Sam.

> I can reply to the individual patches if you like.
  
Sam Ravnborg Nov. 7, 2020, 7:29 p.m. UTC | #6
On Sat, Nov 07, 2020 at 06:41:38PM +0000, Lee Jones wrote:
> On Sat, 07 Nov 2020, Sam Ravnborg wrote:
> 
> > Hi Christian.
> > 
> > > I'm not sure if we want to do some of the suggested changes to radeon.
> > 
> > All patches for radeon looks good to me except "drm/radeon/radeon: Move
> > prototype into shared header".
> 
> Was that the one where the prototype needs moving to radeon.h?
Yes,

	Sam
  
Lee Jones Nov. 13, 2020, 7:19 a.m. UTC | #7
On Fri, 06 Nov 2020, Lee Jones wrote:

> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 
> There are 5000 warnings to work through.  It will take a couple more
> sets.  Although, ("drm/amd/display/dc/basics/fixpt31_32: Move
> variables to where they're used") does take care of 2000 of them!
> 
> Lee Jones (19):
>   drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header
>   drm/r128/ati_pcigart: Source file headers are not good candidates for
>     kernel-doc
>   drm/selftests/test-drm_dp_mst_helper: Move
>     'sideband_msg_req_encode_decode' onto the heap
>   drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks
>   drm/mga/mga_state: Remove unused variable 'buf_priv'
>   drm/radeon/atom: Move prototype into shared location
>   drm/radeon/radeon_kms: Include header containing our own prototypes
>   drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions
>   drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format
>   drm/radeon/radeon: Move prototype into shared header
>   drm/radeon/radeon_drv: Source file headers are not good candidates for
>     kernel-doc
>   drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're
>     used
>   drm/radeon/radeon_drv: Move prototypes to a shared headerfile
>   drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr'
>     params
>   drm/radeon: Move prototypes to shared header
>   drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device
>     dev_info' from the stack
>   drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param
>   drm/radeon/atombios_crtc: Remove description of non-existent function
>     param 'encoder'
>   drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops'
> 
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |   2 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c       | 104 +++++++++---------
>  .../drm/amd/display/dc/basics/fixpt31_32.c    |   5 +
>  .../gpu/drm/amd/display/include/fixed31_32.h  |   6 -
>  drivers/gpu/drm/mga/mga_dma.c                 |  10 +-
>  drivers/gpu/drm/mga/mga_state.c               |   2 -
>  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c      |   6 +-
>  drivers/gpu/drm/omapdrm/omap_gem.c            |   3 +-
>  drivers/gpu/drm/r128/ati_pcigart.c            |   2 +-
>  drivers/gpu/drm/radeon/atom.h                 |   6 +
>  drivers/gpu/drm/radeon/atombios_crtc.c        |   1 -
>  drivers/gpu/drm/radeon/atombios_encoders.c    |   4 -
>  drivers/gpu/drm/radeon/radeon.h               |   6 +
>  drivers/gpu/drm/radeon/radeon_device.c        |   1 +
>  drivers/gpu/drm/radeon/radeon_device.h        |  32 ++++++
>  drivers/gpu/drm/radeon/radeon_display.c       |   4 -
>  drivers/gpu/drm/radeon/radeon_drv.c           |  11 +-
>  drivers/gpu/drm/radeon/radeon_drv.h           |   7 ++
>  drivers/gpu/drm/radeon/radeon_kms.c           |   3 +-
>  .../drm/selftests/test-drm_dp_mst_helper.c    |  11 +-
>  drivers/gpu/drm/ttm/ttm_range_manager.c       |   2 +-
>  drivers/gpu/drm/v3d/v3d_drv.c                 |  36 ------
>  22 files changed, 138 insertions(+), 126 deletions(-)
>  create mode 100644 drivers/gpu/drm/radeon/radeon_device.h

Still no Radeon patches in today's -next.

I really wanted to have had this set rebased by now.

How long do they take to peculate through?
  
Alex Deucher Nov. 13, 2020, 7:28 a.m. UTC | #8
On Fri, Nov 13, 2020 at 2:19 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 06 Nov 2020, Lee Jones wrote:
>
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > There are 5000 warnings to work through.  It will take a couple more
> > sets.  Although, ("drm/amd/display/dc/basics/fixpt31_32: Move
> > variables to where they're used") does take care of 2000 of them!
> >
> > Lee Jones (19):
> >   drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header
> >   drm/r128/ati_pcigart: Source file headers are not good candidates for
> >     kernel-doc
> >   drm/selftests/test-drm_dp_mst_helper: Move
> >     'sideband_msg_req_encode_decode' onto the heap
> >   drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks
> >   drm/mga/mga_state: Remove unused variable 'buf_priv'
> >   drm/radeon/atom: Move prototype into shared location
> >   drm/radeon/radeon_kms: Include header containing our own prototypes
> >   drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions
> >   drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format
> >   drm/radeon/radeon: Move prototype into shared header
> >   drm/radeon/radeon_drv: Source file headers are not good candidates for
> >     kernel-doc
> >   drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're
> >     used
> >   drm/radeon/radeon_drv: Move prototypes to a shared headerfile
> >   drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr'
> >     params
> >   drm/radeon: Move prototypes to shared header
> >   drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device
> >     dev_info' from the stack
> >   drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param
> >   drm/radeon/atombios_crtc: Remove description of non-existent function
> >     param 'encoder'
> >   drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops'
> >
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |   2 +
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c       | 104 +++++++++---------
> >  .../drm/amd/display/dc/basics/fixpt31_32.c    |   5 +
> >  .../gpu/drm/amd/display/include/fixed31_32.h  |   6 -
> >  drivers/gpu/drm/mga/mga_dma.c                 |  10 +-
> >  drivers/gpu/drm/mga/mga_state.c               |   2 -
> >  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c      |   6 +-
> >  drivers/gpu/drm/omapdrm/omap_gem.c            |   3 +-
> >  drivers/gpu/drm/r128/ati_pcigart.c            |   2 +-
> >  drivers/gpu/drm/radeon/atom.h                 |   6 +
> >  drivers/gpu/drm/radeon/atombios_crtc.c        |   1 -
> >  drivers/gpu/drm/radeon/atombios_encoders.c    |   4 -
> >  drivers/gpu/drm/radeon/radeon.h               |   6 +
> >  drivers/gpu/drm/radeon/radeon_device.c        |   1 +
> >  drivers/gpu/drm/radeon/radeon_device.h        |  32 ++++++
> >  drivers/gpu/drm/radeon/radeon_display.c       |   4 -
> >  drivers/gpu/drm/radeon/radeon_drv.c           |  11 +-
> >  drivers/gpu/drm/radeon/radeon_drv.h           |   7 ++
> >  drivers/gpu/drm/radeon/radeon_kms.c           |   3 +-
> >  .../drm/selftests/test-drm_dp_mst_helper.c    |  11 +-
> >  drivers/gpu/drm/ttm/ttm_range_manager.c       |   2 +-
> >  drivers/gpu/drm/v3d/v3d_drv.c                 |  36 ------
> >  22 files changed, 138 insertions(+), 126 deletions(-)
> >  create mode 100644 drivers/gpu/drm/radeon/radeon_device.h
>
> Still no Radeon patches in today's -next.
>
> I really wanted to have had this set rebased by now.
>
> How long do they take to peculate through?

Usually a day or two, but I was swamped the last couple of days. I
pushed an updated -next branch today:
https://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next

Alex

>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
  
Lee Jones Nov. 13, 2020, 7:36 a.m. UTC | #9
On Fri, 13 Nov 2020, Alex Deucher wrote:

> On Fri, Nov 13, 2020 at 2:19 AM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Fri, 06 Nov 2020, Lee Jones wrote:
> >
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > >
> > > There are 5000 warnings to work through.  It will take a couple more
> > > sets.  Although, ("drm/amd/display/dc/basics/fixpt31_32: Move
> > > variables to where they're used") does take care of 2000 of them!
> > >
> > > Lee Jones (19):
> > >   drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header
> > >   drm/r128/ati_pcigart: Source file headers are not good candidates for
> > >     kernel-doc
> > >   drm/selftests/test-drm_dp_mst_helper: Move
> > >     'sideband_msg_req_encode_decode' onto the heap
> > >   drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks
> > >   drm/mga/mga_state: Remove unused variable 'buf_priv'
> > >   drm/radeon/atom: Move prototype into shared location
> > >   drm/radeon/radeon_kms: Include header containing our own prototypes
> > >   drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions
> > >   drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format
> > >   drm/radeon/radeon: Move prototype into shared header
> > >   drm/radeon/radeon_drv: Source file headers are not good candidates for
> > >     kernel-doc
> > >   drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're
> > >     used
> > >   drm/radeon/radeon_drv: Move prototypes to a shared headerfile
> > >   drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr'
> > >     params
> > >   drm/radeon: Move prototypes to shared header
> > >   drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device
> > >     dev_info' from the stack
> > >   drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param
> > >   drm/radeon/atombios_crtc: Remove description of non-existent function
> > >     param 'encoder'
> > >   drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops'
> > >
> > >  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |   2 +
> > >  drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c       | 104 +++++++++---------
> > >  .../drm/amd/display/dc/basics/fixpt31_32.c    |   5 +
> > >  .../gpu/drm/amd/display/include/fixed31_32.h  |   6 -
> > >  drivers/gpu/drm/mga/mga_dma.c                 |  10 +-
> > >  drivers/gpu/drm/mga/mga_state.c               |   2 -
> > >  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c      |   6 +-
> > >  drivers/gpu/drm/omapdrm/omap_gem.c            |   3 +-
> > >  drivers/gpu/drm/r128/ati_pcigart.c            |   2 +-
> > >  drivers/gpu/drm/radeon/atom.h                 |   6 +
> > >  drivers/gpu/drm/radeon/atombios_crtc.c        |   1 -
> > >  drivers/gpu/drm/radeon/atombios_encoders.c    |   4 -
> > >  drivers/gpu/drm/radeon/radeon.h               |   6 +
> > >  drivers/gpu/drm/radeon/radeon_device.c        |   1 +
> > >  drivers/gpu/drm/radeon/radeon_device.h        |  32 ++++++
> > >  drivers/gpu/drm/radeon/radeon_display.c       |   4 -
> > >  drivers/gpu/drm/radeon/radeon_drv.c           |  11 +-
> > >  drivers/gpu/drm/radeon/radeon_drv.h           |   7 ++
> > >  drivers/gpu/drm/radeon/radeon_kms.c           |   3 +-
> > >  .../drm/selftests/test-drm_dp_mst_helper.c    |  11 +-
> > >  drivers/gpu/drm/ttm/ttm_range_manager.c       |   2 +-
> > >  drivers/gpu/drm/v3d/v3d_drv.c                 |  36 ------
> > >  22 files changed, 138 insertions(+), 126 deletions(-)
> > >  create mode 100644 drivers/gpu/drm/radeon/radeon_device.h
> >
> > Still no Radeon patches in today's -next.
> >
> > I really wanted to have had this set rebased by now.
> >
> > How long do they take to peculate through?
> 
> Usually a day or two, but I was swamped the last couple of days. I
> pushed an updated -next branch today:
> https://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next

Ah, wonderful.

I'll rebase all of the sets on Monday and see what we're left with.