Message ID | 20201106214949.2042120-1-lee.jones@linaro.org (mailing list archive) |
---|---|
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1kb9cL-000Wjo-0W; Fri, 06 Nov 2020 21:49:58 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728547AbgKFVty (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 6 Nov 2020 16:49:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbgKFVty (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 6 Nov 2020 16:49:54 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EBBCC0613CF for <linux-media@vger.kernel.org>; Fri, 6 Nov 2020 13:49:54 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id v5so2842253wmh.1 for <linux-media@vger.kernel.org>; Fri, 06 Nov 2020 13:49:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=atRaJCXFVxAlihI4r4ojii808StzDT60z5Ec9SQAR/c=; b=AjBsI4km7LOdpe3juQ0sb1PHk/smmBYDMBsiL8eKHCnqoSJbL14NUE8SdDRfeZgPkZ +DxjrVqLYfdQ0RUisTVflMg4C+aK/13Y91yRQNt2TRkZa19sIVT0k9UG106xPxHr6j7u yn20MAvlzzXtrV9HRoflVyWEBTeSdPv5cyZTveSv2dOvhkfAkOWkFbygv3qVFTMMjxy/ 52UcUdPLLPv8JITzUPM4dNiblkAqiuytJJE/0W4mNpW0bhv8k+sQE+MplDFJdyAjcc3S woDB1b9+/GwiKQm9qX3IEGWBR8b2Cqs2XAwypLa7SZ34SqSlqqYer1GahSbc0rV+0zfI MYiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=atRaJCXFVxAlihI4r4ojii808StzDT60z5Ec9SQAR/c=; b=MAe78RZKdlEQcoTTjKMEavqrwmGAyz51omviATqlSNYf1K1xNZyzyDatZHAnKWACAN Z+tMyjwxZ5jd0dHdY6z3ssyOaT8xjFQRadD/uyFeRS/T+iUAZeIxV6jgLNEv8OBX9S2e Kn/IWIon3+eZrVB6bP9Io4LLncoNcgnWw7u+98H+ThAt2ZG6GR45PY9GuO7FdKTxHCZw 26wU0k3IhATCMn0lzF+XdZwb1UgELIVZ5reXSSv13xdAcFML0UlqeQfvdrt6pBsQ7kwr tqun4Nvw86/Swn2aN4v9uQpqvOS2JHoA2KOgFWTRlW6JwIcBaOprFKy/SI8LWrS3Ofm8 dMDw== X-Gm-Message-State: AOAM533Kyx+eoH9DZ2usPnu5SJgNb3k44L4Dsdx8RfJSJI0yr5Knd3Sa 0kG4Q/rjZg5ge5rZjNqrs2+iWQ== X-Google-Smtp-Source: ABdhPJyxSilLymaZgbLjfvWQZDTgj2OWOjONwp5UO++dwOgGyrFaukmAGiTHKU2EcOOknhLQDmeuVQ== X-Received: by 2002:a7b:c24b:: with SMTP id b11mr1515570wmj.109.1604699393111; Fri, 06 Nov 2020 13:49:53 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id t199sm3981084wmt.46.2020.11.06.13.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:49:52 -0800 (PST) From: Lee Jones <lee.jones@linaro.org> To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Alex Deucher <alexander.deucher@amd.com>, amd-gfx@lists.freedesktop.org, Andy Gross <andy.gross@ti.com>, by <jhartmann@precisioninsight.com>, Christian Koenig <christian.koenig@amd.com>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, Eric Anholt <eric@anholt.net>, Faith <faith@valinux.com>, Gareth Hughes <gareth@valinux.com>, Harry Wentland <harry.wentland@amd.com>, Huang Rui <ray.huang@amd.com>, Jeff Hartmann <jhartmann@valinux.com>, Keith Whitwell <keith@tungstengraphics.com>, Leo Li <sunpeng.li@amd.com>, linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org, Philipp Zabel <p.zabel@pengutronix.de>, Rob Clark <rob.clark@linaro.org>, Rob Clark <rob@ti.com>, Sumit Semwal <sumit.semwal@linaro.org>, Tomi Valkeinen <tomi.valkeinen@ti.com> Subject: [PATCH 00/19] [Set 2] Rid W=1 warnings from GPU Date: Fri, 6 Nov 2020 21:49:30 +0000 Message-Id: <20201106214949.2042120-1-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
Rid W=1 warnings from GPU
|
|
Message
Lee Jones
Nov. 6, 2020, 9:49 p.m. UTC
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. There are 5000 warnings to work through. It will take a couple more sets. Although, ("drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're used") does take care of 2000 of them! Lee Jones (19): drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header drm/r128/ati_pcigart: Source file headers are not good candidates for kernel-doc drm/selftests/test-drm_dp_mst_helper: Move 'sideband_msg_req_encode_decode' onto the heap drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks drm/mga/mga_state: Remove unused variable 'buf_priv' drm/radeon/atom: Move prototype into shared location drm/radeon/radeon_kms: Include header containing our own prototypes drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format drm/radeon/radeon: Move prototype into shared header drm/radeon/radeon_drv: Source file headers are not good candidates for kernel-doc drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're used drm/radeon/radeon_drv: Move prototypes to a shared headerfile drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' params drm/radeon: Move prototypes to shared header drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device dev_info' from the stack drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param drm/radeon/atombios_crtc: Remove description of non-existent function param 'encoder' drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops' drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 104 +++++++++--------- .../drm/amd/display/dc/basics/fixpt31_32.c | 5 + .../gpu/drm/amd/display/include/fixed31_32.h | 6 - drivers/gpu/drm/mga/mga_dma.c | 10 +- drivers/gpu/drm/mga/mga_state.c | 2 - drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 +- drivers/gpu/drm/omapdrm/omap_gem.c | 3 +- drivers/gpu/drm/r128/ati_pcigart.c | 2 +- drivers/gpu/drm/radeon/atom.h | 6 + drivers/gpu/drm/radeon/atombios_crtc.c | 1 - drivers/gpu/drm/radeon/atombios_encoders.c | 4 - drivers/gpu/drm/radeon/radeon.h | 6 + drivers/gpu/drm/radeon/radeon_device.c | 1 + drivers/gpu/drm/radeon/radeon_device.h | 32 ++++++ drivers/gpu/drm/radeon/radeon_display.c | 4 - drivers/gpu/drm/radeon/radeon_drv.c | 11 +- drivers/gpu/drm/radeon/radeon_drv.h | 7 ++ drivers/gpu/drm/radeon/radeon_kms.c | 3 +- .../drm/selftests/test-drm_dp_mst_helper.c | 11 +- drivers/gpu/drm/ttm/ttm_range_manager.c | 2 +- drivers/gpu/drm/v3d/v3d_drv.c | 36 ------ 22 files changed, 138 insertions(+), 126 deletions(-) create mode 100644 drivers/gpu/drm/radeon/radeon_device.h Cc: Alex Deucher <alexander.deucher@amd.com> Cc: amd-gfx@lists.freedesktop.org Cc: Andy Gross <andy.gross@ti.com> Cc: by <jhartmann@precisioninsight.com> Cc: Christian Koenig <christian.koenig@amd.com> Cc: "Christian König" <christian.koenig@amd.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org Cc: Eric Anholt <eric@anholt.net> Cc: Faith <faith@valinux.com> Cc: Gareth Hughes <gareth@valinux.com> Cc: Harry Wentland <harry.wentland@amd.com> Cc: Huang Rui <ray.huang@amd.com> Cc: Jeff Hartmann <jhartmann@valinux.com> Cc: Keith Whitwell <keith@tungstengraphics.com> Cc: Leo Li <sunpeng.li@amd.com> Cc: linaro-mm-sig@lists.linaro.org Cc: linux-media@vger.kernel.org Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Rob Clark <rob.clark@linaro.org> Cc: Rob Clark <rob@ti.com> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Comments
Hi Lee and DRM folks. On Fri, Nov 06, 2020 at 09:49:30PM +0000, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > There are 5000 warnings to work through. It will take a couple more > sets. Although, ("drm/amd/display/dc/basics/fixpt31_32: Move > variables to where they're used") does take care of 2000 of them! > > Lee Jones (19): > drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header > drm/r128/ati_pcigart: Source file headers are not good candidates for > kernel-doc Applied > drm/selftests/test-drm_dp_mst_helper: Move > 'sideband_msg_req_encode_decode' onto the heap > drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks > drm/mga/mga_state: Remove unused variable 'buf_priv' Applied x2 > drm/radeon/atom: Move prototype into shared location > drm/radeon/radeon_kms: Include header containing our own prototypes > drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions > drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format > drm/radeon/radeon: Move prototype into shared header > drm/radeon/radeon_drv: Source file headers are not good candidates for > kernel-doc > drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're > used > drm/radeon/radeon_drv: Move prototypes to a shared headerfile > drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' > params > drm/radeon: Move prototypes to shared header > drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device > dev_info' from the stack > drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param > drm/radeon/atombios_crtc: Remove description of non-existent function > param 'encoder' > drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops' I have applied the three patches that has no obvious maintainer as indicated above. I assume the respective maintaines to pick radeon, omapdrm, ttm, amd, v3d and selftest patches. Sam
Well that's quite a patch set. First of all can you separate this a bit more by driver? I'm assuming we maintainers are supposed to pick that up and apply it. radeon and amdgpu can stick together since that is mostly Alex and me, but I'm not sure if we want to do some of the suggested changes to radeon. Going to pick up the single TTM change for upstreaming. Thanks, Christian. Am 06.11.20 um 22:49 schrieb Lee Jones: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > There are 5000 warnings to work through. It will take a couple more > sets. Although, ("drm/amd/display/dc/basics/fixpt31_32: Move > variables to where they're used") does take care of 2000 of them! > > Lee Jones (19): > drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header > drm/r128/ati_pcigart: Source file headers are not good candidates for > kernel-doc > drm/selftests/test-drm_dp_mst_helper: Move > 'sideband_msg_req_encode_decode' onto the heap > drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks > drm/mga/mga_state: Remove unused variable 'buf_priv' > drm/radeon/atom: Move prototype into shared location > drm/radeon/radeon_kms: Include header containing our own prototypes > drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions > drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format > drm/radeon/radeon: Move prototype into shared header > drm/radeon/radeon_drv: Source file headers are not good candidates for > kernel-doc > drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're > used > drm/radeon/radeon_drv: Move prototypes to a shared headerfile > drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' > params > drm/radeon: Move prototypes to shared header > drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device > dev_info' from the stack > drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param > drm/radeon/atombios_crtc: Remove description of non-existent function > param 'encoder' > drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops' > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 + > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 104 +++++++++--------- > .../drm/amd/display/dc/basics/fixpt31_32.c | 5 + > .../gpu/drm/amd/display/include/fixed31_32.h | 6 - > drivers/gpu/drm/mga/mga_dma.c | 10 +- > drivers/gpu/drm/mga/mga_state.c | 2 - > drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 +- > drivers/gpu/drm/omapdrm/omap_gem.c | 3 +- > drivers/gpu/drm/r128/ati_pcigart.c | 2 +- > drivers/gpu/drm/radeon/atom.h | 6 + > drivers/gpu/drm/radeon/atombios_crtc.c | 1 - > drivers/gpu/drm/radeon/atombios_encoders.c | 4 - > drivers/gpu/drm/radeon/radeon.h | 6 + > drivers/gpu/drm/radeon/radeon_device.c | 1 + > drivers/gpu/drm/radeon/radeon_device.h | 32 ++++++ > drivers/gpu/drm/radeon/radeon_display.c | 4 - > drivers/gpu/drm/radeon/radeon_drv.c | 11 +- > drivers/gpu/drm/radeon/radeon_drv.h | 7 ++ > drivers/gpu/drm/radeon/radeon_kms.c | 3 +- > .../drm/selftests/test-drm_dp_mst_helper.c | 11 +- > drivers/gpu/drm/ttm/ttm_range_manager.c | 2 +- > drivers/gpu/drm/v3d/v3d_drv.c | 36 ------ > 22 files changed, 138 insertions(+), 126 deletions(-) > create mode 100644 drivers/gpu/drm/radeon/radeon_device.h > > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: amd-gfx@lists.freedesktop.org > Cc: Andy Gross <andy.gross@ti.com> > Cc: by <jhartmann@precisioninsight.com> > Cc: Christian Koenig <christian.koenig@amd.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: David Airlie <airlied@linux.ie> > Cc: dri-devel@lists.freedesktop.org > Cc: Eric Anholt <eric@anholt.net> > Cc: Faith <faith@valinux.com> > Cc: Gareth Hughes <gareth@valinux.com> > Cc: Harry Wentland <harry.wentland@amd.com> > Cc: Huang Rui <ray.huang@amd.com> > Cc: Jeff Hartmann <jhartmann@valinux.com> > Cc: Keith Whitwell <keith@tungstengraphics.com> > Cc: Leo Li <sunpeng.li@amd.com> > Cc: linaro-mm-sig@lists.linaro.org > Cc: linux-media@vger.kernel.org > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Rob Clark <rob.clark@linaro.org> > Cc: Rob Clark <rob@ti.com> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
On Sat, 07 Nov 2020, Christian König wrote: > Well that's quite a patch set. > > First of all can you separate this a bit more by driver? I'm assuming we > maintainers are supposed to pick that up and apply it. I'm not sure what would achieve? It's not a pull-request. Either way, patches should be applied individually. > radeon and amdgpu can stick together since that is mostly Alex and me, but > I'm not sure if we want to do some of the suggested changes to radeon. That's fine. Just review, providing your reasons as to why they are not suitable and we'll work through the issues together, patch by patch. > Going to pick up the single TTM change for upstreaming. Thanks. > Am 06.11.20 um 22:49 schrieb Lee Jones: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > There are 5000 warnings to work through. It will take a couple more > > sets. Although, ("drm/amd/display/dc/basics/fixpt31_32: Move > > variables to where they're used") does take care of 2000 of them! > > > > Lee Jones (19): > > drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header > > drm/r128/ati_pcigart: Source file headers are not good candidates for > > kernel-doc > > drm/selftests/test-drm_dp_mst_helper: Move > > 'sideband_msg_req_encode_decode' onto the heap > > drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks > > drm/mga/mga_state: Remove unused variable 'buf_priv' > > drm/radeon/atom: Move prototype into shared location > > drm/radeon/radeon_kms: Include header containing our own prototypes > > drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions > > drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format > > drm/radeon/radeon: Move prototype into shared header > > drm/radeon/radeon_drv: Source file headers are not good candidates for > > kernel-doc > > drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're > > used > > drm/radeon/radeon_drv: Move prototypes to a shared headerfile > > drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' > > params > > drm/radeon: Move prototypes to shared header > > drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device > > dev_info' from the stack > > drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param > > drm/radeon/atombios_crtc: Remove description of non-existent function > > param 'encoder' > > drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops' > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 + > > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 104 +++++++++--------- > > .../drm/amd/display/dc/basics/fixpt31_32.c | 5 + > > .../gpu/drm/amd/display/include/fixed31_32.h | 6 - > > drivers/gpu/drm/mga/mga_dma.c | 10 +- > > drivers/gpu/drm/mga/mga_state.c | 2 - > > drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 +- > > drivers/gpu/drm/omapdrm/omap_gem.c | 3 +- > > drivers/gpu/drm/r128/ati_pcigart.c | 2 +- > > drivers/gpu/drm/radeon/atom.h | 6 + > > drivers/gpu/drm/radeon/atombios_crtc.c | 1 - > > drivers/gpu/drm/radeon/atombios_encoders.c | 4 - > > drivers/gpu/drm/radeon/radeon.h | 6 + > > drivers/gpu/drm/radeon/radeon_device.c | 1 + > > drivers/gpu/drm/radeon/radeon_device.h | 32 ++++++ > > drivers/gpu/drm/radeon/radeon_display.c | 4 - > > drivers/gpu/drm/radeon/radeon_drv.c | 11 +- > > drivers/gpu/drm/radeon/radeon_drv.h | 7 ++ > > drivers/gpu/drm/radeon/radeon_kms.c | 3 +- > > .../drm/selftests/test-drm_dp_mst_helper.c | 11 +- > > drivers/gpu/drm/ttm/ttm_range_manager.c | 2 +- > > drivers/gpu/drm/v3d/v3d_drv.c | 36 ------ > > 22 files changed, 138 insertions(+), 126 deletions(-) > > create mode 100644 drivers/gpu/drm/radeon/radeon_device.h > > > > Cc: Alex Deucher <alexander.deucher@amd.com> > > Cc: amd-gfx@lists.freedesktop.org > > Cc: Andy Gross <andy.gross@ti.com> > > Cc: by <jhartmann@precisioninsight.com> > > Cc: Christian Koenig <christian.koenig@amd.com> > > Cc: "Christian König" <christian.koenig@amd.com> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: David Airlie <airlied@linux.ie> > > Cc: dri-devel@lists.freedesktop.org > > Cc: Eric Anholt <eric@anholt.net> > > Cc: Faith <faith@valinux.com> > > Cc: Gareth Hughes <gareth@valinux.com> > > Cc: Harry Wentland <harry.wentland@amd.com> > > Cc: Huang Rui <ray.huang@amd.com> > > Cc: Jeff Hartmann <jhartmann@valinux.com> > > Cc: Keith Whitwell <keith@tungstengraphics.com> > > Cc: Leo Li <sunpeng.li@amd.com> > > Cc: linaro-mm-sig@lists.linaro.org > > Cc: linux-media@vger.kernel.org > > Cc: Philipp Zabel <p.zabel@pengutronix.de> > > Cc: Rob Clark <rob.clark@linaro.org> > > Cc: Rob Clark <rob@ti.com> > > Cc: Sumit Semwal <sumit.semwal@linaro.org> > > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> >
Hi Christian. > I'm not sure if we want to do some of the suggested changes to radeon. All patches for radeon looks good to me except "drm/radeon/radeon: Move prototype into shared header". Acked-by: Sam Ravnborg <sam@ravnborg.org> from me to have them applied (except the shared header one). I can reply to the individual patches if you like. Sam
On Sat, 07 Nov 2020, Sam Ravnborg wrote: > Hi Christian. > > > I'm not sure if we want to do some of the suggested changes to radeon. > > All patches for radeon looks good to me except "drm/radeon/radeon: Move > prototype into shared header". Was that the one where the prototype needs moving to radeon.h? > Acked-by: Sam Ravnborg <sam@ravnborg.org> > from me to have them applied (except the shared header one). Thanks Sam. > I can reply to the individual patches if you like.
On Sat, Nov 07, 2020 at 06:41:38PM +0000, Lee Jones wrote: > On Sat, 07 Nov 2020, Sam Ravnborg wrote: > > > Hi Christian. > > > > > I'm not sure if we want to do some of the suggested changes to radeon. > > > > All patches for radeon looks good to me except "drm/radeon/radeon: Move > > prototype into shared header". > > Was that the one where the prototype needs moving to radeon.h? Yes, Sam
On Fri, 06 Nov 2020, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > There are 5000 warnings to work through. It will take a couple more > sets. Although, ("drm/amd/display/dc/basics/fixpt31_32: Move > variables to where they're used") does take care of 2000 of them! > > Lee Jones (19): > drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header > drm/r128/ati_pcigart: Source file headers are not good candidates for > kernel-doc > drm/selftests/test-drm_dp_mst_helper: Move > 'sideband_msg_req_encode_decode' onto the heap > drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks > drm/mga/mga_state: Remove unused variable 'buf_priv' > drm/radeon/atom: Move prototype into shared location > drm/radeon/radeon_kms: Include header containing our own prototypes > drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions > drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format > drm/radeon/radeon: Move prototype into shared header > drm/radeon/radeon_drv: Source file headers are not good candidates for > kernel-doc > drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're > used > drm/radeon/radeon_drv: Move prototypes to a shared headerfile > drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' > params > drm/radeon: Move prototypes to shared header > drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device > dev_info' from the stack > drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param > drm/radeon/atombios_crtc: Remove description of non-existent function > param 'encoder' > drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops' > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 + > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 104 +++++++++--------- > .../drm/amd/display/dc/basics/fixpt31_32.c | 5 + > .../gpu/drm/amd/display/include/fixed31_32.h | 6 - > drivers/gpu/drm/mga/mga_dma.c | 10 +- > drivers/gpu/drm/mga/mga_state.c | 2 - > drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 +- > drivers/gpu/drm/omapdrm/omap_gem.c | 3 +- > drivers/gpu/drm/r128/ati_pcigart.c | 2 +- > drivers/gpu/drm/radeon/atom.h | 6 + > drivers/gpu/drm/radeon/atombios_crtc.c | 1 - > drivers/gpu/drm/radeon/atombios_encoders.c | 4 - > drivers/gpu/drm/radeon/radeon.h | 6 + > drivers/gpu/drm/radeon/radeon_device.c | 1 + > drivers/gpu/drm/radeon/radeon_device.h | 32 ++++++ > drivers/gpu/drm/radeon/radeon_display.c | 4 - > drivers/gpu/drm/radeon/radeon_drv.c | 11 +- > drivers/gpu/drm/radeon/radeon_drv.h | 7 ++ > drivers/gpu/drm/radeon/radeon_kms.c | 3 +- > .../drm/selftests/test-drm_dp_mst_helper.c | 11 +- > drivers/gpu/drm/ttm/ttm_range_manager.c | 2 +- > drivers/gpu/drm/v3d/v3d_drv.c | 36 ------ > 22 files changed, 138 insertions(+), 126 deletions(-) > create mode 100644 drivers/gpu/drm/radeon/radeon_device.h Still no Radeon patches in today's -next. I really wanted to have had this set rebased by now. How long do they take to peculate through?
On Fri, Nov 13, 2020 at 2:19 AM Lee Jones <lee.jones@linaro.org> wrote: > > On Fri, 06 Nov 2020, Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > There are 5000 warnings to work through. It will take a couple more > > sets. Although, ("drm/amd/display/dc/basics/fixpt31_32: Move > > variables to where they're used") does take care of 2000 of them! > > > > Lee Jones (19): > > drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header > > drm/r128/ati_pcigart: Source file headers are not good candidates for > > kernel-doc > > drm/selftests/test-drm_dp_mst_helper: Move > > 'sideband_msg_req_encode_decode' onto the heap > > drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks > > drm/mga/mga_state: Remove unused variable 'buf_priv' > > drm/radeon/atom: Move prototype into shared location > > drm/radeon/radeon_kms: Include header containing our own prototypes > > drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions > > drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format > > drm/radeon/radeon: Move prototype into shared header > > drm/radeon/radeon_drv: Source file headers are not good candidates for > > kernel-doc > > drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're > > used > > drm/radeon/radeon_drv: Move prototypes to a shared headerfile > > drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' > > params > > drm/radeon: Move prototypes to shared header > > drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device > > dev_info' from the stack > > drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param > > drm/radeon/atombios_crtc: Remove description of non-existent function > > param 'encoder' > > drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops' > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 + > > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 104 +++++++++--------- > > .../drm/amd/display/dc/basics/fixpt31_32.c | 5 + > > .../gpu/drm/amd/display/include/fixed31_32.h | 6 - > > drivers/gpu/drm/mga/mga_dma.c | 10 +- > > drivers/gpu/drm/mga/mga_state.c | 2 - > > drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 +- > > drivers/gpu/drm/omapdrm/omap_gem.c | 3 +- > > drivers/gpu/drm/r128/ati_pcigart.c | 2 +- > > drivers/gpu/drm/radeon/atom.h | 6 + > > drivers/gpu/drm/radeon/atombios_crtc.c | 1 - > > drivers/gpu/drm/radeon/atombios_encoders.c | 4 - > > drivers/gpu/drm/radeon/radeon.h | 6 + > > drivers/gpu/drm/radeon/radeon_device.c | 1 + > > drivers/gpu/drm/radeon/radeon_device.h | 32 ++++++ > > drivers/gpu/drm/radeon/radeon_display.c | 4 - > > drivers/gpu/drm/radeon/radeon_drv.c | 11 +- > > drivers/gpu/drm/radeon/radeon_drv.h | 7 ++ > > drivers/gpu/drm/radeon/radeon_kms.c | 3 +- > > .../drm/selftests/test-drm_dp_mst_helper.c | 11 +- > > drivers/gpu/drm/ttm/ttm_range_manager.c | 2 +- > > drivers/gpu/drm/v3d/v3d_drv.c | 36 ------ > > 22 files changed, 138 insertions(+), 126 deletions(-) > > create mode 100644 drivers/gpu/drm/radeon/radeon_device.h > > Still no Radeon patches in today's -next. > > I really wanted to have had this set rebased by now. > > How long do they take to peculate through? Usually a day or two, but I was swamped the last couple of days. I pushed an updated -next branch today: https://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next Alex > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, 13 Nov 2020, Alex Deucher wrote: > On Fri, Nov 13, 2020 at 2:19 AM Lee Jones <lee.jones@linaro.org> wrote: > > > > On Fri, 06 Nov 2020, Lee Jones wrote: > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly riddled with > > > niggly little warnings. > > > > > > There are 5000 warnings to work through. It will take a couple more > > > sets. Although, ("drm/amd/display/dc/basics/fixpt31_32: Move > > > variables to where they're used") does take care of 2000 of them! > > > > > > Lee Jones (19): > > > drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header > > > drm/r128/ati_pcigart: Source file headers are not good candidates for > > > kernel-doc > > > drm/selftests/test-drm_dp_mst_helper: Move > > > 'sideband_msg_req_encode_decode' onto the heap > > > drm/mga/mga_dma: Demote kernel-doc abusers to standard comment blocks > > > drm/mga/mga_state: Remove unused variable 'buf_priv' > > > drm/radeon/atom: Move prototype into shared location > > > drm/radeon/radeon_kms: Include header containing our own prototypes > > > drm/omapdrm/omap_gem: Fix misnamed and missing parameter descriptions > > > drm/omapdrm/omap_dmm_tiler: Demote abusive use of kernel-doc format > > > drm/radeon/radeon: Move prototype into shared header > > > drm/radeon/radeon_drv: Source file headers are not good candidates for > > > kernel-doc > > > drm/amd/display/dc/basics/fixpt31_32: Move variables to where they're > > > used > > > drm/radeon/radeon_drv: Move prototypes to a shared headerfile > > > drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' > > > params > > > drm/radeon: Move prototypes to shared header > > > drm/amd/amdgpu/amdgpu_kms: Remove 'struct drm_amdgpu_info_device > > > dev_info' from the stack > > > drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param > > > drm/radeon/atombios_crtc: Remove description of non-existent function > > > param 'encoder' > > > drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops' > > > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 + > > > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 104 +++++++++--------- > > > .../drm/amd/display/dc/basics/fixpt31_32.c | 5 + > > > .../gpu/drm/amd/display/include/fixed31_32.h | 6 - > > > drivers/gpu/drm/mga/mga_dma.c | 10 +- > > > drivers/gpu/drm/mga/mga_state.c | 2 - > > > drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 +- > > > drivers/gpu/drm/omapdrm/omap_gem.c | 3 +- > > > drivers/gpu/drm/r128/ati_pcigart.c | 2 +- > > > drivers/gpu/drm/radeon/atom.h | 6 + > > > drivers/gpu/drm/radeon/atombios_crtc.c | 1 - > > > drivers/gpu/drm/radeon/atombios_encoders.c | 4 - > > > drivers/gpu/drm/radeon/radeon.h | 6 + > > > drivers/gpu/drm/radeon/radeon_device.c | 1 + > > > drivers/gpu/drm/radeon/radeon_device.h | 32 ++++++ > > > drivers/gpu/drm/radeon/radeon_display.c | 4 - > > > drivers/gpu/drm/radeon/radeon_drv.c | 11 +- > > > drivers/gpu/drm/radeon/radeon_drv.h | 7 ++ > > > drivers/gpu/drm/radeon/radeon_kms.c | 3 +- > > > .../drm/selftests/test-drm_dp_mst_helper.c | 11 +- > > > drivers/gpu/drm/ttm/ttm_range_manager.c | 2 +- > > > drivers/gpu/drm/v3d/v3d_drv.c | 36 ------ > > > 22 files changed, 138 insertions(+), 126 deletions(-) > > > create mode 100644 drivers/gpu/drm/radeon/radeon_device.h > > > > Still no Radeon patches in today's -next. > > > > I really wanted to have had this set rebased by now. > > > > How long do they take to peculate through? > > Usually a day or two, but I was swamped the last couple of days. I > pushed an updated -next branch today: > https://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next Ah, wonderful. I'll rebase all of the sets on Monday and see what we're left with.