| Message ID | 20190916100433.24367-1-hverkuil-cisco@xs4all.nl (mailing list archive) |
|---|---|
| Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1i9ns6-0003R7-7t; Mon, 16 Sep 2019 10:04:38 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732024AbfIPKEg (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 16 Sep 2019 06:04:36 -0400 Received: from lb3-smtp-cloud7.xs4all.net ([194.109.24.31]:41045 "EHLO lb3-smtp-cloud7.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727907AbfIPKEg (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 16 Sep 2019 06:04:36 -0400 Received: from marune.fritz.box ([IPv6:2001:983:e9a7:1:3124:3fc9:5634:2d8]) by smtp-cloud7.xs4all.net with ESMTPA id 9ns1iUw5J8SjN9ns2iWvYj; Mon, 16 Sep 2019 12:04:34 +0200 From: Hans Verkuil <hverkuil-cisco@xs4all.nl> To: linux-media@vger.kernel.org Cc: Dave Stevenson <dave.stevenson@raspberrypi.org>, Sakari Ailus <sakari.ailus@iki.fi> Subject: [PATCHv2 0/2] Add helper functions to print a fourcc Date: Mon, 16 Sep 2019 12:04:31 +0200 Message-Id: <20190916100433.24367-1-hverkuil-cisco@xs4all.nl> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4wfGCVO1CTrqu7X/RcEcwhAGE3GQ2tbv8/wuv/u54EMQnbn0G9cIdVH3wENsoASBaFqWxPnw7vum6IFVtFkI8JoJg2+nUXzxy4qEQbHRvK5YpOvt4wRgkZ wLEtsbc9abjLOSeA9+6ilbnuNYhX27L0g1dcLpxuwglRHVstk0SBRHOvTEoM4VDe4Lp6nRosYSnlXgE0uR3awgL2WRMcfkmN4oFpKc2qcHF0O8MH7lG+NwP2 cCa+N4SgVoujBJd/9Od3qzNDwnfxtlB284SY114lj6n5cI16Wy7gLflCyaviiakgRpMnSCJ2mcCUiY1UOPsntyKG2mo6vJP3enw3Dt8rMI0= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
| Series |
Add helper functions to print a fourcc
|
|
Message
Hans Verkuil
Sept. 16, 2019, 10:04 a.m. UTC
It turns out that Sakari posted a newer patch in 2018. I used that for this v2: https://patchwork.linuxtv.org/patch/48372/ Mauro commented on that original patch that there was no need to have this available for userspace. I disagree: why wouldn't userspace want to report pixelformats? It happens in several places in v4l-utils, and there the pixelformats are printed in different ways as well. Providing a standard way of reporting a V4L2 fourcc is very useful. Regards, Hans Hans Verkuil (1): v4l2-ioctl.c: use new v4l2_fourcc_conv/args macros Sakari Ailus (1): v4l: Add macros for printing V4L fourcc values .../media/videodev2.h.rst.exceptions | 2 + drivers/media/v4l2-core/v4l2-ioctl.c | 58 ++++++------------- include/uapi/linux/videodev2.h | 27 +++++++++ 3 files changed, 47 insertions(+), 40 deletions(-)
Comments
On Mon, Sep 16, 2019 at 12:04:31PM +0200, Hans Verkuil wrote: > It turns out that Sakari posted a newer patch in 2018. I used that > for this v2: https://patchwork.linuxtv.org/patch/48372/ > > Mauro commented on that original patch that there was no need to > have this available for userspace. > > I disagree: why wouldn't userspace want to report pixelformats? > > It happens in several places in v4l-utils, and there the pixelformats are > printed in different ways as well. Providing a standard way of reporting > a V4L2 fourcc is very useful. Thanks, Hans! Can you take these to your tree (perhaps pending some sort of agreement with Mauro)?
On 9/16/19 1:52 PM, Sakari Ailus wrote: > On Mon, Sep 16, 2019 at 12:04:31PM +0200, Hans Verkuil wrote: >> It turns out that Sakari posted a newer patch in 2018. I used that >> for this v2: https://patchwork.linuxtv.org/patch/48372/ >> >> Mauro commented on that original patch that there was no need to >> have this available for userspace. >> >> I disagree: why wouldn't userspace want to report pixelformats? >> >> It happens in several places in v4l-utils, and there the pixelformats are >> printed in different ways as well. Providing a standard way of reporting >> a V4L2 fourcc is very useful. > > Thanks, Hans! > > Can you take these to your tree (perhaps pending some sort of agreement > with Mauro)? > Certainly. Hans
Hi Hans. On Mon, 16 Sep 2019 at 13:00, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > > On 9/16/19 1:52 PM, Sakari Ailus wrote: > > On Mon, Sep 16, 2019 at 12:04:31PM +0200, Hans Verkuil wrote: > >> It turns out that Sakari posted a newer patch in 2018. I used that > >> for this v2: https://patchwork.linuxtv.org/patch/48372/ > >> > >> Mauro commented on that original patch that there was no need to > >> have this available for userspace. > >> > >> I disagree: why wouldn't userspace want to report pixelformats? > >> > >> It happens in several places in v4l-utils, and there the pixelformats are > >> printed in different ways as well. Providing a standard way of reporting > >> a V4L2 fourcc is very useful. > > > > Thanks, Hans! > > > > Can you take these to your tree (perhaps pending some sort of agreement > > with Mauro)? > > > > Certainly. > > Hans What happened to these? Patchwork is flagging them as rejected[1], but there's only been positive responses to them on the mailing list. Thanks. Dave [1] https://patchwork.linuxtv.org/patch/58781/ and https://patchwork.linuxtv.org/patch/58780/
Hi Hans, On 29/01/2020 11:52, Dave Stevenson wrote: > Hi Hans. > > On Mon, 16 Sep 2019 at 13:00, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: >> >> On 9/16/19 1:52 PM, Sakari Ailus wrote: >>> On Mon, Sep 16, 2019 at 12:04:31PM +0200, Hans Verkuil wrote: >>>> It turns out that Sakari posted a newer patch in 2018. I used that >>>> for this v2: https://patchwork.linuxtv.org/patch/48372/ >>>> >>>> Mauro commented on that original patch that there was no need to >>>> have this available for userspace. >>>> >>>> I disagree: why wouldn't userspace want to report pixelformats? Indeed. I've just had to hand code this for libcamera. (Though, being C++, I don't think I could have used these macros anyway) >>>> It happens in several places in v4l-utils, and there the pixelformats are >>>> printed in different ways as well. Providing a standard way of reporting >>>> a V4L2 fourcc is very useful. >>> >>> Thanks, Hans! >>> >>> Can you take these to your tree (perhaps pending some sort of agreement >>> with Mauro)? >>> >> >> Certainly. >> >> Hans > > What happened to these? Patchwork is flagging them as rejected[1], but > there's only been positive responses to them on the mailing list. I'll add another +1 ... -- Kieran > > Thanks. > Dave > > [1] https://patchwork.linuxtv.org/patch/58781/ and > https://patchwork.linuxtv.org/patch/58780/
On Wed, 29 Jan 2020 at 11:52, Dave Stevenson <dave.stevenson@raspberrypi.com> wrote: > > Hi Hans. > > On Mon, 16 Sep 2019 at 13:00, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > > > > On 9/16/19 1:52 PM, Sakari Ailus wrote: > > > On Mon, Sep 16, 2019 at 12:04:31PM +0200, Hans Verkuil wrote: > > >> It turns out that Sakari posted a newer patch in 2018. I used that > > >> for this v2: https://patchwork.linuxtv.org/patch/48372/ > > >> > > >> Mauro commented on that original patch that there was no need to > > >> have this available for userspace. > > >> > > >> I disagree: why wouldn't userspace want to report pixelformats? > > >> > > >> It happens in several places in v4l-utils, and there the pixelformats are > > >> printed in different ways as well. Providing a standard way of reporting > > >> a V4L2 fourcc is very useful. > > > > > > Thanks, Hans! > > > > > > Can you take these to your tree (perhaps pending some sort of agreement > > > with Mauro)? > > > > > > > Certainly. > > > > Hans > > What happened to these? Patchwork is flagging them as rejected[1], but > there's only been positive responses to them on the mailing list. Ping. Why were these patches rejected? Dave > Thanks. > Dave > > [1] https://patchwork.linuxtv.org/patch/58781/ and > https://patchwork.linuxtv.org/patch/58780/
Hi Dave, On Wed, Mar 25, 2020 at 01:50:44PM +0000, Dave Stevenson wrote: > On Wed, 29 Jan 2020 at 11:52, Dave Stevenson > <dave.stevenson@raspberrypi.com> wrote: > > > > Hi Hans. > > > > On Mon, 16 Sep 2019 at 13:00, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > > > > > > On 9/16/19 1:52 PM, Sakari Ailus wrote: > > > > On Mon, Sep 16, 2019 at 12:04:31PM +0200, Hans Verkuil wrote: > > > >> It turns out that Sakari posted a newer patch in 2018. I used that > > > >> for this v2: https://patchwork.linuxtv.org/patch/48372/ > > > >> > > > >> Mauro commented on that original patch that there was no need to > > > >> have this available for userspace. > > > >> > > > >> I disagree: why wouldn't userspace want to report pixelformats? > > > >> > > > >> It happens in several places in v4l-utils, and there the pixelformats are > > > >> printed in different ways as well. Providing a standard way of reporting > > > >> a V4L2 fourcc is very useful. > > > > > > > > Thanks, Hans! > > > > > > > > Can you take these to your tree (perhaps pending some sort of agreement > > > > with Mauro)? > > > > > > > > > > Certainly. > > > > > > Hans > > > > What happened to these? Patchwork is flagging them as rejected[1], but > > there's only been positive responses to them on the mailing list. > > Ping. Why were these patches rejected? This was discussed on media-maint channel. The log is here: <URL:https://linuxtv.org/irc/irclogger_log/media-maint?date=2020-02-06,Thu&raw=on>
Hi Sakari On Tue, 31 Mar 2020 at 11:28, Sakari Ailus <sakari.ailus@iki.fi> wrote: > > Hi Dave, > > On Wed, Mar 25, 2020 at 01:50:44PM +0000, Dave Stevenson wrote: > > On Wed, 29 Jan 2020 at 11:52, Dave Stevenson > > <dave.stevenson@raspberrypi.com> wrote: > > > > > > Hi Hans. > > > > > > On Mon, 16 Sep 2019 at 13:00, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > > > > > > > > On 9/16/19 1:52 PM, Sakari Ailus wrote: > > > > > On Mon, Sep 16, 2019 at 12:04:31PM +0200, Hans Verkuil wrote: > > > > >> It turns out that Sakari posted a newer patch in 2018. I used that > > > > >> for this v2: https://patchwork.linuxtv.org/patch/48372/ > > > > >> > > > > >> Mauro commented on that original patch that there was no need to > > > > >> have this available for userspace. > > > > >> > > > > >> I disagree: why wouldn't userspace want to report pixelformats? > > > > >> > > > > >> It happens in several places in v4l-utils, and there the pixelformats are > > > > >> printed in different ways as well. Providing a standard way of reporting > > > > >> a V4L2 fourcc is very useful. > > > > > > > > > > Thanks, Hans! > > > > > > > > > > Can you take these to your tree (perhaps pending some sort of agreement > > > > > with Mauro)? > > > > > > > > > > > > > Certainly. > > > > > > > > Hans > > > > > > What happened to these? Patchwork is flagging them as rejected[1], but > > > there's only been positive responses to them on the mailing list. > > > > Ping. Why were these patches rejected? > > This was discussed on media-maint channel. The log is here: > > <URL:https://linuxtv.org/irc/irclogger_log/media-maint?date=2020-02-06,Thu&raw=on> Thanks, it's useful to know what's going on. The patchwork information was pretty opaque. The log includes [12:41] <sailus> If you insist, I can write a patch, and put your Suggested-by: tag there. :^) [12:41] <mchehab> yeah, please do so [12:42] <mchehab> the best is to also c/c drm ML Has that happened and I've missed it, or is it still on the pending queue? Dave
On Tue, Mar 31, 2020 at 03:05:59PM +0100, Dave Stevenson wrote: > Hi Sakari > > On Tue, 31 Mar 2020 at 11:28, Sakari Ailus <sakari.ailus@iki.fi> wrote: > > > > Hi Dave, > > > > On Wed, Mar 25, 2020 at 01:50:44PM +0000, Dave Stevenson wrote: > > > On Wed, 29 Jan 2020 at 11:52, Dave Stevenson > > > <dave.stevenson@raspberrypi.com> wrote: > > > > > > > > Hi Hans. > > > > > > > > On Mon, 16 Sep 2019 at 13:00, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > > > > > > > > > > On 9/16/19 1:52 PM, Sakari Ailus wrote: > > > > > > On Mon, Sep 16, 2019 at 12:04:31PM +0200, Hans Verkuil wrote: > > > > > >> It turns out that Sakari posted a newer patch in 2018. I used that > > > > > >> for this v2: https://patchwork.linuxtv.org/patch/48372/ > > > > > >> > > > > > >> Mauro commented on that original patch that there was no need to > > > > > >> have this available for userspace. > > > > > >> > > > > > >> I disagree: why wouldn't userspace want to report pixelformats? > > > > > >> > > > > > >> It happens in several places in v4l-utils, and there the pixelformats are > > > > > >> printed in different ways as well. Providing a standard way of reporting > > > > > >> a V4L2 fourcc is very useful. > > > > > > > > > > > > Thanks, Hans! > > > > > > > > > > > > Can you take these to your tree (perhaps pending some sort of agreement > > > > > > with Mauro)? > > > > > > > > > > > > > > > > Certainly. > > > > > > > > > > Hans > > > > > > > > What happened to these? Patchwork is flagging them as rejected[1], but > > > > there's only been positive responses to them on the mailing list. > > > > > > Ping. Why were these patches rejected? > > > > This was discussed on media-maint channel. The log is here: > > > > <URL:https://linuxtv.org/irc/irclogger_log/media-maint?date=2020-02-06,Thu&raw=on> > > Thanks, it's useful to know what's going on. The patchwork information > was pretty opaque. > > The log includes > [12:41] <sailus> If you insist, I can write a patch, and put your > Suggested-by: tag there. :^) > [12:41] <mchehab> yeah, please do so > [12:42] <mchehab> the best is to also c/c drm ML > Has that happened and I've missed it, or is it still on the pending queue? Looking at the log reminded me to write it. :-) I'll test it first and then send it --- I'll cc you as well.