LinuxTV Patchwork [v2,2/4] media: coda: Remove unbalanced and unneeded mutex unlock

mail settings
Submitter Ezequiel Garcia
Date May 2, 2019, 10 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/55992/
State New
Delegated to: Hans Verkuil
Headers show


Ezequiel Garcia - May 2, 2019, 10 p.m.
The mutex unlock in the threaded interrupt handler is not paired
with any mutex lock. Remove it.

This bug has been here for a really long time, so it applies
to any stable repo.

Reviewed-by: Philipp Zabel <>
Signed-off-by: Ezequiel Garcia <>
 drivers/media/platform/coda/coda-bit.c | 1 -
 1 file changed, 1 deletion(-)


diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c
index eaa86737fa04..bddd2f5c8c2b 100644
--- a/drivers/media/platform/coda/coda-bit.c
+++ b/drivers/media/platform/coda/coda-bit.c
@@ -2308,7 +2308,6 @@  irqreturn_t coda_irq_handler(int irq, void *data)
 	if (ctx == NULL) {
 			 "Instance released before the end of transaction\n");
-		mutex_unlock(&dev->coda_mutex);
 		return IRQ_HANDLED;

Privacy Policy