LinuxTV Patchwork [v2,2/4] media: coda: Remove unbalanced and unneeded mutex unlock

login
register
mail settings
Submitter Ezequiel Garcia
Date May 2, 2019, 10 p.m.
Message ID <20190502220045.14962-3-ezequiel@collabora.com>
Download mbox | patch
Permalink /patch/55992/
State New
Delegated to: Hans Verkuil
Headers show

Comments

Ezequiel Garcia - May 2, 2019, 10 p.m.
The mutex unlock in the threaded interrupt handler is not paired
with any mutex lock. Remove it.

This bug has been here for a really long time, so it applies
to any stable repo.

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
 drivers/media/platform/coda/coda-bit.c | 1 -
 1 file changed, 1 deletion(-)

Patch

diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c
index eaa86737fa04..bddd2f5c8c2b 100644
--- a/drivers/media/platform/coda/coda-bit.c
+++ b/drivers/media/platform/coda/coda-bit.c
@@ -2308,7 +2308,6 @@  irqreturn_t coda_irq_handler(int irq, void *data)
 	if (ctx == NULL) {
 		v4l2_err(&dev->v4l2_dev,
 			 "Instance released before the end of transaction\n");
-		mutex_unlock(&dev->coda_mutex);
 		return IRQ_HANDLED;
 	}
 

Privacy Policy