LinuxTV Patchwork [4/7] media: aspeed: remove IRQF_SHARED flag

mail settings
Submitter Jae Hyun Yoo
Date May 2, 2019, 7:13 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/55987/
State New
Delegated to: Hans Verkuil
Headers show


Jae Hyun Yoo - May 2, 2019, 7:13 p.m.
Video Engine has a dedicated interrupt line so this driver doesn't
need to use IRQF_SHARED flag so remove it. Also, it'd be good for
following what Thomas recommended in the IRQF_ONESHOT support
patch like below:

"Note that for now IRQF_ONESHOT cannot be used with IRQF_SHARED to
avoid complex accounting mechanisms."

Signed-off-by: Jae Hyun Yoo <>
Reviewed-by: Eddie James <>
 drivers/media/platform/aspeed-video.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
index e1bdafeed007..d88e8d238c49 100644
--- a/drivers/media/platform/aspeed-video.c
+++ b/drivers/media/platform/aspeed-video.c
@@ -1616,8 +1616,7 @@  static int aspeed_video_init(struct aspeed_video *video)
 	rc = devm_request_threaded_irq(dev, irq, NULL, aspeed_video_irq,
-				       video);
+				       IRQF_ONESHOT, DEVICE_NAME, video);
 	if (rc < 0) {
 		dev_err(dev, "Unable to request IRQ %d\n", irq);
 		return rc;

Privacy Policy