Message ID | 20181102160009.17267-2-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1gIbsb-00018Y-8h; Fri, 02 Nov 2018 16:01:01 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727465AbeKCBId (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 2 Nov 2018 21:08:33 -0400 Received: from vsp-unauthed02.binero.net ([195.74.38.227]:30530 "EHLO vsp-unauthed02.binero.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727250AbeKCBId (ORCPT <rfc822; linux-media@vger.kernel.org>); Fri, 2 Nov 2018 21:08:33 -0400 X-Halon-ID: 79d4d6c6-deb8-11e8-874f-005056917f90 Authorized-sender: niklas@soderlund.pp.se Received: from bismarck.berto.se (unknown [89.233.230.99]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA id 79d4d6c6-deb8-11e8-874f-005056917f90; Fri, 02 Nov 2018 17:00:54 +0100 (CET) From: =?UTF-8?q?Niklas=20S=C3=B6derlund?= <niklas.soderlund+renesas@ragnatech.se> To: Kieran Bingham <kieran.bingham@ideasonboard.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Jacopo Mondi <jacopo@jmondi.org>, linux-media@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, =?UTF-8?q?Niklas=20S=C3=B6derlund?= <niklas.soderlund+renesas@ragnatech.se>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org Subject: [PATCH v3 1/4] dt-bindings: adv748x: make data-lanes property mandatory for CSI-2 endpoints Date: Fri, 2 Nov 2018 17:00:06 +0100 Message-Id: <20181102160009.17267-2-niklas.soderlund+renesas@ragnatech.se> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181102160009.17267-1-niklas.soderlund+renesas@ragnatech.se> References: <20181102160009.17267-1-niklas.soderlund+renesas@ragnatech.se> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Niklas Söderlund
Nov. 2, 2018, 4 p.m. UTC
The CSI-2 transmitters can use a different number of lanes to transmit
data. Make the data-lanes mandatory for the endpoints that describe the
transmitters as no good default can be set to fallback on.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
* Changes since v2
- Update paragraph according to Laurents comments.
---
Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
Hi Niklas, On Fri, Nov 02, 2018 at 05:00:06PM +0100, Niklas Söderlund wrote: > The CSI-2 transmitters can use a different number of lanes to transmit > data. Make the data-lanes mandatory for the endpoints that describe the > transmitters as no good default can be set to fallback on. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > --- > * Changes since v2 > - Update paragraph according to Laurents comments. > --- > Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > index 5dddc95f9cc46084..bffbabc879efd86c 100644 > --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > @@ -48,7 +48,9 @@ are numbered as follows. > TXA source 10 > TXB source 11 > > -The digital output port nodes must contain at least one endpoint. > +The digital output port nodes, when present, shall contain at least one > +endpoint. Each of those endpoints shall contain the data-lanes property as > +described in video-interfaces.txt. > > Ports are optional if they are not connected to anything at the hardware level. > Re-vamping my ignored comment on v2, I still think you should list here the accepted values for each TX as they're actually a property of the hw device itself. Required endpoint properties: - data-lanes: See "video-interfaces.txt" for description. The property is mandatory for CSI-2 output endpoints and the accepted value depends on which endpoint the property is applied to: - TXA: accepted values are <1>, <2>, <4> - TXB: accepted value is <1> > -- > 2.19.1 >
Hi Niklas, Thank you for the patch. On Friday, 2 November 2018 18:00:06 EET Niklas Söderlund wrote: > The CSI-2 transmitters can use a different number of lanes to transmit > data. Make the data-lanes mandatory for the endpoints that describe the > transmitters as no good default can be set to fallback on. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > * Changes since v2 > - Update paragraph according to Laurents comments. > --- > Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > b/Documentation/devicetree/bindings/media/i2c/adv748x.txt index > 5dddc95f9cc46084..bffbabc879efd86c 100644 > --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > @@ -48,7 +48,9 @@ are numbered as follows. > TXA source 10 > TXB source 11 > > -The digital output port nodes must contain at least one endpoint. > +The digital output port nodes, when present, shall contain at least one > +endpoint. Each of those endpoints shall contain the data-lanes property as > +described in video-interfaces.txt. > > Ports are optional if they are not connected to anything at the hardware > level.
On Mon, Nov 05, 2018 at 09:41:06AM +0100, jacopo mondi wrote: > Hi Niklas, > > On Fri, Nov 02, 2018 at 05:00:06PM +0100, Niklas Söderlund wrote: > > The CSI-2 transmitters can use a different number of lanes to transmit > > data. Make the data-lanes mandatory for the endpoints that describe the > > transmitters as no good default can be set to fallback on. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > > > --- > > * Changes since v2 > > - Update paragraph according to Laurents comments. > > --- > > Documentation/devicetree/bindings/media/i2c/adv748x.txt | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > > index 5dddc95f9cc46084..bffbabc879efd86c 100644 > > --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > > @@ -48,7 +48,9 @@ are numbered as follows. > > TXA source 10 > > TXB source 11 > > > > -The digital output port nodes must contain at least one endpoint. > > +The digital output port nodes, when present, shall contain at least one > > +endpoint. Each of those endpoints shall contain the data-lanes property as > > +described in video-interfaces.txt. > > > > Ports are optional if they are not connected to anything at the hardware level. > > > > Re-vamping my ignored comment on v2, I still think you should list here the > accepted values for each TX as they're actually a property of the hw > device itself. > > Required endpoint properties: > - data-lanes: See "video-interfaces.txt" for description. The property > is mandatory for CSI-2 output endpoints and the accepted value > depends on which endpoint the property is applied to: > - TXA: accepted values are <1>, <2>, <4> > - TXB: accepted value is <1> +1 Rob
diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt b/Documentation/devicetree/bindings/media/i2c/adv748x.txt index 5dddc95f9cc46084..bffbabc879efd86c 100644 --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt @@ -48,7 +48,9 @@ are numbered as follows. TXA source 10 TXB source 11 -The digital output port nodes must contain at least one endpoint. +The digital output port nodes, when present, shall contain at least one +endpoint. Each of those endpoints shall contain the data-lanes property as +described in video-interfaces.txt. Ports are optional if they are not connected to anything at the hardware level.