diff mbox

media: i2c: fix warning in Aptina MT9V111

Message ID 1532786089-15015-1-git-send-email-jasmin@anw.at (mailing list archive)
State Accepted, archived
Delegated to: Sakari Ailus
Headers

Commit Message

Jasmin J. July 28, 2018, 1:54 p.m. UTC 
  From: Jasmin Jessich <jasmin@anw.at>

This fixes the "'idx' may be used uninitialized in this function"
warning.

Cc:  Jacopo Mondi <jacopo+renesas@jmondi.org>
Signed-off-by: Jasmin Jessich <jasmin@anw.at>
---
 drivers/media/i2c/mt9v111.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jacopo Mondi July 30, 2018, 7:52 a.m. UTC | #1 
Hi Jasmin,

On Sat, Jul 28, 2018 at 03:54:49PM +0200, Jasmin J. wrote:
> From: Jasmin Jessich <jasmin@anw.at>
>
> This fixes the "'idx' may be used uninitialized in this function"
> warning.
>
> Cc:  Jacopo Mondi <jacopo+renesas@jmondi.org>
> Signed-off-by: Jasmin Jessich <jasmin@anw.at>

Thanks for the patch

Acked-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
   j

> ---
>  drivers/media/i2c/mt9v111.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
> index da8f6ab..58d5f22 100644
> --- a/drivers/media/i2c/mt9v111.c
> +++ b/drivers/media/i2c/mt9v111.c
> @@ -884,7 +884,7 @@ static int mt9v111_set_format(struct v4l2_subdev *subdev,
>  	struct v4l2_mbus_framefmt new_fmt;
>  	struct v4l2_mbus_framefmt *__fmt;
>  	unsigned int best_fit = ~0L;
> -	unsigned int idx;
> +	unsigned int idx = 0;
>  	unsigned int i;
>
>  	mutex_lock(&mt9v111->stream_mutex);
> --
> 2.7.4
>
diff mbox

Patch

diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
index da8f6ab..58d5f22 100644
--- a/drivers/media/i2c/mt9v111.c
+++ b/drivers/media/i2c/mt9v111.c
@@ -884,7 +884,7 @@  static int mt9v111_set_format(struct v4l2_subdev *subdev,
 	struct v4l2_mbus_framefmt new_fmt;
 	struct v4l2_mbus_framefmt *__fmt;
 	unsigned int best_fit = ~0L;
-	unsigned int idx;
+	unsigned int idx = 0;
 	unsigned int i;
 
 	mutex_lock(&mt9v111->stream_mutex);