| Message ID | 59C10A00.2070000@googlemail.com (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1duHPj-00057v-1Z; Tue, 19 Sep 2017 12:14:07 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbdISMN6 (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Tue, 19 Sep 2017 08:13:58 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:38805 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751513AbdISMN4 (ORCPT <rfc822;linux-media@vger.kernel.org>); Tue, 19 Sep 2017 08:13:56 -0400 Received: by mail-wr0-f196.google.com with SMTP id p37so2108315wrb.5; Tue, 19 Sep 2017 05:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-transfer-encoding; bh=OAEveb03FGGPh7Nzmcq1chbdydX2e/b6KNJAxjNJdt4=; b=D0a84NyxdpwLnNTH0JfNe4M2/7ddgfaKABxxR70OnYWakKlmZ2592STF18SpayasP+ DmxJ0ar932k5or+NHz79/L5sAvADMmJqkVbt93VzgleDw3hDtXk+YVDTIQcwZKAVbFm7 5epjvchYqzJxQafix/9m+qr0Am40UiZsaPpVIEsTziAtXTVjQ9V8092vV8ES1bNQt9j3 nFzmn7ZdfHjarvfWYr7G8Om8bZBqC+lJQxh61dNNADov1IRAbqpvbCGm0zmlCZ9p4IgV 5P5aAyJsJrx/u2tYwSXmF9xYJO4rAp1t5tdZtrSijDizWbzJ5wfMSJ+Qt8Wkr3lwNyjJ rmnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:content-transfer-encoding; bh=OAEveb03FGGPh7Nzmcq1chbdydX2e/b6KNJAxjNJdt4=; b=I6lDGfXflPGoFPNaZMkftAy7bIWSgbOB26G3EzbY6vb8hHhO+UpRfeKFRGjFgHaPpQ 3oct4MIfigmKT61uMMxfyiW1VUO/8rhMfe5ZwZfKo1LFA0a+En7KAs+puolSQzFM0iBE jfdCzAiYs//23cfhaQVcDhIuNSkDgLOfjx18kuq4nBYVwa582bBTgFVelNIfMr84AVGn 7Ui8Nfgz/SXicPiUQ+GHNYuTMmVHToguW56+SiX1NoqEhU1J8ArFnJoujM2wZuS9vmTr dUAg2I2c7LE+OI9ECX7qIEs8JtbQ88+ees2HUbS1pjLW5QPTNja9bqL8lfdi1TUkY3WN Zhkw== X-Gm-Message-State: AHPjjUiuy436T7JxlU78SB0g/PsbAxxAzYUYhRd4H9HPWEg9dxWh3/xT z4WSgivRsU9YfHaUOGWpfr8bYVVf X-Google-Smtp-Source: AOwi7QAKkPO6U/kYAA4Io4Wna9uyOBPYSYMcuw6aQ9kquftMRl3/7yBhtyonxXMVTFBBsnFixmt57Q== X-Received: by 10.223.184.11 with SMTP id h11mr1183390wrf.159.1505823234915; Tue, 19 Sep 2017 05:13:54 -0700 (PDT) Received: from [192.168.32.103] (cpc104826-sgyl39-2-0-cust385.18-2.cable.virginm.net. [77.96.115.130]) by smtp.googlemail.com with ESMTPSA id w82sm2973064wme.5.2017.09.19.05.13.53 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Sep 2017 05:13:54 -0700 (PDT) Message-ID: <59C10A00.2070000@googlemail.com> Date: Tue, 19 Sep 2017 13:13:52 +0100 From: Nigel Kettlewell <nigel.kettlewell@googlemail.com> User-Agent: Postbox 4.0.8 (Windows/20151105) MIME-Version: 1.0 To: crope@iki.fi CC: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Fix for hanging si2168 in PCTV 292e, making the code match Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Nigel Kettlewell
Sept. 19, 2017, 12:13 p.m. UTC
[re-sending as plain text] Fix for hanging si2168 in PCTV 292e USB, making the code match the comment. Using firmware v4.0.11 the 292e would work once and then hang on subsequent attempts to view DVB channels, until physically unplugged and plugged back in. With this patch, the warm state is reset for v4.0.11 and it appears to work both on the first attempt and on subsequent attempts. (Patch basis Linux 4.11.9 f82a53b87594f460f2dd9983eeb851a5840e8df8) --- drivers/media/dvb-frontends/si2168.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.4
Comments
Em Tue, 19 Sep 2017 13:13:52 +0100 Nigel Kettlewell <nigel.kettlewell@googlemail.com> escreveu: > [re-sending as plain text] > > Fix for hanging si2168 in PCTV 292e USB, making the code match the comment. > > Using firmware v4.0.11 the 292e would work once and then hang on > subsequent attempts to view DVB channels, until physically unplugged and > plugged back in. > > With this patch, the warm state is reset for v4.0.11 and it appears to > work both on the first attempt and on subsequent attempts. > > (Patch basis Linux 4.11.9 f82a53b87594f460f2dd9983eeb851a5840e8df8) Patch is missing a Signed-off-by. See: https://elinux.org/Developer_Certificate_Of_Origin). > > --- > drivers/media/dvb-frontends/si2168.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-frontends/si2168.c > b/drivers/media/dvb-frontends/si2168.c > index 680ba06..523acd1 100644 > --- a/drivers/media/dvb-frontends/si2168.c > +++ b/drivers/media/dvb-frontends/si2168.c > @@ -582,7 +582,7 @@ static int si2168_sleep(struct dvb_frontend *fe) > dev->active = false; > > /* Firmware B 4.0-11 or later loses warm state during sleep */ > - if (dev->version > ('B' << 24 | 4 << 16 | 0 << 8 | 11 << 0)) > + if (dev->version >= ('B' << 24 | 4 << 16 | 0 << 8 | 11 << 0)) > dev->warm = false; > > memcpy(cmd.args, "\x13", 1); > -- > 2.9.4 > Thanks, Mauro
On 12/14/2017 04:48 PM, Mauro Carvalho Chehab wrote: > Em Tue, 19 Sep 2017 13:13:52 +0100 > Nigel Kettlewell <nigel.kettlewell@googlemail.com> escreveu: > >> [re-sending as plain text] >> >> Fix for hanging si2168 in PCTV 292e USB, making the code match the comment. >> >> Using firmware v4.0.11 the 292e would work once and then hang on >> subsequent attempts to view DVB channels, until physically unplugged and >> plugged back in. >> >> With this patch, the warm state is reset for v4.0.11 and it appears to >> work both on the first attempt and on subsequent attempts. It is comment which is wrong. With firmware 4.0.11 it works well without need of download it every time. But firmware 4.0.19 needs to be downloaded every time after device is put to sleep. Probably your issue is coming from some other reason. >> >> (Patch basis Linux 4.11.9 f82a53b87594f460f2dd9983eeb851a5840e8df8) > > Patch is missing a Signed-off-by. See: > https://elinux.org/Developer_Certificate_Of_Origin). > > >> >> --- >> drivers/media/dvb-frontends/si2168.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/dvb-frontends/si2168.c >> b/drivers/media/dvb-frontends/si2168.c >> index 680ba06..523acd1 100644 >> --- a/drivers/media/dvb-frontends/si2168.c >> +++ b/drivers/media/dvb-frontends/si2168.c >> @@ -582,7 +582,7 @@ static int si2168_sleep(struct dvb_frontend *fe) >> dev->active = false; >> >> /* Firmware B 4.0-11 or later loses warm state during sleep */ >> - if (dev->version > ('B' << 24 | 4 << 16 | 0 << 8 | 11 << 0)) >> + if (dev->version >= ('B' << 24 | 4 << 16 | 0 << 8 | 11 << 0)) >> dev->warm = false; >> >> memcpy(cmd.args, "\x13", 1); >> -- >> 2.9.4 >> > > > > Thanks, > Mauro > regards Antti
diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index 680ba06..523acd1 100644 --- a/drivers/media/dvb-frontends/si2168.c +++ b/drivers/media/dvb-frontends/si2168.c @@ -582,7 +582,7 @@ static int si2168_sleep(struct dvb_frontend *fe) dev->active = false; /* Firmware B 4.0-11 or later loses warm state during sleep */ - if (dev->version > ('B' << 24 | 4 << 16 | 0 << 8 | 11 << 0)) + if (dev->version >= ('B' << 24 | 4 << 16 | 0 << 8 | 11 << 0)) dev->warm = false; memcpy(cmd.args, "\x13", 1);