Message ID | 15f3ba8371344a8dac830797216c06e9c5524a81.1493776983.git.mchehab@s-opensource.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1d5jmO-0002ly-BK; Wed, 03 May 2017 02:12:36 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-6) with esmtp id 1d5jmM-0003Gt-45; Wed, 03 May 2017 04:12:36 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754965AbdECCMc (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Tue, 2 May 2017 22:12:32 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:48393 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754931AbdECCM2 (ORCPT <rfc822; linux-media@vger.kernel.org>); Tue, 2 May 2017 22:12:28 -0400 Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id A1C89A05C9; Wed, 3 May 2017 02:12:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osg.samsung.com X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" Received: from osg.samsung.com ([127.0.0.1]) by localhost (s-opensource.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ojhtIstcue7K; Wed, 3 May 2017 02:12:54 +0000 (UTC) Received: from smtp.s-opensource.com (177.206.132.159.dynamic.adsl.gvt.net.br [177.206.132.159]) by osg.samsung.com (Postfix) with ESMTPSA id CD83DA05EB; Wed, 3 May 2017 02:12:53 +0000 (UTC) Received: from mchehab by smtp.s-opensource.com with local (Exim 4.87) (envelope-from <mchehab@smtp.s-opensource.com>) id 1d5jmC-0002ZQ-CM; Tue, 02 May 2017 23:12:24 -0300 From: Mauro Carvalho Chehab <mchehab@s-opensource.com> To: Linux Media Mailing List <linux-media@vger.kernel.org>, Linux Doc Mailing List <linux-doc@vger.kernel.org> Cc: Mauro Carvalho Chehab <mchehab@s-opensource.com>, Mauro Carvalho Chehab <mchehab@infradead.org> Subject: [PATCH v3 1/2] em28xx: Ignore errors while reading from eeprom Date: Tue, 2 May 2017 23:12:22 -0300 Message-Id: <15f3ba8371344a8dac830797216c06e9c5524a81.1493776983.git.mchehab@s-opensource.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <cover.1493776983.git.mchehab@s-opensource.com> References: <cover.1493776983.git.mchehab@s-opensource.com> In-Reply-To: <cover.1493776983.git.mchehab@s-opensource.com> References: <cover.1493776983.git.mchehab@s-opensource.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.5.3.20616 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, FROM_NAME_PHRASE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, REFERENCES 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __FROM_DOMAIN_IN_ANY_CC2 0, __FROM_DOMAIN_IN_RCPT 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MULTIPLE_RCPTS_CC_X2 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Mauro Carvalho Chehab
May 3, 2017, 2:12 a.m. UTC
While testing support for Terratec H6 rev. 2, it was noticed
that reading from eeprom there causes a timeout error.
Apparently, this is due to the need of properly setting GPIOs.
In any case, the driver doesn't really require eeprom reading
to succeed, as this is currently used only for debug.
So, Ignore such errors.
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
drivers/media/usb/em28xx/em28xx-i2c.c | 2 --
1 file changed, 2 deletions(-)
Comments
Am 03.05.2017 um 04:12 schrieb Mauro Carvalho Chehab: > While testing support for Terratec H6 rev. 2, it was noticed > that reading from eeprom there causes a timeout error. > > Apparently, this is due to the need of properly setting GPIOs. > > In any case, the driver doesn't really require eeprom reading > to succeed, as this is currently used only for debug. > > So, Ignore such errors. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> > --- > drivers/media/usb/em28xx/em28xx-i2c.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c > index 8c472d5adb50..60b195c157b8 100644 > --- a/drivers/media/usb/em28xx/em28xx-i2c.c > +++ b/drivers/media/usb/em28xx/em28xx-i2c.c > @@ -982,8 +982,6 @@ int em28xx_i2c_register(struct em28xx *dev, unsigned bus, > dev_err(&dev->intf->dev, > "%s: em28xx_i2_eeprom failed! retval [%d]\n", > __func__, retval); > - > - return retval; > } > } > Makes sense. Acked-by: Frank Schäfer <fschaefer.oss@googlemail.com>
diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c index 8c472d5adb50..60b195c157b8 100644 --- a/drivers/media/usb/em28xx/em28xx-i2c.c +++ b/drivers/media/usb/em28xx/em28xx-i2c.c @@ -982,8 +982,6 @@ int em28xx_i2c_register(struct em28xx *dev, unsigned bus, dev_err(&dev->intf->dev, "%s: em28xx_i2_eeprom failed! retval [%d]\n", __func__, retval); - - return retval; } }