diff mbox

[media] media: Kconfig: add dependency of HAS_DMA

Message ID 1451481963-18853-1-git-send-email-sudipm.mukherjee@gmail.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Sudip Mukherjee Dec. 30, 2015, 1:26 p.m. UTC 
  The build of m32r allmodconfig fails with the error:
drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
	error: implicit declaration of function 'dma_get_cache_alignment'

The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
videobuf2-dma-contig.c even though HAS_DMA is not defined.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/media/platform/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Sudip Mukherjee Jan. 11, 2016, 12:53 p.m. UTC | #1 
On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote:
> The build of m32r allmodconfig fails with the error:
> drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
> 	error: implicit declaration of function 'dma_get_cache_alignment'
> 
> The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
> correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
> selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
> videobuf2-dma-contig.c even though HAS_DMA is not defined.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---

A gentle ping. m32r allmodconfig still fails with next-20160111. Build
log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sakari Ailus Jan. 12, 2016, 2:10 p.m. UTC | #2 
On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote:
> On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote:
> > The build of m32r allmodconfig fails with the error:
> > drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
> > 	error: implicit declaration of function 'dma_get_cache_alignment'
> > 
> > The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
> > correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
> > selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
> > videobuf2-dma-contig.c even though HAS_DMA is not defined.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> 
> A gentle ping. m32r allmodconfig still fails with next-20160111. Build
> log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379

Hi Sudip,

Even though the issue now manifests itself on m32r, the problem is wider
than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is
set.

I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is
disabled, so perhaps it'd be possible to make it depend on HAS_DMA.

Cc others.
Sudip Mukherjee Jan. 12, 2016, 4:05 p.m. UTC | #3 
On Tue, Jan 12, 2016 at 04:10:43PM +0200, Sakari Ailus wrote:
> On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote:
> > On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote:
> > > The build of m32r allmodconfig fails with the error:
> > > drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
> > > 	error: implicit declaration of function 'dma_get_cache_alignment'
> > > 
> > > The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
> > > correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
> > > selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
> > > videobuf2-dma-contig.c even though HAS_DMA is not defined.
> > > 
> > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > > ---
> > 
> > A gentle ping. m32r allmodconfig still fails with next-20160111. Build
> > log is at:
> > https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379
> 
> Hi Sudip,
> 
> Even though the issue now manifests itself on m32r, the problem is wider
> than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is
> set.
> 
> I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is
> disabled, so perhaps it'd be possible to make it depend on HAS_DMA.

I have checked with all the Kconfig which selects VIDEOBUF2_DMA_CONTIG
and all of them does depend on HAS_DMA. This is the only place where it
was missing.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marek Szyprowski Jan. 13, 2016, 2:36 p.m. UTC | #4 
Hello,

On 2016-01-12 15:10, Sakari Ailus wrote:
> On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote:
>> On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote:
>>> The build of m32r allmodconfig fails with the error:
>>> drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
>>> 	error: implicit declaration of function 'dma_get_cache_alignment'
>>>
>>> The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
>>> correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
>>> selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
>>> videobuf2-dma-contig.c even though HAS_DMA is not defined.
>>>
>>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>>> ---
>> A gentle ping. m32r allmodconfig still fails with next-20160111. Build
>> log is at:
>> https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379
> Hi Sudip,
>
> Even though the issue now manifests itself on m32r, the problem is wider
> than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is
> set.
>
> I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is
> disabled, so perhaps it'd be possible to make it depend on HAS_DMA.

VIDEOBUF2_DMA_CONTIG already depends on HAS_DMA, but when driver use select
directive for enabling support for VIDEOBUF2_DMA_CONTIG, the dependencies
are not checked further. This is known limitation/feature of kconfig system.

Best regards
Sakari Ailus Jan. 14, 2016, 8:46 a.m. UTC | #5 
Hi Marek and Sudip,

On Wed, Jan 13, 2016 at 03:36:39PM +0100, Marek Szyprowski wrote:
> Hello,
> 
> On 2016-01-12 15:10, Sakari Ailus wrote:
> >On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote:
> >>On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote:
> >>>The build of m32r allmodconfig fails with the error:
> >>>drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
> >>>	error: implicit declaration of function 'dma_get_cache_alignment'
> >>>
> >>>The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
> >>>correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
> >>>selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
> >>>videobuf2-dma-contig.c even though HAS_DMA is not defined.
> >>>
> >>>Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> >>>---
> >>A gentle ping. m32r allmodconfig still fails with next-20160111. Build
> >>log is at:
> >>https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379
> >Hi Sudip,
> >
> >Even though the issue now manifests itself on m32r, the problem is wider
> >than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is
> >set.
> >
> >I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is
> >disabled, so perhaps it'd be possible to make it depend on HAS_DMA.
> 
> VIDEOBUF2_DMA_CONTIG already depends on HAS_DMA, but when driver use select
> directive for enabling support for VIDEOBUF2_DMA_CONTIG, the dependencies
> are not checked further. This is known limitation/feature of kconfig system.

Thanks for the insight. Sounds like this is the right thing to do then.

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Geert Uytterhoeven Jan. 23, 2016, 1:55 p.m. UTC | #6 
On Wed, Dec 30, 2015 at 2:26 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> The build of m32r allmodconfig fails with the error:
> drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
>         error: implicit declaration of function 'dma_get_cache_alignment'
>
> The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
> correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
> selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
> videobuf2-dma-contig.c even though HAS_DMA is not defined.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sudip Mukherjee Feb. 3, 2016, 8:01 a.m. UTC | #7 
Hi Mauro,
  
On Thu, Jan 14, 2016 at 10:46:59AM +0200, Sakari Ailus wrote:
> Hi Marek and Sudip,
> 
> On Wed, Jan 13, 2016 at 03:36:39PM +0100, Marek Szyprowski wrote:
> > Hello,
> > 
> > On 2016-01-12 15:10, Sakari Ailus wrote:
> > >On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote:
> > >>On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote:
> > >>>The build of m32r allmodconfig fails with the error:
> > >>>drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
> > >>>	error: implicit declaration of function 'dma_get_cache_alignment'
> > >>>
> > >>>The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
> > >>>correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
> > >>>selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
> > >>>videobuf2-dma-contig.c even though HAS_DMA is not defined.
> > >>>
> > >>>Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > >>>---
> > >>A gentle ping. m32r allmodconfig still fails with next-20160111. Build
> > >>log is at:
> > >>https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379
> > >Hi Sudip,
> > >
> > >Even though the issue now manifests itself on m32r, the problem is wider
> > >than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is
> > >set.
> > >
> > >I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is
> > >disabled, so perhaps it'd be possible to make it depend on HAS_DMA.
> > 
> > VIDEOBUF2_DMA_CONTIG already depends on HAS_DMA, but when driver use select
> > directive for enabling support for VIDEOBUF2_DMA_CONTIG, the dependencies
> > are not checked further. This is known limitation/feature of kconfig system.
> 
> Thanks for the insight. Sounds like this is the right thing to do then.
> 
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

I got an update from patchwork that it has been accepted, but I still do
not see it in linux-next or in rc2. m32r allmodconfig build still fails.
build log of next-20160203 is at
https://travis-ci.org/sudipm-mukherjee/parport/jobs/106657434

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sakari Ailus Feb. 3, 2016, 7:13 p.m. UTC | #8 
Hi Sudip,

On Wed, Feb 03, 2016 at 01:31:03PM +0530, Sudip Mukherjee wrote:
> Hi Mauro,
>   
> On Thu, Jan 14, 2016 at 10:46:59AM +0200, Sakari Ailus wrote:
> > Hi Marek and Sudip,
> > 
> > On Wed, Jan 13, 2016 at 03:36:39PM +0100, Marek Szyprowski wrote:
> > > Hello,
> > > 
> > > On 2016-01-12 15:10, Sakari Ailus wrote:
> > > >On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote:
> > > >>On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote:
> > > >>>The build of m32r allmodconfig fails with the error:
> > > >>>drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
> > > >>>	error: implicit declaration of function 'dma_get_cache_alignment'
> > > >>>
> > > >>>The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
> > > >>>correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
> > > >>>selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
> > > >>>videobuf2-dma-contig.c even though HAS_DMA is not defined.
> > > >>>
> > > >>>Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > > >>>---
> > > >>A gentle ping. m32r allmodconfig still fails with next-20160111. Build
> > > >>log is at:
> > > >>https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379
> > > >Hi Sudip,
> > > >
> > > >Even though the issue now manifests itself on m32r, the problem is wider
> > > >than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is
> > > >set.
> > > >
> > > >I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is
> > > >disabled, so perhaps it'd be possible to make it depend on HAS_DMA.
> > > 
> > > VIDEOBUF2_DMA_CONTIG already depends on HAS_DMA, but when driver use select
> > > directive for enabling support for VIDEOBUF2_DMA_CONTIG, the dependencies
> > > are not checked further. This is known limitation/feature of kconfig system.
> > 
> > Thanks for the insight. Sounds like this is the right thing to do then.
> > 
> > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> 
> I got an update from patchwork that it has been accepted, but I still do
> not see it in linux-next or in rc2. m32r allmodconfig build still fails.
> build log of next-20160203 is at
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/106657434

Your patch is in the fixes branch of media-tree. It'll end up to mainline
eventually (4.5 I presume).
diff mbox

Patch

diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 5263594..8b89ebe1 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -215,6 +215,7 @@  config VIDEO_SAMSUNG_EXYNOS_GSC
 config VIDEO_STI_BDISP
 	tristate "STMicroelectronics BDISP 2D blitter driver"
 	depends on VIDEO_DEV && VIDEO_V4L2
+	depends on HAS_DMA
 	depends on ARCH_STI || COMPILE_TEST
 	select VIDEOBUF2_DMA_CONTIG
 	select V4L2_MEM2MEM_DEV