[2/2] ARM: shmobile: lager dts: specify default-input for ADV7612
Commit Message
Set 'default-input' property for ADV7612. Enables image/video capture
without the need to have userspace specifying routing.
Signed-off-by: Ian Molton <ian.molton@codethink.co.uk>
Tested-by: William Towle <william.towle@codethink.co.uk>
---
arch/arm/boot/dts/r8a7790-lager.dts | 1 +
1 file changed, 1 insertion(+)
Comments
Hi William,
Thank you for the patch.
On Tuesday 28 July 2015 17:17:44 William Towle wrote:
> Set 'default-input' property for ADV7612. Enables image/video capture
> without the need to have userspace specifying routing.
>
> Signed-off-by: Ian Molton <ian.molton@codethink.co.uk>
> Tested-by: William Towle <william.towle@codethink.co.uk>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> b/arch/arm/boot/dts/r8a7790-lager.dts index aec7db6..e537052 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -552,6 +552,7 @@
> port {
> hdmi_in_ep: endpoint {
> remote-endpoint = <&vin0ep0>;
> + default-input = <0>;
The default property must be placed in the adv7612 node, not in the endpoint
node.
It looks like I've missed the patch that added the property to the DT
bindings. I would probably have complained about it, but now it's in :-/
Nevertheless, I think it would make sense for the driver to select the default
input automatically when only one input is connected. I'd prefer a driver
patch that implements that behaviour instead of adding the property to the
Lager DT.
> };
> };
> };
@@ -552,6 +552,7 @@
port {
hdmi_in_ep: endpoint {
remote-endpoint = <&vin0ep0>;
+ default-input = <0>;
};
};
};