Message ID | 1417825533-13081-1-git-send-email-benjamin@southpole.se (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1Xx3C5-0006lo-MQ; Sat, 06 Dec 2014 01:25:53 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1Xx3C3-0000dr-9I; Sat, 06 Dec 2014 01:25:53 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752261AbaLFAZo (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 5 Dec 2014 19:25:44 -0500 Received: from smtp.bredband2.com ([83.219.192.166]:38562 "EHLO smtp.bredband2.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752259AbaLFAZn (ORCPT <rfc822; linux-media@vger.kernel.org>); Fri, 5 Dec 2014 19:25:43 -0500 Received: from localhost.localdomain (92-244-23-216.customers.ownit.se [92.244.23.216]) (Authenticated sender: ed8153) by smtp.bredband2.com (Postfix) with ESMTPA id D68EA61BAE for <linux-media@vger.kernel.org>; Sat, 6 Dec 2014 01:25:33 +0100 (CET) From: Benjamin Larsson <benjamin@southpole.se> Cc: Linux Media Mailing List <linux-media@vger.kernel.org> Subject: [PATCH 1/3] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors Date: Sat, 6 Dec 2014 01:25:31 +0100 Message-Id: <1417825533-13081-1-git-send-email-benjamin@southpole.se> X-Mailer: git-send-email 2.1.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.12.6.1519 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, TO_UNDISCLOSED_RECIPIENTS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_3 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Benjamin Larsson
Dec. 6, 2014, 12:25 a.m. UTC
The Astrometa device has issues with i2c transfers. Lowering the
poll time somehow makes these errors disappear.
Signed-off-by: Benjamin Larsson <benjamin@southpole.se>
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Moikka! I am very surprised about that patch, especially because it *increases* polling interval from 400ms to 200ms. For me it has been always worked rather well, but now I suspect it could be due to I disable always remote controller... I have to test that. regards Antti On 12/06/2014 02:25 AM, Benjamin Larsson wrote: > The Astrometa device has issues with i2c transfers. Lowering the > poll time somehow makes these errors disappear. > > Signed-off-by: Benjamin Larsson <benjamin@southpole.se> > --- > drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > index 705c6c3..9ec4223 100644 > --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > @@ -1567,7 +1567,7 @@ static int rtl2832u_get_rc_config(struct dvb_usb_device *d, > rc->allowed_protos = RC_BIT_ALL; > rc->driver_type = RC_DRIVER_IR_RAW; > rc->query = rtl2832u_rc_query; > - rc->interval = 400; > + rc->interval = 200; > > return 0; > } >
On 12/06/2014 01:46 PM, Antti Palosaari wrote: > Moikka! > I am very surprised about that patch, especially because it > *increases* polling interval from 400ms to 200ms. For me it has been > always worked rather well, but now I suspect it could be due to I > disable always remote controller... I have to test that. > > regards > Antti I noticed that I got more retry errors when I removed the poll. So when I tried lowering the interval time the errors totally disappeared for me. Exactly how it works is unclear to me but I guess that the rc poll triggers something in the chip to mitigate some overflow in the i2c transmit buffer. This workaround also suggest that the i2c bus actually is ok and not the cause for the errors. Anyway please test and if this is an acceptable solution then there might also be some check that this poll is active and set to 200 at all times for this card. At least when the card is set in dvb mode, for sdr mode this might not be an issue. MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2014-12-06 01:25, Benjamin Larsson wrote: > The Astrometa device has issues with i2c transfers. Lowering the > poll time somehow makes these errors disappear. > > Signed-off-by: Benjamin Larsson <benjamin@southpole.se> > --- > drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > index 705c6c3..9ec4223 100644 > --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > @@ -1567,7 +1567,7 @@ static int rtl2832u_get_rc_config(struct dvb_usb_device *d, > rc->allowed_protos = RC_BIT_ALL; > rc->driver_type = RC_DRIVER_IR_RAW; > rc->query = rtl2832u_rc_query; > - rc->interval = 400; > + rc->interval = 200; > > return 0; > } > Ping, can I get an ack or nack on this ? MvH Benjamin Larsson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index 705c6c3..9ec4223 100644 --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c @@ -1567,7 +1567,7 @@ static int rtl2832u_get_rc_config(struct dvb_usb_device *d, rc->allowed_protos = RC_BIT_ALL; rc->driver_type = RC_DRIVER_IR_RAW; rc->query = rtl2832u_rc_query; - rc->interval = 400; + rc->interval = 200; return 0; }