Message ID | 20180808163351.28852-1-kieran.bingham@ideasonboard.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1fnRPM-0004Pu-Qq; Wed, 08 Aug 2018 16:34:01 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728471AbeHHSy0 (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 8 Aug 2018 14:54:26 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:33370 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727062AbeHHSyZ (ORCPT <rfc822; linux-media@vger.kernel.org>); Wed, 8 Aug 2018 14:54:25 -0400 Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 48539CE; Wed, 8 Aug 2018 18:33:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1533746035; bh=9s1IoCs3+0QeZiHLRD+5rkRxuAsjtjoIymI/CY/JVLM=; h=From:To:Cc:Subject:Date:From; b=II/lP8OKkXk55ZCup9tAogcPkbVdornzZy7vVAiMzMRYMakOKj/8JNuNhIMwfymLq 1f5aTNqJBgo98/Mm3rBa6+Vr5nM2Nl06YX5ESyapTx5XEchV84fx4ZX2s+bR6QDHXp xD7VL4TWZav1wm5/2kBDb0DKHPDLc4Fg9+7DdMVc= From: Kieran Bingham <kieran.bingham@ideasonboard.com> To: mchehab@kernel.org, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Hans Verkuil <hverkuil@xs4all.nl> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, linux-renesas-soc@vger.kernel.org, =?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?= <michal.vokac@ysoft.com>, Kieran Bingham <kieran.bingham@ideasonboard.com> Subject: [PATCH v2] dt-bindings: media: adv7604: Fix slave map documentation Date: Wed, 8 Aug 2018 17:33:51 +0100 Message-Id: <20180808163351.28852-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.17.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Kieran Bingham
Aug. 8, 2018, 4:33 p.m. UTC
The reg-names property in the documentation is missing an '='. Add it.
Fixes: 9feb786876c7 ("media: dt-bindings: media: adv7604: Extend
bindings to allow specifying slave map addresses")
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
v2:
- Commit title changed to prefix as "dt-bindings: media:"
If this is collected through a DT tree, I assume therefore this will be
fine, but if it is to go through the media-tree, please update as
necessaary to prevent the redundant dual "media:" tagging.
(I'll leave it to the maintainers to decide whose tree thise should go
through)
Thanks
Kieran
Documentation/devicetree/bindings/media/i2c/adv7604.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Kieran, Thank you for the patch. On Wednesday, 8 August 2018 19:33:51 EEST Kieran Bingham wrote: > The reg-names property in the documentation is missing an '='. Add it. > > Fixes: 9feb786876c7 ("media: dt-bindings: media: adv7604: Extend > bindings to allow specifying slave map addresses") > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > v2: > - Commit title changed to prefix as "dt-bindings: media:" > > If this is collected through a DT tree, I assume therefore this will be > fine, but if it is to go through the media-tree, please update as > necessaary to prevent the redundant dual "media:" tagging. I assume Hans will take the patch in his tree and submit a pull request. Mauro, this will then require special handling to avoid a rewrite of the subject. > (I'll leave it to the maintainers to decide whose tree thise should go > through) > > Thanks > > Kieran > > Documentation/devicetree/bindings/media/i2c/adv7604.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt > b/Documentation/devicetree/bindings/media/i2c/adv7604.txt index > dcf57e7c60eb..b3e688b77a38 100644 > --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt > +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt > @@ -66,7 +66,7 @@ Example: > * other maps will retain their default addresses. > */ > reg = <0x4c>, <0x66>; > - reg-names "main", "edid"; > + reg-names = "main", "edid"; > > reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>; > hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>;
On Wed, Aug 08, 2018 at 05:33:51PM +0100, Kieran Bingham wrote: > The reg-names property in the documentation is missing an '='. Add it. > > Fixes: 9feb786876c7 ("media: dt-bindings: media: adv7604: Extend > bindings to allow specifying slave map addresses") > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > --- > v2: > - Commit title changed to prefix as "dt-bindings: media:" > > If this is collected through a DT tree, I assume therefore this will be > fine, but if it is to go through the media-tree, please update as > necessaary to prevent the redundant dual "media:" tagging. > > (I'll leave it to the maintainers to decide whose tree thise should go > through) > > Thanks > > Kieran > > Documentation/devicetree/bindings/media/i2c/adv7604.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Rob Herring <robh@kernel.org> > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt b/Documentation/devicetree/bindings/media/i2c/adv7604.txt > index dcf57e7c60eb..b3e688b77a38 100644 > --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt > +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt > @@ -66,7 +66,7 @@ Example: > * other maps will retain their default addresses. > */ > reg = <0x4c>, <0x66>; > - reg-names "main", "edid"; > + reg-names = "main", "edid"; > > reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>; > hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>; > -- > 2.17.1 >
diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt b/Documentation/devicetree/bindings/media/i2c/adv7604.txt index dcf57e7c60eb..b3e688b77a38 100644 --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt @@ -66,7 +66,7 @@ Example: * other maps will retain their default addresses. */ reg = <0x4c>, <0x66>; - reg-names "main", "edid"; + reg-names = "main", "edid"; reset-gpios = <&ioexp 0 GPIO_ACTIVE_LOW>; hpd-gpios = <&ioexp 2 GPIO_ACTIVE_HIGH>;