[2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.
Commit Message
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
.../isp/kernels/eed1_8/ia_css_eed1_8.host.c | 24 +++++++++++-----------
1 file changed, 12 insertions(+), 12 deletions(-)
Comments
On Mon, Nov 27, 2017 at 11:30:53AM +0000, Jeremy Sowden wrote:
> Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
> ---
> .../isp/kernels/eed1_8/ia_css_eed1_8.host.c | 24 +++++++++++-----------
> 1 file changed, 12 insertions(+), 12 deletions(-)
I can never take patches without any changelog text, and so no one
should write them that way :)
Try it again?
thanks,
greg k-h
Fixed some sparse warnings in the Atom ISP staging driver and the checkpatch
warnings that affected my patches.
This time with longer commit messages. :)
Jeremy Sowden (3):
media: staging: atomisp: fix for sparse "using plain integer as NULL
pointer" warnings.
media: staging: atomisp: fixes for "symbol was not declared. Should it
be static?" sparse warnings.
media: staging: atomisp: fixed some checkpatch integer type warnings.
.../isp/kernels/eed1_8/ia_css_eed1_8.host.c | 25 +++++++++++-----------
.../isp_param/interface/ia_css_isp_param_types.h | 2 +-
2 files changed, 13 insertions(+), 14 deletions(-)
base-commit: 844056fd74ebdd826bd23a7d989597e15f478acb
Hi Greg,
On Mon, Nov 27, 2017 at 01:21:25PM +0100, Greg KH wrote:
> On Mon, Nov 27, 2017 at 11:30:53AM +0000, Jeremy Sowden wrote:
> > Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
> > ---
> > .../isp/kernels/eed1_8/ia_css_eed1_8.host.c | 24 +++++++++++-----------
> > 1 file changed, 12 insertions(+), 12 deletions(-)
>
> I can never take patches without any changelog text, and so no one
> should write them that way :)
I've been applying the atomisp patches to my tree for some time now,
further on passing them to Mauro to be merged via the media tree. To avoid
conflicts, I suggest to avoid merging them via the staging tree.
Thanks.
On Wed, Nov 29, 2017 at 11:08:17AM +0200, Sakari Ailus wrote:
> Hi Greg,
>
> On Mon, Nov 27, 2017 at 01:21:25PM +0100, Greg KH wrote:
> > On Mon, Nov 27, 2017 at 11:30:53AM +0000, Jeremy Sowden wrote:
> > > Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
> > > ---
> > > .../isp/kernels/eed1_8/ia_css_eed1_8.host.c | 24 +++++++++++-----------
> > > 1 file changed, 12 insertions(+), 12 deletions(-)
> >
> > I can never take patches without any changelog text, and so no one
> > should write them that way :)
>
> I've been applying the atomisp patches to my tree for some time now,
> further on passing them to Mauro to be merged via the media tree. To avoid
> conflicts, I suggest to avoid merging them via the staging tree.
I'm not touching any of these patches, just commenting that patches
without changelogs should not be written :)
thanks,
greg k-h
On Wed, Nov 29, 2017 at 10:15:06AM +0100, Greg KH wrote:
> On Wed, Nov 29, 2017 at 11:08:17AM +0200, Sakari Ailus wrote:
> > Hi Greg,
> >
> > On Mon, Nov 27, 2017 at 01:21:25PM +0100, Greg KH wrote:
> > > On Mon, Nov 27, 2017 at 11:30:53AM +0000, Jeremy Sowden wrote:
> > > > Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
> > > > ---
> > > > .../isp/kernels/eed1_8/ia_css_eed1_8.host.c | 24 +++++++++++-----------
> > > > 1 file changed, 12 insertions(+), 12 deletions(-)
> > >
> > > I can never take patches without any changelog text, and so no one
> > > should write them that way :)
> >
> > I've been applying the atomisp patches to my tree for some time now,
> > further on passing them to Mauro to be merged via the media tree. To avoid
> > conflicts, I suggest to avoid merging them via the staging tree.
>
> I'm not touching any of these patches, just commenting that patches
> without changelogs should not be written :)
Ack, just wanted to avoid potential mege conflicts. Thanks.
@@ -32,44 +32,44 @@
#define NUMBER_OF_TCINV_POINTS 9
#define NUMBER_OF_FCINV_POINTS 9
-const int16_t chgrinv_x[NUMBER_OF_CHGRINV_POINTS] = {
+static const int16_t chgrinv_x[NUMBER_OF_CHGRINV_POINTS] = {
0, 16, 64, 144, 272, 448, 672, 976,
1376, 1888, 2528, 3312, 4256, 5376, 6688};
-const int16_t chgrinv_a[NUMBER_OF_CHGRINV_POINTS] = {
+static const int16_t chgrinv_a[NUMBER_OF_CHGRINV_POINTS] = {
-7171, -256, -29, -3456, -1071, -475, -189, -102,
-48, -38, -10, -9, -7, -6, 0};
-const int16_t chgrinv_b[NUMBER_OF_CHGRINV_POINTS] = {
+static const int16_t chgrinv_b[NUMBER_OF_CHGRINV_POINTS] = {
8191, 1021, 256, 114, 60, 37, 24, 17,
12, 9, 6, 5, 4, 3, 2};
-const int16_t chgrinv_c[NUMBER_OF_CHGRINV_POINTS] = {
+static const int16_t chgrinv_c[NUMBER_OF_CHGRINV_POINTS] = {
1, 1, 1, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0};
-const int16_t tcinv_x[NUMBER_OF_TCINV_POINTS] = {
+static const int16_t tcinv_x[NUMBER_OF_TCINV_POINTS] = {
0, 4, 11, 23, 42, 68, 102, 148, 205};
-const int16_t tcinv_a[NUMBER_OF_TCINV_POINTS] = {
+static const int16_t tcinv_a[NUMBER_OF_TCINV_POINTS] = {
-6364, -631, -126, -34, -13, -6, -4452, -2156, 0};
-const int16_t tcinv_b[NUMBER_OF_TCINV_POINTS] = {
+static const int16_t tcinv_b[NUMBER_OF_TCINV_POINTS] = {
8191, 1828, 726, 352, 197, 121, 80, 55, 40};
-const int16_t tcinv_c[NUMBER_OF_TCINV_POINTS] = {
+static const int16_t tcinv_c[NUMBER_OF_TCINV_POINTS] = {
1, 1, 1, 1, 1, 1, 0, 0, 0};
-const int16_t fcinv_x[NUMBER_OF_FCINV_POINTS] = {
+static const int16_t fcinv_x[NUMBER_OF_FCINV_POINTS] = {
0, 80, 216, 456, 824, 1344, 2040, 2952, 4096};
-const int16_t fcinv_a[NUMBER_OF_FCINV_POINTS] = {
+static const int16_t fcinv_a[NUMBER_OF_FCINV_POINTS] = {
-5244, -486, -86, -2849, -961, -400, -180, -86, 0};
-const int16_t fcinv_b[NUMBER_OF_FCINV_POINTS] = {
+static const int16_t fcinv_b[NUMBER_OF_FCINV_POINTS] = {
8191, 1637, 607, 287, 159, 98, 64, 44, 32};
-const int16_t fcinv_c[NUMBER_OF_FCINV_POINTS] = {
+static const int16_t fcinv_c[NUMBER_OF_FCINV_POINTS] = {
1, 1, 1, 0, 0, 0, 0, 0, 0};