Message ID | 20170908163929.9277-1-sthemmin@microsoft.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Sean Young |
Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1dqMK1-0001Wf-As; Fri, 08 Sep 2017 16:40:01 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755884AbdIHQjr (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 8 Sep 2017 12:39:47 -0400 Received: from mail-pg0-f49.google.com ([74.125.83.49]:34450 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755106AbdIHQjp (ORCPT <rfc822; linux-media@vger.kernel.org>); Fri, 8 Sep 2017 12:39:45 -0400 Received: by mail-pg0-f49.google.com with SMTP id q68so5693200pgq.1 for <linux-media@vger.kernel.org>; Fri, 08 Sep 2017 09:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=Ww2SnHJNdfVG+KaO2ZYOYznMZEBKhe2Ge/+kCtVA2hQ=; b=x00BG/PgV963aE0W7fql4TufjbudyEaIVoZIZ5eyj1KAgLGjcylH7ddBi+HvwenbXa aMUc55fgZnevqLG2vzTTiCD6RvkISvkFan0XkPSe2vVXFAx1F1zF+eBxoc6BgWO7NZB2 XuGf/9PS5qXQ7nnMz1mhkU6aOxeQiVC6edTMTkv/vNeX8etE3/oWs/nRz+LDZZWqHaC3 2+rJVKZzyNF5xB+acpRJR/VqWh3JF8mnaeg5P9JjRVmOG6x9EeJRQbArSKhP6OryPsrX B96fKqKUHOf50YW6g9umgDzkfu+IKyAOOBgPDj4sPkiKr4uA/lzNui1+87qV1gcbHMez dthg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ww2SnHJNdfVG+KaO2ZYOYznMZEBKhe2Ge/+kCtVA2hQ=; b=q1wj0NO+6eIZszWqZ4e1YYTQMALwWtgvsWHcJisieEgAdtFDyo4IciGhefxUxvtW0S uU3PYbrJn4XwQTfrCQahTC0dePSGISRBT/HXnD/vGYv1U1yAhStqcG1qXp6lune5WzhU wy9wi5SCn9cLVSS+apx8GJ+X6qOTxfjMRDhDLPC5HcCbBv+32oksCFnCSCAl8j8eIlIU vcyEFa5hO1eXJEXkTeLaJv/b5zcGuYBPqYzlttKcY1YYUlzIhUATreRLxyW4b/aH/SfM 5BNDrYrCh07m0aZ/qlQc8nzDZk40n9nBuHye4U/o126xLwkau4GwySmX4akeS7lQNEOT mMrg== X-Gm-Message-State: AHPjjUhxofbxhJkXXLh/bUGnYXynlZYGFzl2ClSUMO7mM1ZDmM/spZx6 /WgNK0tluMy//90i X-Google-Smtp-Source: ADKCNb4gzTgR2sVcKvc0I55CEBGoqXLELKAvC+1yF5cWnVigB8NeQ1R/KFqfrlOdUox1Dz/XMeKodg== X-Received: by 10.98.79.157 with SMTP id f29mr3759839pfj.9.1504888785172; Fri, 08 Sep 2017 09:39:45 -0700 (PDT) Received: from xeon-e3.lan (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id b87sm4796002pfl.14.2017.09.08.09.39.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Sep 2017 09:39:44 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> X-Google-Original-From: Stephen Hemminger <sthemmin@microsoft.com> To: mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Hemminger <sthemmin@microsoft.com> Subject: [PATCH] media: default for RC_CORE should be n Date: Fri, 8 Sep 2017 09:39:29 -0700 Message-Id: <20170908163929.9277-1-sthemmin@microsoft.com> X-Mailer: git-send-email 2.11.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Stephen Hemminger
Sept. 8, 2017, 4:39 p.m. UTC
The Linus policy on Kconfig is that the default should be no
for all new devices. I.e the user rebuild a new kernel from an
old config should not by default get a larger kernel.
Fixes: b4c184e506a4 ("[media] media: reorganize the main Kconfig items")
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
drivers/media/rc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Sep 08, 2017 at 09:39:29AM -0700, Stephen Hemminger wrote: > The Linus policy on Kconfig is that the default should be no > for all new devices. I.e the user rebuild a new kernel from an > old config should not by default get a larger kernel. That might make sense for new config, but RC_CORE has been present for 7 years; I don't see how changing defaults for existing config makes sense. Sean > > Fixes: b4c184e506a4 ("[media] media: reorganize the main Kconfig items") > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> > --- > drivers/media/rc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig > index d9ce8ff55d0c..5aa384afcfef 100644 > --- a/drivers/media/rc/Kconfig > +++ b/drivers/media/rc/Kconfig > @@ -2,7 +2,7 @@ > menuconfig RC_CORE > tristate "Remote Controller support" > depends on INPUT > - default y > + default n > ---help--- > Enable support for Remote Controllers on Linux. This is > needed in order to support several video capture adapters, > -- > 2.11.0
On Fri, 8 Sep 2017 19:52:47 +0100 Sean Young <sean@mess.org> wrote: > On Fri, Sep 08, 2017 at 09:39:29AM -0700, Stephen Hemminger wrote: > > The Linus policy on Kconfig is that the default should be no > > for all new devices. I.e the user rebuild a new kernel from an > > old config should not by default get a larger kernel. > > That might make sense for new config, but RC_CORE has been present for > 7 years; I don't see how changing defaults for existing config makes > sense. > I took existing config for 4.13 and did 'make oldconfig' and just hitting return caused it to turned on. The problem is that in my config media is disabled, and now your new reconfiguration makes RC_CORE not dependent on media. It is a common problem, developers never test with their subsystem disabled.
Em Fri, 8 Sep 2017 12:06:48 -0700 Stephen Hemminger <stephen@networkplumber.org> escreveu: > On Fri, 8 Sep 2017 19:52:47 +0100 > Sean Young <sean@mess.org> wrote: > > > On Fri, Sep 08, 2017 at 09:39:29AM -0700, Stephen Hemminger wrote: > > > The Linus policy on Kconfig is that the default should be no > > > for all new devices. I.e the user rebuild a new kernel from an > > > old config should not by default get a larger kernel. > > > > That might make sense for new config, but RC_CORE has been present for > > 7 years; I don't see how changing defaults for existing config makes > > sense. > > > > I took existing config for 4.13 and did 'make oldconfig' and just > hitting return caused it to turned on. > > The problem is that in my config media is disabled, and now your new > reconfiguration makes RC_CORE not dependent on media. > > It is a common problem, developers never test with their subsystem disabled. Hi Sean, Yes, it makes sense to default 'n' for RC_CORE now that this is an independent menu option and it builds the RC core when enabled. Regards, Mauro
On Fri, Sep 8, 2017 at 6:39 PM, Stephen Hemminger <stephen@networkplumber.org> wrote: > The Linus policy on Kconfig is that the default should be no > for all new devices. I.e the user rebuild a new kernel from an > old config should not by default get a larger kernel. > > Fixes: b4c184e506a4 ("[media] media: reorganize the main Kconfig items") > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> > --- > drivers/media/rc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig > index d9ce8ff55d0c..5aa384afcfef 100644 > --- a/drivers/media/rc/Kconfig > +++ b/drivers/media/rc/Kconfig > @@ -2,7 +2,7 @@ > menuconfig RC_CORE > tristate "Remote Controller support" > depends on INPUT > - default y > + default n "default n" is the default, so you can just drop this line. For the principle: Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig index d9ce8ff55d0c..5aa384afcfef 100644 --- a/drivers/media/rc/Kconfig +++ b/drivers/media/rc/Kconfig @@ -2,7 +2,7 @@ menuconfig RC_CORE tristate "Remote Controller support" depends on INPUT - default y + default n ---help--- Enable support for Remote Controllers on Linux. This is needed in order to support several video capture adapters,