| Message ID | 20170615222302.GB20714@amd (mailing list archive) |
|---|---|
| State | Obsoleted, archived |
| Delegated to: | Laurent Pinchart |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1dLdAd-0005h6-Ec; Thu, 15 Jun 2017 22:23:19 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.89/mailfrontend-7) with esmtp id 1dLdAb-000415-2O; Fri, 16 Jun 2017 00:23:19 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752147AbdFOWXF (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 15 Jun 2017 18:23:05 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:46881 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbdFOWXE (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 15 Jun 2017 18:23:04 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id E70AD8254E; Fri, 16 Jun 2017 00:23:02 +0200 (CEST) Date: Fri, 16 Jun 2017 00:23:02 +0200 From: Pavel Machek <pavel@ucw.cz> To: Sakari Ailus <sakari.ailus@iki.fi> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, mchehab@kernel.org, kernel list <linux-kernel@vger.kernel.org>, ivo.g.dimitrov.75@gmail.com, sre@kernel.org, pali.rohar@gmail.com, linux-media@vger.kernel.org Subject: [PATCH] omap3isp: fix compilation Message-ID: <20170615222302.GB20714@amd> References: <20170302101603.GE27818@amd> <20170302112401.GF3220@valkosipuli.retiisi.org.uk> <20170302123848.GA28230@amd> <20170304130318.GU3220@valkosipuli.retiisi.org.uk> <20170306072323.GA23509@amd> <20170310225418.GJ3220@valkosipuli.retiisi.org.uk> <20170613122240.GA2803@amd> <20170613124748.GD12407@valkosipuli.retiisi.org.uk> <20170613210900.GA31456@amd> <20170614110634.GP12407@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MfFXiAuoTsnnDAfZ" Content-Disposition: inline In-Reply-To: <20170614110634.GP12407@valkosipuli.retiisi.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.6.15.221517 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' BODY_PARA_IS_SENTENCE_URL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, KNOWN_FREEWEB_URI 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, INVALID_MSGID_NO_FQDN 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, URI_WITH_PATH_ONLY 0, __ANY_URI 0, __ATTACHMENT_SIZE_0_10K 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __CD 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __FROM_DOMAIN_IN_ANY_CC1 0, __FROM_DOMAIN_IN_RCPT 0, __HAS_ATTACHMENT 0, __HAS_ATTACHMENT1 0, __HAS_ATTACHMENT2 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __KNOWN_FREEWEB_URI2 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_TEXT_P2 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_URI_TEXT 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_IN_BODY 0, __URI_NOT_IMG 0, __URI_NS , __URI_WITH_PATH 0, __USER_AGENT 0' |
Commit Message
Pavel Machek
June 15, 2017, 10:23 p.m. UTC
Fix compilation of isp.c
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Comments
On 06/16/2017 12:23 AM, Pavel Machek wrote: > > Fix compilation of isp.c > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index 4ca3fc9..b80debf 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -2026,7 +2026,7 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwnode, > > isd->bus = buscfg; > > - ret = v4l2_fwnode_endpoint_parse(fwn, vep); > + ret = v4l2_fwnode_endpoint_parse(fwnode, &vep); > if (ret) > return ret; > > You're using something old since the media tree master already uses &vep. Regards, Hans
On Fri, Jun 16, 2017 at 10:03:41AM +0200, Hans Verkuil wrote: > On 06/16/2017 12:23 AM, Pavel Machek wrote: > > > >Fix compilation of isp.c > >Signed-off-by: Pavel Machek <pavel@ucw.cz> > > > >diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > >index 4ca3fc9..b80debf 100644 > >--- a/drivers/media/platform/omap3isp/isp.c > >+++ b/drivers/media/platform/omap3isp/isp.c > >@@ -2026,7 +2026,7 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwnode, > > isd->bus = buscfg; > >- ret = v4l2_fwnode_endpoint_parse(fwn, vep); > >+ ret = v4l2_fwnode_endpoint_parse(fwnode, &vep); > > if (ret) > > return ret; > > > > You're using something old since the media tree master already uses &vep. Well, yes and no. Pavel is using my ccp2 support branch I recently rebased. :-)
diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 4ca3fc9..b80debf 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -2026,7 +2026,7 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwnode, isd->bus = buscfg; - ret = v4l2_fwnode_endpoint_parse(fwn, vep); + ret = v4l2_fwnode_endpoint_parse(fwnode, &vep); if (ret) return ret;