[v3,3/3] ARM: multi_v7_defconfig: enable STMicroelectronics HVA debugfs

Message ID 1480329054-30403-4-git-send-email-jean-christophe.trotin@st.com (mailing list archive)
State Rejected, archived
Delegated to: Hans Verkuil
Headers

Commit Message

Jean-Christophe Trotin Nov. 28, 2016, 10:30 a.m. UTC
  Signed-off-by: Jean-Christophe Trotin <jean-christophe.trotin@st.com>
---
 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Hans Verkuil Dec. 5, 2016, 12:32 p.m. UTC | #1
Please provide a commit message, it shouldn't be empty.

But are you sure you want to enable it in the defconfig? I think in general
DEBUGFS config options aren't enabled by default.

Regards,

	Hans

On 11/28/2016 11:30 AM, Jean-Christophe Trotin wrote:
> Signed-off-by: Jean-Christophe Trotin <jean-christophe.trotin@st.com>
> ---
>  arch/arm/configs/multi_v7_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index eb14ab6..7a15107 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -563,6 +563,7 @@ CONFIG_VIDEO_SAMSUNG_S5P_JPEG=m
>  CONFIG_VIDEO_SAMSUNG_S5P_MFC=m
>  CONFIG_VIDEO_STI_BDISP=m
>  CONFIG_VIDEO_STI_HVA=m
> +CONFIG_VIDEO_STI_HVA_DEBUGFS=y
>  CONFIG_DYNAMIC_DEBUG=y
>  CONFIG_VIDEO_RENESAS_JPU=m
>  CONFIG_VIDEO_RENESAS_VSP1=m
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  
Jean-Christophe Trotin Dec. 8, 2016, 10:30 a.m. UTC | #2
Hi Hans,

You're right: the HVA DEBUGFS config option shouldn't be enabled by default.
So, "[PATCH v3 3/3] ARM: multi_v7_defconfig: enable STMicroelectronics HVA 
debugfs" must be ignored. It will be taken into account in our configuration 
fragment.
Do you have any other remark about the patches [PATCH v3 1/3] and [PATCH v3 2/3]?
If you need a new version (v4) without the "[PATCH v3 3/3]", please let me know?

Regards,

Jean-Christophe.


On 12/05/2016 01:32 PM, Hans Verkuil wrote:
> Please provide a commit message, it shouldn't be empty.
>
> But are you sure you want to enable it in the defconfig? I think in general
> DEBUGFS config options aren't enabled by default.
>
> Regards,
>
> 	Hans
>
> On 11/28/2016 11:30 AM, Jean-Christophe Trotin wrote:
>> Signed-off-by: Jean-Christophe Trotin <jean-christophe.trotin@st.com>
>> ---
>>  arch/arm/configs/multi_v7_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
>> index eb14ab6..7a15107 100644
>> --- a/arch/arm/configs/multi_v7_defconfig
>> +++ b/arch/arm/configs/multi_v7_defconfig
>> @@ -563,6 +563,7 @@ CONFIG_VIDEO_SAMSUNG_S5P_JPEG=m
>>  CONFIG_VIDEO_SAMSUNG_S5P_MFC=m
>>  CONFIG_VIDEO_STI_BDISP=m
>>  CONFIG_VIDEO_STI_HVA=m
>> +CONFIG_VIDEO_STI_HVA_DEBUGFS=y
>>  CONFIG_DYNAMIC_DEBUG=y
>>  CONFIG_VIDEO_RENESAS_JPU=m
>>  CONFIG_VIDEO_RENESAS_VSP1=m
>>
>--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Patch

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index eb14ab6..7a15107 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -563,6 +563,7 @@  CONFIG_VIDEO_SAMSUNG_S5P_JPEG=m
 CONFIG_VIDEO_SAMSUNG_S5P_MFC=m
 CONFIG_VIDEO_STI_BDISP=m
 CONFIG_VIDEO_STI_HVA=m
+CONFIG_VIDEO_STI_HVA_DEBUGFS=y
 CONFIG_DYNAMIC_DEBUG=y
 CONFIG_VIDEO_RENESAS_JPU=m
 CONFIG_VIDEO_RENESAS_VSP1=m