Message ID | 1474470578-2870-1-git-send-email-weiyj.lk@gmail.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1bmj9j-0001KR-93; Wed, 21 Sep 2016 15:09:51 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-6) with esmtp id 1bmj9h-0003yN-3I; Wed, 21 Sep 2016 17:09:50 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757254AbcIUPJq (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 21 Sep 2016 11:09:46 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35276 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755814AbcIUPJp (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 21 Sep 2016 11:09:45 -0400 Received: by mail-pf0-f196.google.com with SMTP id 6so2505874pfl.2 for <linux-media@vger.kernel.org>; Wed, 21 Sep 2016 08:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pwdLmyiMtXVwn4ujN8mvIFgIK/X56xmoWMhCvyBoQEk=; b=DlSm0GrodfKz+Njoc5cQcqkzT8O4iCK+bGXm/agJm7YNIPPRqryzrgBF4vQk0a92eu QcXBoTYQKRBYUSaJ+LZ9SoO9ftLp0oZwkw9yYOugEexcHrIA6V3wuQnJTfJGdzgKZb7d MRtYwCOyUEjYEy1pXi8E9pX2PUKFDs4a7e1FJG8zvlrNtYqn7TejnFh0vj1a/fhE2pLH nt+Ycg0Ea39dgpbu7whVrBJ8TK6kodHAmRDP9vVX0K2nkX2tjhlWXrZlmpi8lI5IXvci AcFz4T3KotgyPZ/6gmGUa1Zj4errfcMpf014qaI24/xd5i6T4FBg+ZvTjm6pMVMxZ3G3 9T7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pwdLmyiMtXVwn4ujN8mvIFgIK/X56xmoWMhCvyBoQEk=; b=CpQwAHucRyckKTYc5NLEiRZua3NaZO4RjWxFP7AmqupTMXor0uosAuKRSu1W78K215 1zev+Z6rdwXufpEfa0aRhyLUwhbitVVCnZcB6jXfElGyknuEkProuPWzMFDu7veKe0F3 1vZmsAVTuZw9B+xoBDLjDjPPwCNlgDOxf6dMx/3zMO0/4qBXR9TAJtVMi56UfyJWJUc4 OK2eLLN2UTh00yPeR1j4CY/FIuyPQk2lhcDnjCwLNAcJoxDXSPjsRpYffaKvslTikXzM hQlQqTCbMGB/yVPRe2B7K3m8dpTnmpceXV8vYN0O2hX9Mp8zEv79w3UusC4omgCOzDPf nzSQ== X-Gm-Message-State: AE9vXwN2ZiB3fH9qr/nS+e+4/86cFlsO8ZTnmcBVL1S3CkGLIE0JXPTN3WsucYC1VEGOqw== X-Received: by 10.98.200.4 with SMTP id z4mr54188456pff.95.1474470585309; Wed, 21 Sep 2016 08:09:45 -0700 (PDT) Received: from 192.168.0.37 (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id 184sm87495222pfg.20.2016.09.21.08.09.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Sep 2016 08:09:44 -0700 (PDT) From: Wei Yongjun <weiyj.lk@gmail.com> To: Fabien Dessenne <fabien.dessenne@st.com>, Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Wei Yongjun <weiyongjun1@huawei.com>, linux-media@vger.kernel.org Subject: [PATCH -next] [media] bdisp: fix error return code in bdisp_probe() Date: Wed, 21 Sep 2016 15:09:38 +0000 Message-Id: <1474470578-2870-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.9.21.150619 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, DKIM_SIGNATURE 0, NO_URI_HTTPS 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __YOUTUBE_RCVD 0' |
Commit Message
Wei Yongjun
Sept. 21, 2016, 3:09 p.m. UTC
From: Wei Yongjun <weiyongjun1@huawei.com> Fix to return error code -EINVAL from the platform_get_resource() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
Hi Wei, Thank you for the patch. On 09/21/2016 05:09 PM, Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > Fix to return error code -EINVAL from the platform_get_resource() error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Reviewed-by: Fabien Dessenne <fabien.dessenne@st.com> > --- > drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > index 45f82b5..8236081 100644 > --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > @@ -1337,6 +1337,7 @@ static int bdisp_probe(struct platform_device *pdev) > res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > if (!res) { > dev_err(dev, "failed to get IRQ resource\n"); > + ret = -EINVAL; > goto err_clk; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c index 45f82b5..8236081 100644 --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c @@ -1337,6 +1337,7 @@ static int bdisp_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); if (!res) { dev_err(dev, "failed to get IRQ resource\n"); + ret = -EINVAL; goto err_clk; }