| Message ID | 1465659593-16858-3-git-send-email-ivo.g.dimitrov.75@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1bBl1Z-0000hK-7C; Sat, 11 Jun 2016 15:40:37 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-5) with esmtp id 1bBl1W-0002K2-6l; Sat, 11 Jun 2016 17:40:36 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752602AbcFKPkO (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Sat, 11 Jun 2016 11:40:14 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34997 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752556AbcFKPkK (ORCPT <rfc822;linux-media@vger.kernel.org>); Sat, 11 Jun 2016 11:40:10 -0400 Received: by mail-wm0-f67.google.com with SMTP id k184so5022544wme.2; Sat, 11 Jun 2016 08:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ptWma5/bcPYw8ECJGRb6OiKbXKyBWti5meXXnVN981k=; b=mPQDVS+onF/7P9hmHmy9YEyoXr2fgRKupvSPWfKowfL6RyfOxUMMuCsOPGOrBZolSl 3k0B7RsDONae2CrUIeV8QbfD5A1UrBykxl6YbzAgeGBy/wwXOD7kY0PEO8pP4sjJS8ED 9iZAH3+2L3DHaMo1EWXSUO2LE80RHv+MDF9SUm/iGFx3yauREjSB+hE/3e0cIrcy9YF6 kLNHLEIEtDn1fZ6nK0pdsNCdnCxmkYxF/Fy6DzDx9rZi92EYhQkLIWCmluggqAMeoX3b z8g9xR+0o4jdBUwlR5jT/qv6sDmAqmOeqXbK2EvegbEz3R5rv7NIQlcP64QGGSr/Sl55 NFWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ptWma5/bcPYw8ECJGRb6OiKbXKyBWti5meXXnVN981k=; b=Y9FIez6z/vEt50FA77zIy7k+HduA1qyQjOwXy5EoNO7AAWE2scegh76eJoae69ELbs vm2BYqG3mhzqWTar1YvLqykB6kyxesjphjmWrndvd/ADyVGNJ96Pg1aScWwn3CXpHrw8 C9CY2sp8nKBRNBTWlNv8rmJ07eTzRqExVUuVkoJVCXTD0wBb1JQqncFyQg+OFB3ibIB4 cDF16uOulQ8LTd//luWV0CtCB6LcjfHyTfjtvCglhbdn0IOQ+5/mP0lhEmDuOrx7BmTA mTQ543NuQvyH9ZJ8wLHOT2FCffag2MHlnfNjyWBRnQuFPI5gqsN/gU5jx9bz6aSh2O45 IZWg== X-Gm-Message-State: ALyK8tITAk1i0lXQMUIP9ROnoEu7b26voWOKZTXAgCeknEU1MD/1jUgkpPwq7acD1WidUw== X-Received: by 10.194.8.3 with SMTP id n3mr6884172wja.120.1465659604138; Sat, 11 Jun 2016 08:40:04 -0700 (PDT) Received: from localhost.localdomain ([46.249.74.23]) by smtp.gmail.com with ESMTPSA id xs9sm15019163wjc.11.2016.06.11.08.40.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 11 Jun 2016 08:40:03 -0700 (PDT) From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> To: sakari.ailus@iki.fi Cc: sre@kernel.org, pali.rohar@gmail.com, pavel@ucw.cz, linux-media@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, mchehab@osg.samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Subject: [PATCH v3 2/2] media: et8ek8: Add documentation Date: Sat, 11 Jun 2016 18:39:53 +0300 Message-Id: <1465659593-16858-3-git-send-email-ivo.g.dimitrov.75@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465659593-16858-1-git-send-email-ivo.g.dimitrov.75@gmail.com> References: <1465659593-16858-1-git-send-email-ivo.g.dimitrov.75@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.6.11.153018 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1900_1999 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_NEGATE 0, MSG_THREAD 0, MULTIPLE_RCPTS_RND 0, NO_URI_HTTPS 0, REFERENCES 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __DATE_TZ_RU 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __REFERENCES 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __YOUTUBE_RCVD 0' |
Commit Message
Ivaylo Dimitrov
June 11, 2016, 3:39 p.m. UTC
Add DT bindings description
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
.../bindings/media/i2c/toshiba,et8ek8.txt | 50 ++++++++++++++++++++++
1 file changed, 50 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
Comments
On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: > Add DT bindings description Not exactly the best commit msg. > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > --- > .../bindings/media/i2c/toshiba,et8ek8.txt | 50 ++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > new file mode 100644 > index 0000000..997d268 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > @@ -0,0 +1,50 @@ > +Toshiba et8ek8 5MP sensor > + > +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device > + > +More detailed documentation can be found in > +Documentation/devicetree/bindings/media/video-interfaces.txt . > + > + > +Mandatory properties > +-------------------- > + > +- compatible: "toshiba,et8ek8" > +- reg: I2C address (0x3e, or an alternative address) > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts > +- clocks: External clock to the sensor > +- clock-frequency: Frequency of the external clock to the sensor These should be mutually-exclusive. If you have a clock, then you can get the frequency at runtime. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote: > On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: > > Add DT bindings description > > Not exactly the best commit msg. > > > > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> > > --- > > .../bindings/media/i2c/toshiba,et8ek8.txt | 50 ++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > > new file mode 100644 > > index 0000000..997d268 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > > @@ -0,0 +1,50 @@ > > +Toshiba et8ek8 5MP sensor > > + > > +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device > > + > > +More detailed documentation can be found in > > +Documentation/devicetree/bindings/media/video-interfaces.txt . > > + > > + > > +Mandatory properties > > +-------------------- > > + > > +- compatible: "toshiba,et8ek8" > > +- reg: I2C address (0x3e, or an alternative address) > > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts > > > +- clocks: External clock to the sensor > > +- clock-frequency: Frequency of the external clock to the sensor > > These should be mutually-exclusive. If you have a clock, then you can > get the frequency at runtime. Yes, you can. But the intention is to set the frequency: the sensor requires a particular, pre-determined frequency. Typically this is specific to the board.
On Tue, Jun 14, 2016 at 11:31 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote: > Hi Rob, > > On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote: >> On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: >> > Add DT bindings description >> >> Not exactly the best commit msg. >> >> > >> > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> >> > --- >> > .../bindings/media/i2c/toshiba,et8ek8.txt | 50 ++++++++++++++++++++++ >> > 1 file changed, 50 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >> > >> > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >> > new file mode 100644 >> > index 0000000..997d268 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >> > @@ -0,0 +1,50 @@ >> > +Toshiba et8ek8 5MP sensor >> > + >> > +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device >> > + >> > +More detailed documentation can be found in >> > +Documentation/devicetree/bindings/media/video-interfaces.txt . >> > + >> > + >> > +Mandatory properties >> > +-------------------- >> > + >> > +- compatible: "toshiba,et8ek8" >> > +- reg: I2C address (0x3e, or an alternative address) >> > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts >> >> > +- clocks: External clock to the sensor >> > +- clock-frequency: Frequency of the external clock to the sensor >> >> These should be mutually-exclusive. If you have a clock, then you can >> get the frequency at runtime. > > Yes, you can. But the intention is to set the frequency: the sensor requires > a particular, pre-determined frequency. Typically this is specific to the > board. Okay, then state that in the description. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 15.06.2016 21:41, Rob Herring wrote: > On Tue, Jun 14, 2016 at 11:31 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote: >> Hi Rob, >> >> On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote: >>> On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: >>>> Add DT bindings description >>> >>> Not exactly the best commit msg. >>> will elaborate a bit more in the next patch version >>>> >>>> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> >>>> --- >>>> .../bindings/media/i2c/toshiba,et8ek8.txt | 50 ++++++++++++++++++++++ >>>> 1 file changed, 50 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >>>> new file mode 100644 >>>> index 0000000..997d268 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >>>> @@ -0,0 +1,50 @@ >>>> +Toshiba et8ek8 5MP sensor >>>> + >>>> +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device >>>> + >>>> +More detailed documentation can be found in >>>> +Documentation/devicetree/bindings/media/video-interfaces.txt . >>>> + >>>> + >>>> +Mandatory properties >>>> +-------------------- >>>> + >>>> +- compatible: "toshiba,et8ek8" >>>> +- reg: I2C address (0x3e, or an alternative address) >>>> +- vana-supply: Analogue voltage supply (VANA), 2.8 volts >>> >>>> +- clocks: External clock to the sensor >>>> +- clock-frequency: Frequency of the external clock to the sensor >>> >>> These should be mutually-exclusive. If you have a clock, then you can >>> get the frequency at runtime. >> >> Yes, you can. But the intention is to set the frequency: the sensor requires >> a particular, pre-determined frequency. Typically this is specific to the >> board. > > Okay, then state that in the description. > ok, will do in the next patch version Thanks, Ivo -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed 2016-06-15 22:24:40, Ivaylo Dimitrov wrote: > > > On 15.06.2016 21:41, Rob Herring wrote: > >On Tue, Jun 14, 2016 at 11:31 PM, Sakari Ailus <sakari.ailus@iki.fi> wrote: > >>Hi Rob, > >> > >>On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote: > >>>On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: > >>>>Add DT bindings description > >>> > >>>Not exactly the best commit msg. > >>> > > will elaborate a bit more in the next patch version And you can add my Acked-by to the next version :-). Pavel
diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt new file mode 100644 index 0000000..997d268 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt @@ -0,0 +1,50 @@ +Toshiba et8ek8 5MP sensor + +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device + +More detailed documentation can be found in +Documentation/devicetree/bindings/media/video-interfaces.txt . + + +Mandatory properties +-------------------- + +- compatible: "toshiba,et8ek8" +- reg: I2C address (0x3e, or an alternative address) +- vana-supply: Analogue voltage supply (VANA), 2.8 volts +- clocks: External clock to the sensor +- clock-frequency: Frequency of the external clock to the sensor +- reset-gpios: XSHUTDOWN GPIO + + +Endpoint node mandatory properties +---------------------------------- + +- remote-endpoint: A phandle to the bus receiver's endpoint node. + +Endpoint node optional properties +---------------------------------- + +- clock-lanes: <0> +- data-lanes: <1..n> + +Example +------- + +&i2c3 { + clock-frequency = <400000>; + + cam1: camera@3e { + compatible = "toshiba,et8ek8"; + reg = <0x3e>; + vana-supply = <&vaux4>; + clocks = <&isp 0>; + clock-frequency = <9600000>; + reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */ + port { + csi_cam1: endpoint { + remote-endpoint = <&csi_out1>; + }; + }; + }; +};