Message ID | 1465479695-18644-3-git-send-email-kieran@bingham.xyz (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Laurent Pinchart |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1bB0DU-0002rf-UV; Thu, 09 Jun 2016 13:41:49 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-8) with esmtp id 1bB0DS-0002Ua-kW; Thu, 09 Jun 2016 15:41:48 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752108AbcFINln (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 9 Jun 2016 09:41:43 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35573 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837AbcFINll (ORCPT <rfc822; linux-media@vger.kernel.org>); Thu, 9 Jun 2016 09:41:41 -0400 Received: by mail-wm0-f65.google.com with SMTP id k184so10789526wme.2 for <linux-media@vger.kernel.org>; Thu, 09 Jun 2016 06:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ksquared.org.uk; s=google; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Hw+AKxnetSL8hpiCdp7BaXLVJsQjEnDmQY+2g4Xk0tM=; b=Sc945SNEazVFy5pKY1aw20LFz8QixUnFvkIc2Lcm6GainkFpsAcMAFc+z4kOSdC5+q 6e4+c68kXypkhlEDRocCArDTVyYZisMt/XgtzqP9BieBgLz/v7dG/AhoJ0i7tvS2Xaln 8FBoYoxW3Uxb2kUSMwIvMyTtXJx86+VIbkDDg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bingham-xyz.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Hw+AKxnetSL8hpiCdp7BaXLVJsQjEnDmQY+2g4Xk0tM=; b=jaubC6BlCPNb8BXVhm95frBFQh1/W7UL58UDyuDQuDYBsA9hbt4CuTLh3kNXhMtaAL WXTYEjICQDmSqmglSsxb0I1pAeOlfUHMB76jeEgszsKzvSzleyXYsvtV/RmvA1E/UgAl g8kKW5htU/4+wUoxrz1rBmQuqwsheSXuWWIGzDwPLPZ3XSsN1exHeRD3wRepcEUh4WrZ hqZ/JlsWGxH0SZ77bNb3fxhbB7FbHqYBJ+T3cxcucUDMHF+q+2uRGK9q+mKsBuGT5Snn I6iEUi4HXwqxYUTCZyQJCUqc0xR3wZlneX9ItVKQbDkDDE/YhD64z7d/OOkBRuS8R/d5 /FPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Hw+AKxnetSL8hpiCdp7BaXLVJsQjEnDmQY+2g4Xk0tM=; b=EzWq4k3tnnyBtGOir78XpI46XDcalG2I3b9OWNR4mlarGCHCkD+FFMWxQ29tP9EKCv hCJKFU9gwmHkKbIo0+1brxxE/0R6+juRRvIhrPOlQRqueMH3QLm+PDTUULea/c2RK/8p snbvKGjwH5ZyWZyi3H43nWSn+w4rIviMBAbcbiCAHZFQlmlWlNi9pnRnxgTXEWGQr1L2 Jbzt2OMaYHA+08tB7atnfxZCEaILp7BVIvZyHdn7MTDW0cjynVohlQJ8IrmvH9Qx61EU 6xedwpThhubQyWAVWVw74WqFjjGSr4TNYCHPlsYzIXXMmgYSOAhGl5kSlvZcq2KA0wIR G/sw== X-Gm-Message-State: ALyK8tLtmFtvSTVupUieOXylybVVP1+ceYY2aHSR0OwqBugAh/b2VH0bkOej1e4M7fHP4w== X-Received: by 10.194.114.193 with SMTP id ji1mr10831330wjb.55.1465479700254; Thu, 09 Jun 2016 06:41:40 -0700 (PDT) Received: from CookieMonster.cookiemonster.local (host31-51-85-245.range31-51.btcentralplus.com. [31.51.85.245]) by smtp.gmail.com with ESMTPSA id lr9sm7124002wjb.39.2016.06.09.06.41.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Jun 2016 06:41:39 -0700 (PDT) From: Kieran Bingham <kieran@ksquared.org.uk> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, linux-media@vger.kernel.org (open list:MEDIA DRIVERS FOR RENESAS - FCP), linux-renesas-soc@vger.kernel.org (open list:MEDIA DRIVERS FOR RENESAS - FCP), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list) Cc: Kieran Bingham <kieran@ksquared.org.uk> Subject: [PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage Date: Thu, 9 Jun 2016 14:41:33 +0100 Message-Id: <1465479695-18644-3-git-send-email-kieran@bingham.xyz> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1465479695-18644-1-git-send-email-kieran@bingham.xyz> References: <1465479695-18644-1-git-send-email-kieran@bingham.xyz> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.6.9.133319 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, XYZ_TLD 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CS_SUSP_TLD_BODY 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_NEGATE 0, MSG_THREAD 0, MULTIPLE_RCPTS_RND 0, NO_URI_HTTPS 0, REFERENCES 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_TO_X5 0, __REFERENCES 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __YOUTUBE_RCVD 0' |
Commit Message
Kieran Bingham
June 9, 2016, 1:41 p.m. UTC
The power domain must be specified to bring the device out of module
standby. Document this in the example provided, so that new additions
are not missed.
Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 +
1 file changed, 1 insertion(+)
Comments
On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote: > The power domain must be specified to bring the device out of module > standby. Document this in the example provided, so that new additions > are not missed. > > Signed-off-by: Kieran Bingham <kieran@bingham.xyz> > --- > Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt > index 271dcfdb5a76..6a55f5215221 100644 > --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt > @@ -31,4 +31,5 @@ Device node example > compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; > reg = <0 0xfea2f000 0 0x200>; > clocks = <&cpg CPG_MOD 602>; > + power-domains = <&sysc R8A7795_PD_A3VP>; This needs to be documented above too, not just the example. > }; > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <robh@kernel.org> wrote: > On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote: >> The power domain must be specified to bring the device out of module >> standby. Document this in the example provided, so that new additions >> are not missed. >> >> Signed-off-by: Kieran Bingham <kieran@bingham.xyz> >> --- >> Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt >> index 271dcfdb5a76..6a55f5215221 100644 >> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt >> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt >> @@ -31,4 +31,5 @@ Device node example >> compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; >> reg = <0 0xfea2f000 0 0x200>; >> clocks = <&cpg CPG_MOD 602>; >> + power-domains = <&sysc R8A7795_PD_A3VP>; > > This needs to be documented above too, not just the example. Why? Power domains are an optional feature, whose presence depends on the platform, not on the device. Hence "power-domains" properties may appear in any device node. Having to document them in every single binding document is overkill. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 10, 2016 at 2:11 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Hi Rob, > > On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <robh@kernel.org> wrote: >> On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote: >>> The power domain must be specified to bring the device out of module >>> standby. Document this in the example provided, so that new additions >>> are not missed. >>> >>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz> >>> --- >>> Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt >>> index 271dcfdb5a76..6a55f5215221 100644 >>> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt >>> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt >>> @@ -31,4 +31,5 @@ Device node example >>> compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; >>> reg = <0 0xfea2f000 0 0x200>; >>> clocks = <&cpg CPG_MOD 602>; >>> + power-domains = <&sysc R8A7795_PD_A3VP>; >> >> This needs to be documented above too, not just the example. > > Why? Power domains are an optional feature, whose presence depends > on the platform, not on the device. Examples are not documentation. The binding should stand on its own without the example. How did I know this is optional unless you document it as optional? How many power domains does the device have? > Hence "power-domains" properties may appear in any device node. > Having to document them in every single binding document is overkill. We do it for everything else pretty much. There's some exceptions like "status". I agree that we get a bunch of redundancy with random text describing the properties. I'm all for a structured syntax that can distill the device bindings down to the pertainent information. If only someone proposed using yaml or something... Rob -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, CC linux-pm On Fri, Jun 10, 2016 at 11:33 PM, Rob Herring <robh@kernel.org> wrote: > On Fri, Jun 10, 2016 at 2:11 PM, Geert Uytterhoeven > <geert@linux-m68k.org> wrote: >> On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <robh@kernel.org> wrote: >>> On Thu, Jun 09, 2016 at 02:41:33PM +0100, Kieran Bingham wrote: >>>> The power domain must be specified to bring the device out of module >>>> standby. Document this in the example provided, so that new additions >>>> are not missed. >>>> >>>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz> >>>> --- >>>> Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt >>>> index 271dcfdb5a76..6a55f5215221 100644 >>>> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt >>>> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt >>>> @@ -31,4 +31,5 @@ Device node example >>>> compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; >>>> reg = <0 0xfea2f000 0 0x200>; >>>> clocks = <&cpg CPG_MOD 602>; >>>> + power-domains = <&sysc R8A7795_PD_A3VP>; >>> >>> This needs to be documented above too, not just the example. >> >> Why? Power domains are an optional feature, whose presence depends >> on the platform, not on the device. > > Examples are not documentation. The binding should stand on its own > without the example. > > How did I know this is optional unless you document it as optional? > How many power domains does the device have? The device does not have power domains, and is not aware of the existence of power domains. Each SoC has one or more power domains. "power-domains" properties are used to describe the hierarchical relationship between power domains and the devices that resides in these power domains. Just like nodes and subnodes describe the hierarchical relationship between buses and the devices directly connected to these buses. On the (Linux) software side, the device driver does have to use Runtime PM if an SoC has more power domains than just the single "always-on" power domain. >> Hence "power-domains" properties may appear in any device node. >> Having to document them in every single binding document is overkill. > > We do it for everything else pretty much. There's some exceptions like "status". IMHO having to document "power-domains" in every single DT binding is as silly as having to document that the device node must be a child of the bus device node in every single DT binding. This belongs in the DT binding of the power controller, which is the device controlling the power domain. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt index 271dcfdb5a76..6a55f5215221 100644 --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt @@ -31,4 +31,5 @@ Device node example compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; reg = <0 0xfea2f000 0 0x200>; clocks = <&cpg CPG_MOD 602>; + power-domains = <&sysc R8A7795_PD_A3VP>; };