Message ID | 20160601220840.GA21946@amd (mailing list archive) |
---|---|
State | RFC, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1b8EKN-0004io-RG; Wed, 01 Jun 2016 22:09:27 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-7) with esmtp id 1b8EKL-0006vt-1U; Thu, 02 Jun 2016 00:09:27 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751380AbcFAWJE (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 1 Jun 2016 18:09:04 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:53355 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbcFAWJD (ORCPT <rfc822; linux-media@vger.kernel.org>); Wed, 1 Jun 2016 18:09:03 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id C780D823BE; Thu, 2 Jun 2016 00:08:40 +0200 (CEST) Date: Thu, 2 Jun 2016 00:08:40 +0200 From: Pavel Machek <pavel@ucw.cz> To: Sakari Ailus <sakari.ailus@iki.fi> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>, pali.rohar@gmail.com, sre@kernel.org, kernel list <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, patrikbachan@gmail.com, serge@hallyn.com, linux-media@vger.kernel.org, mchehab@osg.samsung.com Subject: Re: [PATCHv5] support for AD5820 camera auto-focus coil Message-ID: <20160601220840.GA21946@amd> References: <573FFF51.1000004@gmail.com> <20160521105607.GA20071@amd> <574049EF.2090208@gmail.com> <20160524090433.GA1277@amd> <20160524091746.GA14536@amd> <20160525212659.GK26360@valkosipuli.retiisi.org.uk> <20160527205140.GA26767@amd> <20160531212222.GP26360@valkosipuli.retiisi.org.uk> <20160531213437.GA28397@amd> <20160601152439.GQ26360@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160601152439.GQ26360@valkosipuli.retiisi.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.6.1.220015 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, KNOWN_FREEWEB_URI 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1600_1699 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, INVALID_MSGID_NO_FQDN 0, IN_REP_TO 0, LEGITIMATE_NEGATE 0, MSG_THREAD 0, MULTIPLE_RCPTS_RND 0, NO_URI_HTTPS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __FORWARDED_MSG 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __KNOWN_FREEWEB_URI2 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_URI_TEXT 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __URI_IN_BODY 0, __URI_NS , __URI_WITH_PATH 0, __USER_AGENT 0' |
Commit Message
Pavel Machek
June 1, 2016, 10:08 p.m. UTC
On Wed 2016-06-01 18:24:39, Sakari Ailus wrote: > Hi Pavel, > > Well, it does not use any dt properties. So there's not really much to > > discuss with dt people... > > > > Maybe "ad5820" needs to go to list of simple i2c drivers somewhere, > > but... > > It's an I2C device and it does use a regulator. Not a lot, though, these are > both quite basic stuff. This should still be documented as the people who > write the DT bindings (in general) aren't expected to read driver code as > well. That's at least my understanding. Yep, you are right, I forgot about the regulator. Something like this? Thanks, Pavel
Comments
On Thu, Jun 02, 2016 at 12:08:40AM +0200, Pavel Machek wrote: > On Wed 2016-06-01 18:24:39, Sakari Ailus wrote: > > Hi Pavel, > > > > Well, it does not use any dt properties. So there's not really much to > > > discuss with dt people... > > > > > > Maybe "ad5820" needs to go to list of simple i2c drivers somewhere, > > > but... > > > > It's an I2C device and it does use a regulator. Not a lot, though, these are > > both quite basic stuff. This should still be documented as the people who > > write the DT bindings (in general) aren't expected to read driver code as > > well. That's at least my understanding. > > Yep, you are right, I forgot about the regulator. Something like this? > > Thanks, > Pavel > > diff --git a/Documentation/devicetree/bindings/media/i2c/ad5820.txt b/Documentation/devicetree/bindings/media/i2c/ad5820.txt > new file mode 100644 > index 0000000..87c98f1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ad5820.txt I might use the compatible string as such as a part of the file name. Up to you. > @@ -0,0 +1,20 @@ > +* Analog Devices AD5820 autofocus coil > + > +Required Properties: > + > + - compatible: Must contain "adi,ad5820" > + > + - reg: I2C slave address > + > + - VANA-supply: supply of voltage for VANA pin > + > +Example: > + > + /* D/A converter for auto-focus */ There is definitely D/A conversion happening there but I'm not sure I'd characterise the device as such. They're typically called "voice coil drivers", perhaps because the devices are similar to a parts of a loudspeaker. > + ad5820: dac@0c { > + compatible = "adi,ad5820"; > + reg = <0x0c>; > + > + VANA-supply = <&vaux4>; > + }; > + > >
On Thu 2016-06-02 10:45:45, Sakari Ailus wrote: > On Thu, Jun 02, 2016 at 12:08:40AM +0200, Pavel Machek wrote: > > On Wed 2016-06-01 18:24:39, Sakari Ailus wrote: > > > Hi Pavel, > > > > > > Well, it does not use any dt properties. So there's not really much to > > > > discuss with dt people... > > > > > > > > Maybe "ad5820" needs to go to list of simple i2c drivers somewhere, > > > > but... > > > > > > It's an I2C device and it does use a regulator. Not a lot, though, these are > > > both quite basic stuff. This should still be documented as the people who > > > write the DT bindings (in general) aren't expected to read driver code as > > > well. That's at least my understanding. > > > > Yep, you are right, I forgot about the regulator. Something like this? > > > > Thanks, > > Pavel > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ad5820.txt b/Documentation/devicetree/bindings/media/i2c/ad5820.txt > > new file mode 100644 > > index 0000000..87c98f1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/ad5820.txt > > I might use the compatible string as such as a part of the file name. Up to > you. Sorry, can't do that, for consistency with other ad* files in the directory. > > @@ -0,0 +1,20 @@ > > +* Analog Devices AD5820 autofocus coil > > + > > +Required Properties: > > + > > + - compatible: Must contain "adi,ad5820" > > + > > + - reg: I2C slave address > > + > > + - VANA-supply: supply of voltage for VANA pin > > + > > +Example: > > + > > + /* D/A converter for auto-focus */ > > There is definitely D/A conversion happening there but I'm not sure I'd > characterise the device as such. They're typically called "voice coil > drivers", perhaps because the devices are similar to a parts of a > loudspeaker. Well, I'm pretty sure I did not invent that comment, but I can drop it. Best regards, Pavel
On Thu, Jun 02, 2016 at 09:27:37PM +0200, Pavel Machek wrote: > On Thu 2016-06-02 10:45:45, Sakari Ailus wrote: > > On Thu, Jun 02, 2016 at 12:08:40AM +0200, Pavel Machek wrote: > > > On Wed 2016-06-01 18:24:39, Sakari Ailus wrote: > > > > Hi Pavel, > > > > > > > > Well, it does not use any dt properties. So there's not really much to > > > > > discuss with dt people... > > > > > > > > > > Maybe "ad5820" needs to go to list of simple i2c drivers somewhere, > > > > > but... > > > > > > > > It's an I2C device and it does use a regulator. Not a lot, though, these are > > > > both quite basic stuff. This should still be documented as the people who > > > > write the DT bindings (in general) aren't expected to read driver code as > > > > well. That's at least my understanding. > > > > > > Yep, you are right, I forgot about the regulator. Something like this? > > > > > > Thanks, > > > Pavel > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ad5820.txt b/Documentation/devicetree/bindings/media/i2c/ad5820.txt > > > new file mode 100644 > > > index 0000000..87c98f1 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/i2c/ad5820.txt > > > > I might use the compatible string as such as a part of the file name. Up to > > you. > > Sorry, can't do that, for consistency with other ad* files in the directory. > > > > @@ -0,0 +1,20 @@ > > > +* Analog Devices AD5820 autofocus coil > > > + > > > +Required Properties: > > > + > > > + - compatible: Must contain "adi,ad5820" > > > + > > > + - reg: I2C slave address > > > + > > > + - VANA-supply: supply of voltage for VANA pin > > > + > > > +Example: > > > + > > > + /* D/A converter for auto-focus */ > > > > There is definitely D/A conversion happening there but I'm not sure I'd > > characterise the device as such. They're typically called "voice coil > > drivers", perhaps because the devices are similar to a parts of a > > loudspeaker. > > Well, I'm pretty sure I did not invent that comment, but I can drop > it. Both are fine for me.
diff --git a/Documentation/devicetree/bindings/media/i2c/ad5820.txt b/Documentation/devicetree/bindings/media/i2c/ad5820.txt new file mode 100644 index 0000000..87c98f1 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ad5820.txt @@ -0,0 +1,20 @@ +* Analog Devices AD5820 autofocus coil + +Required Properties: + + - compatible: Must contain "adi,ad5820" + + - reg: I2C slave address + + - VANA-supply: supply of voltage for VANA pin + +Example: + + /* D/A converter for auto-focus */ + ad5820: dac@0c { + compatible = "adi,ad5820"; + reg = <0x0c>; + + VANA-supply = <&vaux4>; + }; +