Message ID | 1464369565-12259-5-git-send-email-kieran@bingham.xyz (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Laurent Pinchart |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1b6LRJ-0001xY-9s; Fri, 27 May 2016 17:20:49 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-5) with esmtp id 1b6LRH-0004nz-6u; Fri, 27 May 2016 19:20:49 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932902AbcE0RU0 (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 27 May 2016 13:20:26 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34831 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932915AbcE0RTd (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 27 May 2016 13:19:33 -0400 Received: by mail-wm0-f67.google.com with SMTP id e3so239920wme.2 for <linux-media@vger.kernel.org>; Fri, 27 May 2016 10:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ksquared.org.uk; s=google; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Dk8SRrvYV2XCqw4FqlyLRvZLlh4TnkTelYdg8yU6h+M=; b=HjXjZUM19LlvZAULKJyx8YKIPkxi3R+iAnoZ2HJujBrXdlEmU5d/F6iPTs8SyFiaoX 8UuL+tirCM/EfYFT1qynf+cu0q8lvggr9+5w97uAHrHQG+9F2s69NczWIJo0b4vHUFVk h709eQtCxAVVEI8zwS35mgZBLa7Jlelw9hBKo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bingham-xyz.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Dk8SRrvYV2XCqw4FqlyLRvZLlh4TnkTelYdg8yU6h+M=; b=aRolCxw0MX671W+q0tICKaHRO/VPQlQeWD+RHdPIBslFON8iJeDY3m56OjcgQlsVsF w9GmLnLEOZhmKlEKgH3IybrcWYyP5BiCQlEAqnc39knlkhYQ9MofKUeNq5xiQCBFnR70 zkmdAUoj8GqjW+4F8vrvOlTKz9p9Ce7479Q3lh50elTYzYorApHlWXscP4EVZG0P/mmQ HL+sAg9B0fVlVt+vR+RGzPuv0l4LRbtpa0j25c8ktHYOOAprwsOxAGrFeF5Ei+gu0GQb rNYvN/zMGRPujVwzhPx/eTn5qYKeUPB7nZ/HiVnZQtk+0XUw4VVn3dGEpfo/VH8pHe9L VQIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Dk8SRrvYV2XCqw4FqlyLRvZLlh4TnkTelYdg8yU6h+M=; b=NgTubvD7qdCZs3hlcVJ2Qoek1rrUfrkS3LZnQ5KVwhYmaZrETGrTmA2vnwp3BgYzW9 Ceb1f90DABDiPjZ2e+FtIAWB148Pm/Uviq1PBt+pZLtMIt/YW8Fp64W9JD4OkjHPkz9l IHzIs8wqex62aBuHgPLIYDcwiTh1an6VfOkvJbeuaTjfytmxJEJ3BzYxbGTok/2E7QRl p0fGQVRNOKVGvBrnxf3bXpXYq7kc0FOqP6d+r+lKwiXEAYkk33o76th4vUC5jSwgytIB G2irH5lrfaTh+owgIUOLG91xNVOhq5KYp3XnZR+NFIa18tgRGG/guTxCo1LWYm+WrMDg LRdA== X-Gm-Message-State: ALyK8tLhAbLqFFalXjxM2RvAmlw3BdGb9AoifC0eDY9zVoPkj0yK6Sicj2U3e9GPPTFJlg== X-Received: by 10.28.87.6 with SMTP id l6mr10829828wmb.48.1464369571920; Fri, 27 May 2016 10:19:31 -0700 (PDT) Received: from CookieMonster.cookiemonster.local (cpc87017-aztw30-2-0-cust65.18-1.cable.virginm.net. [92.232.232.66]) by smtp.gmail.com with ESMTPSA id wb10sm20354645wjc.8.2016.05.27.10.19.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 27 May 2016 10:19:31 -0700 (PDT) From: Kieran Bingham <kieran@ksquared.org.uk> To: laurent.pinchart@ideasonboard.com, linux-renesas-soc@vger.kernel.org, kieran@ksquared.org.uk Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains usage Date: Fri, 27 May 2016 18:19:24 +0100 Message-Id: <1464369565-12259-5-git-send-email-kieran@bingham.xyz> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1464369565-12259-1-git-send-email-kieran@bingham.xyz> References: <1464369565-12259-1-git-send-email-kieran@bingham.xyz> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.5.27.171218 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, XYZ_TLD 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1300_1399 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CS_SUSP_TLD_BODY 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_NEGATE 0, MSG_THREAD 0, MULTIPLE_RCPTS_RND 0, NO_URI_HTTPS 0, REFERENCES 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __REFERENCES 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __YOUTUBE_RCVD 0' |
Commit Message
Kieran Bingham
May 27, 2016, 5:19 p.m. UTC
The example misses the power-domains usage, and documentation that the
property is used by the node.
Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
---
Documentation/devicetree/bindings/media/renesas,fcp.txt | 3 +++
1 file changed, 3 insertions(+)
Comments
Hi Kieran, On Fri, May 27, 2016 at 7:19 PM, Kieran Bingham <kieran@ksquared.org.uk> wrote: > The example misses the power-domains usage, and documentation that the > property is used by the node. > > Signed-off-by: Kieran Bingham <kieran@bingham.xyz> Thanks for your patch! > --- > Documentation/devicetree/bindings/media/renesas,fcp.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt > index 1c0718b501ef..464bb7ae4b92 100644 > --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt > @@ -21,6 +21,8 @@ are paired with. These DT bindings currently support the FCPV and FCPF. > > - reg: the register base and size for the device registers > - clocks: Reference to the functional clock > + - power-domains : power-domain property defined with a phandle > + to respective power domain. I'd write "power domain specifier" instead of "phandle". While SYSC on R-Car Gen3 uses #power-domain-cells = 0, the FCP module may show up on another SoC that uses a different value, needing more than just a phandle. In fact I'm inclined to leave out the power-domains property completely: it's not a feature of the FCP, but of the SoC the FCP is part of. power-domains properties may appear in any device node where needed. > Device node example > @@ -30,4 +32,5 @@ Device node example > compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; > reg = <0 0xfea2f000 0 0x200>; > clocks = <&cpg CPG_MOD 602>; > + power-domains = <&sysc R8A7795_PD_A3VP>; Adding it to the example doesn't hurt, though. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Geert, On 28/05/16 20:03, Geert Uytterhoeven wrote: > Hi Kieran, > > On Fri, May 27, 2016 at 7:19 PM, Kieran Bingham <kieran@ksquared.org.uk> wrote: >> The example misses the power-domains usage, and documentation that the >> property is used by the node. >> >> Signed-off-by: Kieran Bingham <kieran@bingham.xyz> > > Thanks for your patch! > >> --- >> Documentation/devicetree/bindings/media/renesas,fcp.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt >> index 1c0718b501ef..464bb7ae4b92 100644 >> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt >> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt >> @@ -21,6 +21,8 @@ are paired with. These DT bindings currently support the FCPV and FCPF. >> >> - reg: the register base and size for the device registers >> - clocks: Reference to the functional clock >> + - power-domains : power-domain property defined with a phandle >> + to respective power domain. > > I'd write "power domain specifier" instead of "phandle". While SYSC on R-Car > Gen3 uses #power-domain-cells = 0, the FCP module may show up on another > SoC that uses a different value, needing more than just a phandle. > > In fact I'm inclined to leave out the power-domains property completely: > it's not a feature of the FCP, but of the SoC the FCP is part of. > power-domains properties may appear in any device node where needed. I'm happy to just drop this part. It was mainly the addition to the example I was after, as I had followed the example, and thus missed the power-domain setting. >> Device node example >> @@ -30,4 +32,5 @@ Device node example >> compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; >> reg = <0 0xfea2f000 0 0x200>; >> clocks = <&cpg CPG_MOD 602>; >> + power-domains = <&sysc R8A7795_PD_A3VP>; > > Adding it to the example doesn't hurt, though. Ok, I'll adjust and just keep the example in v2.
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt index 1c0718b501ef..464bb7ae4b92 100644 --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt @@ -21,6 +21,8 @@ are paired with. These DT bindings currently support the FCPV and FCPF. - reg: the register base and size for the device registers - clocks: Reference to the functional clock + - power-domains : power-domain property defined with a phandle + to respective power domain. Device node example @@ -30,4 +32,5 @@ Device node example compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; reg = <0 0xfea2f000 0 0x200>; clocks = <&cpg CPG_MOD 602>; + power-domains = <&sysc R8A7795_PD_A3VP>; };