[-next,2/3] media/IR/imon: testing the wrong variable

Message ID 20100504113825.GV29093@bicker (mailing list archive)
State Superseded, archived
Headers

Commit Message

Dan Carpenter May 4, 2010, 11:38 a.m. UTC
  There is a typo here.  We meant to test "ir" instead of "props".  The
"props" variable was tested earlier.

Signed-off-by: Dan Carpenter <error27@gmail.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Comments

Jarod Wilson May 4, 2010, 1:55 p.m. UTC | #1
On Tue, May 4, 2010 at 7:38 AM, Dan Carpenter <error27@gmail.com> wrote:
> There is a typo here.  We meant to test "ir" instead of "props".  The
> "props" variable was tested earlier.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Acked-by: Jarod Wilson <jarod@redhat.com>
  

Patch

diff --git a/drivers/media/IR/imon.c b/drivers/media/IR/imon.c
index b65c31a..f2066d0 100644
--- a/drivers/media/IR/imon.c
+++ b/drivers/media/IR/imon.c
@@ -1672,7 +1672,7 @@  static struct input_dev *imon_init_idev(struct imon_context *ictx)
 	}
 
 	ir = kzalloc(sizeof(struct ir_input_dev), GFP_KERNEL);
-	if (!props) {
+	if (!ir) {
 		dev_err(ictx->dev, "remote ir input dev allocation failed\n");
 		goto ir_dev_alloc_failed;
 	}