Message ID | 1429823471-21835-2-git-send-email-olli.salonen@iki.fi (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1YlOPU-0006La-Hh; Thu, 23 Apr 2015 23:11:48 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.76/mailfrontend-8) with esmtp id 1YlOPR-0007op-mB; Thu, 23 Apr 2015 23:11:47 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031263AbbDWVLf (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 23 Apr 2015 17:11:35 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:36374 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031035AbbDWVLb (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 23 Apr 2015 17:11:31 -0400 Received: by lagv1 with SMTP id v1so21949428lag.3 for <linux-media@vger.kernel.org>; Thu, 23 Apr 2015 14:11:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=XNK1F6JLW4gr/Zf2lWD1e/TR+esb2hkYFLYZ9JxsTDw=; b=EUqvEM85x7r9vhPVvbigAZRV8f/nXdoMHPKrzgDCQ/5SJGLQbhNYkYgRSzurrPnF4a hOR9+6j9wcwxQh5gw1kAl8vt9SmYv1cEfysPkiCYR/B4ggKqV5KYbTEuYKMAWeTBM9UK cHjgg4q2R8c5GGNnCshSfE57AwMVV66elFDRhpPTTxj2nfW0UvorMz5H3kibnTcG0Djr OCmfsE/usdqoYX+TnyD9lGbIA2MYlKarFrrT6wIxeQu8yJa0KiC6wImywtxX1Us+K8/t +zyq6LgHpHJ0B/GcNO87mWIIMBn/Vmkm+J+C1QmZ8M1w9NewycfsfgXm2apbJnRziG2M v4pg== X-Gm-Message-State: ALoCoQnpLc/oZXxpS/3Dtjs40pn5w5g3u1poFtVAcMTBq/77KKjryidJVb6wmipFmNCyZuSZ1P+l X-Received: by 10.112.159.162 with SMTP id xd2mr4103250lbb.67.1429823490252; Thu, 23 Apr 2015 14:11:30 -0700 (PDT) Received: from dl160.lan (188-67-88-189.bb.dnainternet.fi. [188.67.88.189]) by mx.google.com with ESMTPSA id i3sm2121712lbs.21.2015.04.23.14.11.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Apr 2015 14:11:29 -0700 (PDT) From: Olli Salonen <olli.salonen@iki.fi> To: linux-media@vger.kernel.org Cc: Olli Salonen <olli.salonen@iki.fi> Subject: [PATCH 02/12] dvbsky: use si2168 config option ts_clock_gapped Date: Fri, 24 Apr 2015 00:11:01 +0300 Message-Id: <1429823471-21835-2-git-send-email-olli.salonen@iki.fi> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1429823471-21835-1-git-send-email-olli.salonen@iki.fi> References: <1429823471-21835-1-git-send-email-olli.salonen@iki.fi> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.4.23.210318 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __DATE_TZ_RU 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __REFERENCES 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Olli Salonen
April 23, 2015, 9:11 p.m. UTC
Change the dvbsky driver to support gapped clock instead of the current
hack.
Signed-off-by: Olli Salonen <olli.salonen@iki.fi>
---
drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
Hi Olli, in saa716x_budget.c I've also got (for TBS6285) si2168_config.i2c_adapter = &i2cadapter; si2168_config.fe = &adapter->fe; si2168_config.ts_mode = SI2168_TS_SERIAL; memset(&info, 0, sizeof(struct i2c_board_info)); Should I just add it like this? si2168_config.ts_mode = SI2168_TS_SERIAL; si2168_config.ts_clock_gapped = true; memset(&info, 0, sizeof(struct i2c_board_info)); Kind regards, Tycho. Op 23-04-15 om 23:11 schreef Olli Salonen: > Change the dvbsky driver to support gapped clock instead of the current > hack. > > Signed-off-by: Olli Salonen <olli.salonen@iki.fi> > --- > drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c > index cdf59bc..0f73b1d 100644 > --- a/drivers/media/usb/dvb-usb-v2/dvbsky.c > +++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c > @@ -615,7 +615,8 @@ static int dvbsky_t330_attach(struct dvb_usb_adapter *adap) > memset(&si2168_config, 0, sizeof(si2168_config)); > si2168_config.i2c_adapter = &i2c_adapter; > si2168_config.fe = &adap->fe[0]; > - si2168_config.ts_mode = SI2168_TS_PARALLEL | 0x40; > + si2168_config.ts_mode = SI2168_TS_PARALLEL; > + si2168_config.ts_clock_gapped = true; > memset(&info, 0, sizeof(struct i2c_board_info)); > strlcpy(info.type, "si2168", I2C_NAME_SIZE); > info.addr = 0x64; -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
One more question: cx23885-dvb.c (and maybe others) contains a couple of instances of si2168_config.ts_mode = SI2168_TS_PARALLEL; and si2168_config.ts_mode = SI2168_TS_SERIAL; But you don't patch them with si2168_config.ts_clock_gapped = true; Is this intentional? Kind regards, Tycho Op 23-04-15 om 23:11 schreef Olli Salonen: > Change the dvbsky driver to support gapped clock instead of the current > hack. > > Signed-off-by: Olli Salonen <olli.salonen@iki.fi> > --- > drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c > index cdf59bc..0f73b1d 100644 > --- a/drivers/media/usb/dvb-usb-v2/dvbsky.c > +++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c > @@ -615,7 +615,8 @@ static int dvbsky_t330_attach(struct dvb_usb_adapter *adap) > memset(&si2168_config, 0, sizeof(si2168_config)); > si2168_config.i2c_adapter = &i2c_adapter; > si2168_config.fe = &adap->fe[0]; > - si2168_config.ts_mode = SI2168_TS_PARALLEL | 0x40; > + si2168_config.ts_mode = SI2168_TS_PARALLEL; > + si2168_config.ts_clock_gapped = true; > memset(&info, 0, sizeof(struct i2c_board_info)); > strlcpy(info.type, "si2168", I2C_NAME_SIZE); > info.addr = 0x64; -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tycho, Yes, so far the only device that I know should use gapped clock is the DVBSky T330 a.k.a. TechnoTrend CT2-4400. I've also seen that the Hauppauge HVR-2205 Windows driver enables this option, but it seems to me that that board works ok also without this. Cheers, -olli On 24 April 2015 at 09:01, Olli Salonen <olli.salonen@iki.fi> wrote: > Hi Tycho, > > Yes, so far the only device that I know should use gapped clock is the > DVBSky T330 a.k.a. TechnoTrend CT2-4400. > > I've also seen that the Hauppauge HVR-2205 Windows driver enables this > option, but it seems to me that that board works ok also without this. > > Cheers, > -olli > > On 24 April 2015 at 08:57, Tycho Lürsen <tycholursen@gmail.com> wrote: >> >> One more question: >> >> cx23885-dvb.c (and maybe others) contains a couple of instances of >> >> si2168_config.ts_mode = SI2168_TS_PARALLEL; >> and >> si2168_config.ts_mode = SI2168_TS_SERIAL; >> >> But you don't patch them with >> >> si2168_config.ts_clock_gapped = true; >> >> Is this intentional? >> >> Kind regards, >> Tycho >> >> Op 23-04-15 om 23:11 schreef Olli Salonen: >>> >>> Change the dvbsky driver to support gapped clock instead of the current >>> hack. >>> >>> Signed-off-by: Olli Salonen <olli.salonen@iki.fi> >>> --- >>> drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c >>> b/drivers/media/usb/dvb-usb-v2/dvbsky.c >>> index cdf59bc..0f73b1d 100644 >>> --- a/drivers/media/usb/dvb-usb-v2/dvbsky.c >>> +++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c >>> @@ -615,7 +615,8 @@ static int dvbsky_t330_attach(struct dvb_usb_adapter >>> *adap) >>> memset(&si2168_config, 0, sizeof(si2168_config)); >>> si2168_config.i2c_adapter = &i2c_adapter; >>> si2168_config.fe = &adap->fe[0]; >>> - si2168_config.ts_mode = SI2168_TS_PARALLEL | 0x40; >>> + si2168_config.ts_mode = SI2168_TS_PARALLEL; >>> + si2168_config.ts_clock_gapped = true; >>> memset(&info, 0, sizeof(struct i2c_board_info)); >>> strlcpy(info.type, "si2168", I2C_NAME_SIZE); >>> info.addr = 0x64; >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> I've also seen that the Hauppauge HVR-2205 Windows driver enables this > option, but it seems to me that that board works ok also without this. Olli, I found out why this is, I thought you'd appreciate the comment.... Apparently the issue only occurs with DVB streams faster than approximately 50Mbps, which standard DVB-T/T2, ATSC and QAM-B never are. The issue apparently, is with some QAM-A (DVB-C) streams in Europe..... This explains why I've never seen it. That's being said, I do plan to add the gapped clock patch to the SAA7164 shortly - for safety.
Hi Steven, Olli, Steven, thanks for your comment So maybe this should also go into cx23885? I'm in Europe and only have DVB-C I'll add it to my saa716x driver as well Op 24-04-15 om 15:16 schreef Steven Toth: >> I've also seen that the Hauppauge HVR-2205 Windows driver enables this >> option, but it seems to me that that board works ok also without this. > Olli, I found out why this is, I thought you'd appreciate the comment.... > > Apparently the issue only occurs with DVB streams faster than > approximately 50Mbps, which standard DVB-T/T2, ATSC and QAM-B never > are. > > The issue apparently, is with some QAM-A (DVB-C) streams in > Europe..... This explains why I've never seen it. That's being said, I > do plan to add the gapped clock patch to the SAA7164 shortly - for > safety. > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Steven, thanks for your comment You are very welcome. > > So maybe this should also go into cx23885? > I'm in Europe and only have DVB-C My understanding is that it applies to all USB/PCIe bridges.
Thank you Steven, That's helpful to know. I've been bumping into some issues with another Si2168-based device and certain DVB-C streams. Will try to see if this could help in that case... Cheers, -olli On 24 April 2015 at 15:16, Steven Toth <stoth@kernellabs.com> wrote: >> I've also seen that the Hauppauge HVR-2205 Windows driver enables this >> option, but it seems to me that that board works ok also without this. > > Olli, I found out why this is, I thought you'd appreciate the comment.... > > Apparently the issue only occurs with DVB streams faster than > approximately 50Mbps, which standard DVB-T/T2, ATSC and QAM-B never > are. > > The issue apparently, is with some QAM-A (DVB-C) streams in > Europe..... This explains why I've never seen it. That's being said, I > do plan to add the gapped clock patch to the SAA7164 shortly - for > safety. > > -- > Steven Toth - Kernel Labs > http://www.kernellabs.com > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c index cdf59bc..0f73b1d 100644 --- a/drivers/media/usb/dvb-usb-v2/dvbsky.c +++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c @@ -615,7 +615,8 @@ static int dvbsky_t330_attach(struct dvb_usb_adapter *adap) memset(&si2168_config, 0, sizeof(si2168_config)); si2168_config.i2c_adapter = &i2c_adapter; si2168_config.fe = &adap->fe[0]; - si2168_config.ts_mode = SI2168_TS_PARALLEL | 0x40; + si2168_config.ts_mode = SI2168_TS_PARALLEL; + si2168_config.ts_clock_gapped = true; memset(&info, 0, sizeof(struct i2c_board_info)); strlcpy(info.type, "si2168", I2C_NAME_SIZE); info.addr = 0x64;