| Message ID | 1426175114-14876-5-git-send-email-j.anaszewski@samsung.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1YW5Mc-0007Wo-Rq; Thu, 12 Mar 2015 16:49:34 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1YW5Ma-00064v-3H; Thu, 12 Mar 2015 16:49:33 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030260AbbCLPqQ (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 12 Mar 2015 11:46:16 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:62148 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932082AbbCLPqC (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 12 Mar 2015 11:46:02 -0400 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NL300IXUVSOG270@mailout2.samsung.com>; Fri, 13 Mar 2015 00:46:00 +0900 (KST) X-AuditID: cbfee61b-f79d76d0000024d6-36-5501b4b8441d Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 88.9D.09430.8B4B1055; Fri, 13 Mar 2015 00:46:00 +0900 (KST) Received: from AMDC2362.DIGITAL.local ([106.120.53.23]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NL300DC9VRGU950@mmp2.samsung.com>; Fri, 13 Mar 2015 00:46:00 +0900 (KST) From: Jacek Anaszewski <j.anaszewski@samsung.com> To: linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: kyungmin.park@samsung.com, pavel@ucw.cz, cooloney@gmail.com, rpurdie@rpsys.net, sakari.ailus@iki.fi, s.nawrocki@samsung.com, Jacek Anaszewski <j.anaszewski@samsung.com>, Andrzej Hajda <a.hajda@samsung.com>, Lee Jones <lee.jones@linaro.org>, Chanwoo Choi <cw00.choi@samsung.com> Subject: [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693 Date: Thu, 12 Mar 2015 16:45:05 +0100 Message-id: <1426175114-14876-5-git-send-email-j.anaszewski@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1426175114-14876-1-git-send-email-j.anaszewski@samsung.com> References: <1426175114-14876-1-git-send-email-j.anaszewski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPLMWRmVeSWpSXmKPExsVy+t9jQd0dWxhDDSZv07e4te4cq8XRnROZ LK5/ec5qMf8IkNt79TmjxdmmN+wW978eZbS4vGsOm8XWN+sYLXo2bGW1uHvqKJvF7l1PWS0O v2lntTizfyWbA5/Hzll32T0Of13I4nHn2h42jz3zf7B69G1ZxeixYvV3do/Pm+QC2KO4bFJS czLLUov07RK4Mua8fctYsFim4sY04wbGDeJdjJwcEgImEteW3GSHsMUkLtxbz9bFyMUhJDCd UeLf95fsEE47k0Tf6k6wKjYBQ4mfL14zgdgiAuUSe+48BitiFljIJLF3bitzFyMHh7CAv0Tr lXyQGhYBVYllLVMZQWxeAQ+JN1vfsoCUSAgoSMyZZAMS5hTwlOi+/wGsRAioZPKGv+wTGHkX MDKsYhRNLUguKE5KzzXSK07MLS7NS9dLzs/dxAgO1mfSOxhXNVgcYhTgYFTi4b3wnSFUiDWx rLgy9xCjBAezkgiv6XzGUCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8SvZtIUIC6YklqdmpqQWp RTBZJg5OqQZG+VvaOzc/m777UoX2kTV3l5d8N4jP6/h2bLnDVvef8UccTbJNrnyaF3vEX1aK 6bLy38h3BiKc1XMvhG2LMnjgYBZud4AxTWqT4r26158We+uzlCh11+5cw3dHsZ5vVbdTy8sV zz3PxN5euyZD8MSu7HnMCx30pnC9YpobEH1/ZcSi5ldX993focRSnJFoqMVcVJwIAMieqF9S AgAA Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.3.12.153621 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' HTML_NO_HTTP 0.1, MULTIPLE_RCPTS 0.1, HTML_00_10 0.05, BODY_SIZE_3000_3999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, REFERENCES 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_NAME_BODY 0, __CP_URI_IN_BODY 0, __FRAUD_BADTHINGS 0, __HAS_FROM 0, __HAS_HTML 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Jacek Anaszewski
March 12, 2015, 3:45 p.m. UTC
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: Chanwoo Choi <cw00.choi@samsung.com> Cc: Bryan Wu <cooloney@gmail.com> Cc: Richard Purdie <rpurdie@rpsys.net> --- Documentation/devicetree/bindings/mfd/max77693.txt | 61 ++++++++++++++++++++ 1 file changed, 61 insertions(+)
Comments
This patch requires a DT Ack. > This patch adds device tree binding documentation for > the flash cell of the Maxim max77693 multifunctional device. > > Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Chanwoo Choi <cw00.choi@samsung.com> > Cc: Bryan Wu <cooloney@gmail.com> > Cc: Richard Purdie <rpurdie@rpsys.net> > --- > Documentation/devicetree/bindings/mfd/max77693.txt | 61 ++++++++++++++++++++ > 1 file changed, 61 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt > index 38e6440..15c546e 100644 > --- a/Documentation/devicetree/bindings/mfd/max77693.txt > +++ b/Documentation/devicetree/bindings/mfd/max77693.txt > @@ -76,7 +76,53 @@ Optional properties: > Valid values: 4300000, 4700000, 4800000, 4900000 > Default: 4300000 > > +- led : the LED submodule device node > + > +There are two LED outputs available - FLED1 and FLED2. Each of them can > +control a separate LED or they can be connected together to double > +the maximum current for a single connected LED. One LED is represented > +by one child node. > + > +Required properties: > +- compatible : Must be "maxim,max77693-led". > + > +Optional properties: > +- maxim,trigger-type : Flash trigger type. > + Possible trigger types: > + LEDS_TRIG_TYPE_EDGE (0) - Rising edge of the signal triggers > + the flash, > + LEDS_TRIG_TYPE_LEVEL (1) - Strobe pulse length controls duration > + of the flash. > +- maxim,boost-mode : > + In boost mode the device can produce up to 1.2A of total current > + on both outputs. The maximum current on each output is reduced > + to 625mA then. If not enabled explicitly, boost setting defaults to > + LEDS_BOOST_FIXED in case both current sources are used. > + Possible values: > + LEDS_BOOST_OFF (0) - no boost, > + LEDS_BOOST_ADAPTIVE (1) - adaptive mode, > + LEDS_BOOST_FIXED (2) - fixed mode. > +- maxim,boost-mvout : Output voltage of the boost module in millivolts. > +- maxim,mvsys-min : Low input voltage level in millivolts. Flash is not fired > + if chip estimates that system voltage could drop below this level due > + to flash power consumption. > + > +Required properties of the LED child node: > +- led-sources : see Documentation/devicetree/bindings/leds/common.txt; > + device current output identifiers: 0 - FLED1, 1 - FLED2 > + > +Optional properties of the LED child node: > +- label : see Documentation/devicetree/bindings/leds/common.txt > +- max-microamp : see Documentation/devicetree/bindings/leds/common.txt > + Range: 15625 - 250000 > +- flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt > + Range: 15625 - 1000000 > +- flash-timeout-us : see Documentation/devicetree/bindings/leds/common.txt > + Range: 62500 - 1000000 > + > Example: > +#include <dt-bindings/leds/common.h> > + > max77693@66 { > compatible = "maxim,max77693"; > reg = <0x66>; > @@ -117,5 +163,20 @@ Example: > maxim,thermal-regulation-celsius = <75>; > maxim,battery-overcurrent-microamp = <3000000>; > maxim,charge-input-threshold-microvolt = <4300000>; > + > + led { > + compatible = "maxim,max77693-led"; > + maxim,trigger-type = <LEDS_TRIG_TYPE_LEVEL>; > + maxim,boost-mode = <LEDS_BOOST_FIXED>; > + maxim,boost-mvout = <5000>; > + maxim,mvsys-min = <2400>; > + > + camera_flash: flash-led { > + label = "max77693-flash"; > + led-sources = <0>, <1>; > + max-microamp = <500000>; > + flash-max-microamp = <1250000>; > + flash-timeout-us = <1000000>; > + }; > }; > };
On Mon 2015-03-23 12:07:43, Lee Jones wrote: > This patch requires a DT Ack. No, it requires DT people to be notified -- and they were, few times by now. They clearly don't care. > > This patch adds device tree binding documentation for > > the flash cell of the Maxim max77693 multifunctional device. > > > > Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > > Cc: Lee Jones <lee.jones@linaro.org> > > Cc: Chanwoo Choi <cw00.choi@samsung.com> > > Cc: Bryan Wu <cooloney@gmail.com> > > Cc: Richard Purdie <rpurdie@rpsys.net> Acked-by: Pavel Machek <pavel@ucw.cz> > > diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt > > index 38e6440..15c546e 100644 > > --- a/Documentation/devicetree/bindings/mfd/max77693.txt > > +++ b/Documentation/devicetree/bindings/mfd/max77693.txt > > @@ -76,7 +76,53 @@ Optional properties: > > Valid values: 4300000, 4700000, 4800000, 4900000 > > Default: 4300000 > > > > +- led : the LED submodule device node > > + > > +There are two LED outputs available - FLED1 and FLED2. Each of them can > > +control a separate LED or they can be connected together to double > > +the maximum current for a single connected LED. One LED is represented > > +by one child node. > > + > > +Required properties: > > +- compatible : Must be "maxim,max77693-led". > > + > > +Optional properties: > > +- maxim,trigger-type : Flash trigger type. > > + Possible trigger types: > > + LEDS_TRIG_TYPE_EDGE (0) - Rising edge of the signal triggers > > + the flash, > > + LEDS_TRIG_TYPE_LEVEL (1) - Strobe pulse length controls duration > > + of the flash. > > +- maxim,boost-mode : > > + In boost mode the device can produce up to 1.2A of total current > > + on both outputs. The maximum current on each output is reduced > > + to 625mA then. If not enabled explicitly, boost setting defaults to > > + LEDS_BOOST_FIXED in case both current sources are used. > > + Possible values: > > + LEDS_BOOST_OFF (0) - no boost, > > + LEDS_BOOST_ADAPTIVE (1) - adaptive mode, > > + LEDS_BOOST_FIXED (2) - fixed mode. > > +- maxim,boost-mvout : Output voltage of the boost module in millivolts. > > +- maxim,mvsys-min : Low input voltage level in millivolts. Flash is not fired > > + if chip estimates that system voltage could drop below this level due > > + to flash power consumption. > > + > > +Required properties of the LED child node: > > +- led-sources : see Documentation/devicetree/bindings/leds/common.txt; > > + device current output identifiers: 0 - FLED1, 1 - FLED2 > > + > > +Optional properties of the LED child node: > > +- label : see Documentation/devicetree/bindings/leds/common.txt > > +- max-microamp : see Documentation/devicetree/bindings/leds/common.txt > > + Range: 15625 - 250000 > > +- flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt > > + Range: 15625 - 1000000 > > +- flash-timeout-us : see Documentation/devicetree/bindings/leds/common.txt > > + Range: 62500 - 1000000 > > + > > Example: > > +#include <dt-bindings/leds/common.h> > > + > > max77693@66 { > > compatible = "maxim,max77693"; > > reg = <0x66>; > > @@ -117,5 +163,20 @@ Example: > > maxim,thermal-regulation-celsius = <75>; > > maxim,battery-overcurrent-microamp = <3000000>; > > maxim,charge-input-threshold-microvolt = <4300000>; > > + > > + led { > > + compatible = "maxim,max77693-led"; > > + maxim,trigger-type = <LEDS_TRIG_TYPE_LEVEL>; > > + maxim,boost-mode = <LEDS_BOOST_FIXED>; > > + maxim,boost-mvout = <5000>; > > + maxim,mvsys-min = <2400>; > > + > > + camera_flash: flash-led { > > + label = "max77693-flash"; > > + led-sources = <0>, <1>; > > + max-microamp = <500000>; > > + flash-max-microamp = <1250000>; > > + flash-timeout-us = <1000000>; > > + }; > > }; > > }; > >
On Mon, 23 Mar 2015, Pavel Machek wrote: > On Mon 2015-03-23 12:07:43, Lee Jones wrote: > > This patch requires a DT Ack. > > No, it requires DT people to be notified -- and they were, few times > by now. > > They clearly don't care. Well fortunately for the Kernel community, I do care. And as this patch adds 3 new DT properties, has been through many iterations already with vast changes made over that period and there is still some controversy looming, I'm saying that it _does_ require a DT Ack. > > > This patch adds device tree binding documentation for > > > the flash cell of the Maxim max77693 multifunctional device. > > > > > > Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> > > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > > > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > > > Cc: Lee Jones <lee.jones@linaro.org> > > > Cc: Chanwoo Choi <cw00.choi@samsung.com> > > > Cc: Bryan Wu <cooloney@gmail.com> > > > Cc: Richard Purdie <rpurdie@rpsys.net> > > Acked-by: Pavel Machek <pavel@ucw.cz> > > > > > diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt > > > index 38e6440..15c546e 100644 > > > --- a/Documentation/devicetree/bindings/mfd/max77693.txt > > > +++ b/Documentation/devicetree/bindings/mfd/max77693.txt > > > @@ -76,7 +76,53 @@ Optional properties: > > > Valid values: 4300000, 4700000, 4800000, 4900000 > > > Default: 4300000 > > > > > > +- led : the LED submodule device node > > > + > > > +There are two LED outputs available - FLED1 and FLED2. Each of them can > > > +control a separate LED or they can be connected together to double > > > +the maximum current for a single connected LED. One LED is represented > > > +by one child node. > > > + > > > +Required properties: > > > +- compatible : Must be "maxim,max77693-led". > > > + > > > +Optional properties: > > > +- maxim,trigger-type : Flash trigger type. > > > + Possible trigger types: > > > + LEDS_TRIG_TYPE_EDGE (0) - Rising edge of the signal triggers > > > + the flash, > > > + LEDS_TRIG_TYPE_LEVEL (1) - Strobe pulse length controls duration > > > + of the flash. > > > +- maxim,boost-mode : > > > + In boost mode the device can produce up to 1.2A of total current > > > + on both outputs. The maximum current on each output is reduced > > > + to 625mA then. If not enabled explicitly, boost setting defaults to > > > + LEDS_BOOST_FIXED in case both current sources are used. > > > + Possible values: > > > + LEDS_BOOST_OFF (0) - no boost, > > > + LEDS_BOOST_ADAPTIVE (1) - adaptive mode, > > > + LEDS_BOOST_FIXED (2) - fixed mode. > > > +- maxim,boost-mvout : Output voltage of the boost module in millivolts. > > > +- maxim,mvsys-min : Low input voltage level in millivolts. Flash is not fired > > > + if chip estimates that system voltage could drop below this level due > > > + to flash power consumption. > > > + > > > +Required properties of the LED child node: > > > +- led-sources : see Documentation/devicetree/bindings/leds/common.txt; > > > + device current output identifiers: 0 - FLED1, 1 - FLED2 > > > + > > > +Optional properties of the LED child node: > > > +- label : see Documentation/devicetree/bindings/leds/common.txt > > > +- max-microamp : see Documentation/devicetree/bindings/leds/common.txt > > > + Range: 15625 - 250000 > > > +- flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt > > > + Range: 15625 - 1000000 > > > +- flash-timeout-us : see Documentation/devicetree/bindings/leds/common.txt > > > + Range: 62500 - 1000000 > > > + > > > Example: > > > +#include <dt-bindings/leds/common.h> > > > + > > > max77693@66 { > > > compatible = "maxim,max77693"; > > > reg = <0x66>; > > > @@ -117,5 +163,20 @@ Example: > > > maxim,thermal-regulation-celsius = <75>; > > > maxim,battery-overcurrent-microamp = <3000000>; > > > maxim,charge-input-threshold-microvolt = <4300000>; > > > + > > > + led { > > > + compatible = "maxim,max77693-led"; > > > + maxim,trigger-type = <LEDS_TRIG_TYPE_LEVEL>; > > > + maxim,boost-mode = <LEDS_BOOST_FIXED>; > > > + maxim,boost-mvout = <5000>; > > > + maxim,mvsys-min = <2400>; > > > + > > > + camera_flash: flash-led { > > > + label = "max77693-flash"; > > > + led-sources = <0>, <1>; > > > + max-microamp = <500000>; > > > + flash-max-microamp = <1250000>; > > > + flash-timeout-us = <1000000>; > > > + }; > > > }; > > > }; > > > > >
On Mon 2015-03-23 15:02:13, Lee Jones wrote: > On Mon, 23 Mar 2015, Pavel Machek wrote: > > On Mon 2015-03-23 12:07:43, Lee Jones wrote: > > > This patch requires a DT Ack. > > > > No, it requires DT people to be notified -- and they were, few times > > by now. > > > > They clearly don't care. > > Well fortunately for the Kernel community, I do care. And as this > patch adds 3 new DT properties, has been through many iterations > already with vast changes made over that period and there is still > some controversy looming, I'm saying that it _does_ require a DT > Ack. Can you help get that ack, then? As a maintainer, you have better chance getting reply from DT people than patch submitter. Pavel
On Mon, 23 Mar 2015, Pavel Machek wrote: > On Mon 2015-03-23 15:02:13, Lee Jones wrote: > > On Mon, 23 Mar 2015, Pavel Machek wrote: > > > On Mon 2015-03-23 12:07:43, Lee Jones wrote: > > > > This patch requires a DT Ack. > > > > > > No, it requires DT people to be notified -- and they were, few times > > > by now. > > > > > > They clearly don't care. > > > > Well fortunately for the Kernel community, I do care. And as this > > patch adds 3 new DT properties, has been through many iterations > > already with vast changes made over that period and there is still > > some controversy looming, I'm saying that it _does_ require a DT > > Ack. > > Can you help get that ack, then? As a maintainer, you have better > chance getting reply from DT people than patch submitter. Hopefully they will see my plea a couple of replies back. If that fails I'll go poke them via other means. Failing that I'll go see them in person and continually hit them with wet fish until one of them relents.
On 23/03/15 16:59, Lee Jones wrote: > On Mon, 23 Mar 2015, Pavel Machek wrote: > >> > On Mon 2015-03-23 15:02:13, Lee Jones wrote: >>> > > On Mon, 23 Mar 2015, Pavel Machek wrote: >>>> > > > On Mon 2015-03-23 12:07:43, Lee Jones wrote: >>>>> > > > > This patch requires a DT Ack. >>>> > > > >>>> > > > No, it requires DT people to be notified -- and they were, few times >>>> > > > by now. >>>> > > > >>>> > > > They clearly don't care. >>> > > >>> > > Well fortunately for the Kernel community, I do care. And as this >>> > > patch adds 3 new DT properties, has been through many iterations >>> > > already with vast changes made over that period and there is still >>> > > some controversy looming, I'm saying that it _does_ require a DT >>> > > Ack. >> > >> > Can you help get that ack, then? As a maintainer, you have better >> > chance getting reply from DT people than patch submitter. > > Hopefully they will see my plea a couple of replies back. > > If that fails I'll go poke them via other means. Failing that I'll go > see them in person and continually hit them with wet fish until one of > them relents. Nice, as we can see it doesn't take _that_ much to be a really good subsystem maintainer. I wish you good luck and hope there will be no need to realize the very last steps of that clever plan.
On Mon 2015-03-23 15:59:37, Lee Jones wrote: > On Mon, 23 Mar 2015, Pavel Machek wrote: > > > On Mon 2015-03-23 15:02:13, Lee Jones wrote: > > > On Mon, 23 Mar 2015, Pavel Machek wrote: > > > > On Mon 2015-03-23 12:07:43, Lee Jones wrote: > > > > > This patch requires a DT Ack. > > > > > > > > No, it requires DT people to be notified -- and they were, few times > > > > by now. > > > > > > > > They clearly don't care. > > > > > > Well fortunately for the Kernel community, I do care. And as this > > > patch adds 3 new DT properties, has been through many iterations > > > already with vast changes made over that period and there is still > > > some controversy looming, I'm saying that it _does_ require a DT > > > Ack. > > > > Can you help get that ack, then? As a maintainer, you have better > > chance getting reply from DT people than patch submitter. > > Hopefully they will see my plea a couple of replies back. > > If that fails I'll go poke them via other means. Failing that I'll go > see them in person and continually hit them with wet fish until one of > them relents. Can I request footage of the last steps on the youtube? (IOW ping, I don't think I seen any replies from DT maintainers...) Pavel
On Thu, 02 Apr 2015, Pavel Machek wrote: > On Mon 2015-03-23 15:59:37, Lee Jones wrote: > > On Mon, 23 Mar 2015, Pavel Machek wrote: > > > > > On Mon 2015-03-23 15:02:13, Lee Jones wrote: > > > > On Mon, 23 Mar 2015, Pavel Machek wrote: > > > > > On Mon 2015-03-23 12:07:43, Lee Jones wrote: > > > > > > This patch requires a DT Ack. > > > > > > > > > > No, it requires DT people to be notified -- and they were, few times > > > > > by now. > > > > > > > > > > They clearly don't care. > > > > > > > > Well fortunately for the Kernel community, I do care. And as this > > > > patch adds 3 new DT properties, has been through many iterations > > > > already with vast changes made over that period and there is still > > > > some controversy looming, I'm saying that it _does_ require a DT > > > > Ack. > > > > > > Can you help get that ack, then? As a maintainer, you have better > > > chance getting reply from DT people than patch submitter. > > > > Hopefully they will see my plea a couple of replies back. > > > > If that fails I'll go poke them via other means. Failing that I'll go > > see them in person and continually hit them with wet fish until one of > > them relents. > > Can I request footage of the last steps on the youtube? Too late, it's been and gone. > (IOW ping, I don't think I seen any replies from DT maintainers...) Then you haven't been looking the right place [1]. ;) [1] http://comments.gmane.org/gmane.linux.leds/2245
diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt index 38e6440..15c546e 100644 --- a/Documentation/devicetree/bindings/mfd/max77693.txt +++ b/Documentation/devicetree/bindings/mfd/max77693.txt @@ -76,7 +76,53 @@ Optional properties: Valid values: 4300000, 4700000, 4800000, 4900000 Default: 4300000 +- led : the LED submodule device node + +There are two LED outputs available - FLED1 and FLED2. Each of them can +control a separate LED or they can be connected together to double +the maximum current for a single connected LED. One LED is represented +by one child node. + +Required properties: +- compatible : Must be "maxim,max77693-led". + +Optional properties: +- maxim,trigger-type : Flash trigger type. + Possible trigger types: + LEDS_TRIG_TYPE_EDGE (0) - Rising edge of the signal triggers + the flash, + LEDS_TRIG_TYPE_LEVEL (1) - Strobe pulse length controls duration + of the flash. +- maxim,boost-mode : + In boost mode the device can produce up to 1.2A of total current + on both outputs. The maximum current on each output is reduced + to 625mA then. If not enabled explicitly, boost setting defaults to + LEDS_BOOST_FIXED in case both current sources are used. + Possible values: + LEDS_BOOST_OFF (0) - no boost, + LEDS_BOOST_ADAPTIVE (1) - adaptive mode, + LEDS_BOOST_FIXED (2) - fixed mode. +- maxim,boost-mvout : Output voltage of the boost module in millivolts. +- maxim,mvsys-min : Low input voltage level in millivolts. Flash is not fired + if chip estimates that system voltage could drop below this level due + to flash power consumption. + +Required properties of the LED child node: +- led-sources : see Documentation/devicetree/bindings/leds/common.txt; + device current output identifiers: 0 - FLED1, 1 - FLED2 + +Optional properties of the LED child node: +- label : see Documentation/devicetree/bindings/leds/common.txt +- max-microamp : see Documentation/devicetree/bindings/leds/common.txt + Range: 15625 - 250000 +- flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt + Range: 15625 - 1000000 +- flash-timeout-us : see Documentation/devicetree/bindings/leds/common.txt + Range: 62500 - 1000000 + Example: +#include <dt-bindings/leds/common.h> + max77693@66 { compatible = "maxim,max77693"; reg = <0x66>; @@ -117,5 +163,20 @@ Example: maxim,thermal-regulation-celsius = <75>; maxim,battery-overcurrent-microamp = <3000000>; maxim,charge-input-threshold-microvolt = <4300000>; + + led { + compatible = "maxim,max77693-led"; + maxim,trigger-type = <LEDS_TRIG_TYPE_LEVEL>; + maxim,boost-mode = <LEDS_BOOST_FIXED>; + maxim,boost-mvout = <5000>; + maxim,mvsys-min = <2400>; + + camera_flash: flash-led { + label = "max77693-flash"; + led-sources = <0>, <1>; + max-microamp = <500000>; + flash-max-microamp = <1250000>; + flash-timeout-us = <1000000>; + }; }; };