diff mbox

[PATCH/RFC,v12,04/19] dt-binding: leds: Add common LED DT bindings macros

Message ID 1425485680-8417-5-git-send-email-j.anaszewski@samsung.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Jacek Anaszewski March 4, 2015, 4:14 p.m. UTC 
  Add macros for defining boost mode and trigger type properties
of flash LED devices.

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Bryan Wu <cooloney@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
 include/dt-bindings/leds/max77693.h |   21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 include/dt-bindings/leds/max77693.h

Comments

Jacek Anaszewski March 5, 2015, 7:56 a.m. UTC | #1 
On 03/04/2015 05:14 PM, Jacek Anaszewski wrote:
> Add macros for defining boost mode and trigger type properties
> of flash LED devices.
>
> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> ---
>   include/dt-bindings/leds/max77693.h |   21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
>   create mode 100644 include/dt-bindings/leds/max77693.h

This should be obviously include/dt-bindings/leds/common.h.
It will affect also max77693-led bindings documentation patch.
I'll send the update after receiving review remarks related to the
remaining part of the mentioned patches.

>
> diff --git a/include/dt-bindings/leds/max77693.h b/include/dt-bindings/leds/max77693.h
> new file mode 100644
> index 0000000..79fcef7
> --- /dev/null
> +++ b/include/dt-bindings/leds/max77693.h
> @@ -0,0 +1,21 @@
> +/*
> + * This header provides macros for the common LEDs device tree bindings.
> + *
> + * Copyright (C) 2015, Samsung Electronics Co., Ltd.
> + *
> + * Author: Jacek Anaszewski <j.anaszewski@samsung.com>
> + */
> +
> +#ifndef __DT_BINDINGS_LEDS_H__
> +#define __DT_BINDINGS_LEDS_H
> +
> +/* External trigger type */
> +#define LEDS_TRIG_TYPE_EDGE	0
> +#define LEDS_TRIG_TYPE_LEVEL	1
> +
> +/* Boost modes */
> +#define LEDS_BOOST_OFF		0
> +#define LEDS_BOOST_ADAPTIVE	1
> +#define LEDS_BOOST_FIXED	2
> +
> +#endif /* __DT_BINDINGS_LEDS_H */
>
Bryan Wu March 10, 2015, 12:33 a.m. UTC | #2 
On Wed, Mar 4, 2015 at 11:56 PM, Jacek Anaszewski
<j.anaszewski@samsung.com> wrote:
> On 03/04/2015 05:14 PM, Jacek Anaszewski wrote:
>>
>> Add macros for defining boost mode and trigger type properties
>> of flash LED devices.
>>
>> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>> Cc: Bryan Wu <cooloney@gmail.com>
>> Cc: Richard Purdie <rpurdie@rpsys.net>
>> ---
>>   include/dt-bindings/leds/max77693.h |   21 +++++++++++++++++++++
>>   1 file changed, 21 insertions(+)
>>   create mode 100644 include/dt-bindings/leds/max77693.h
>
>
> This should be obviously include/dt-bindings/leds/common.h.
> It will affect also max77693-led bindings documentation patch.
> I'll send the update after receiving review remarks related to the
> remaining part of the mentioned patches.
>

OK, please update them then I will merge this patch.

Thanks,
-Bryan

>
>>
>> diff --git a/include/dt-bindings/leds/max77693.h
>> b/include/dt-bindings/leds/max77693.h
>> new file mode 100644
>> index 0000000..79fcef7
>> --- /dev/null
>> +++ b/include/dt-bindings/leds/max77693.h
>> @@ -0,0 +1,21 @@
>> +/*
>> + * This header provides macros for the common LEDs device tree bindings.
>> + *
>> + * Copyright (C) 2015, Samsung Electronics Co., Ltd.
>> + *
>> + * Author: Jacek Anaszewski <j.anaszewski@samsung.com>
>> + */
>> +
>> +#ifndef __DT_BINDINGS_LEDS_H__
>> +#define __DT_BINDINGS_LEDS_H
>> +
>> +/* External trigger type */
>> +#define LEDS_TRIG_TYPE_EDGE    0
>> +#define LEDS_TRIG_TYPE_LEVEL   1
>> +
>> +/* Boost modes */
>> +#define LEDS_BOOST_OFF         0
>> +#define LEDS_BOOST_ADAPTIVE    1
>> +#define LEDS_BOOST_FIXED       2
>> +
>> +#endif /* __DT_BINDINGS_LEDS_H */
>>
>
>
> --
> Best Regards,
> Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/dt-bindings/leds/max77693.h b/include/dt-bindings/leds/max77693.h
new file mode 100644
index 0000000..79fcef7
--- /dev/null
+++ b/include/dt-bindings/leds/max77693.h
@@ -0,0 +1,21 @@ 
+/*
+ * This header provides macros for the common LEDs device tree bindings.
+ *
+ * Copyright (C) 2015, Samsung Electronics Co., Ltd.
+ *
+ * Author: Jacek Anaszewski <j.anaszewski@samsung.com>
+ */
+
+#ifndef __DT_BINDINGS_LEDS_H__
+#define __DT_BINDINGS_LEDS_H
+
+/* External trigger type */
+#define LEDS_TRIG_TYPE_EDGE	0
+#define LEDS_TRIG_TYPE_LEVEL	1
+
+/* Boost modes */
+#define LEDS_BOOST_OFF		0
+#define LEDS_BOOST_ADAPTIVE	1
+#define LEDS_BOOST_FIXED	2
+
+#endif /* __DT_BINDINGS_LEDS_H */