[GIT,PULL,3.19] si2168 fix
Message ID | 54C0CCEF.8080500@iki.fi (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1YEEkB-00071I-V7; Thu, 22 Jan 2015 11:12:07 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1YEEk9-0007w9-mF; Thu, 22 Jan 2015 11:12:07 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533AbbAVKMD (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 22 Jan 2015 05:12:03 -0500 Received: from mail.kapsi.fi ([217.30.184.167]:56121 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbbAVKMB (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 22 Jan 2015 05:12:01 -0500 Received: from [82.128.187.65] (helo=localhost.localdomain) by mail.kapsi.fi with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from <crope@iki.fi>) id 1YEEk3-0007VM-Qx for linux-media@vger.kernel.org; Thu, 22 Jan 2015 12:11:59 +0200 Message-ID: <54C0CCEF.8080500@iki.fi> Date: Thu, 22 Jan 2015 12:11:59 +0200 From: Antti Palosaari <crope@iki.fi> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: LMML <linux-media@vger.kernel.org> Subject: [GIT PULL 3.19] si2168 fix Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 82.128.187.65 X-SA-Exim-Mail-From: crope@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.1.22.100026 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MOZILLA_USER_AGENT 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' |
Pull-request
git://linuxtv.org/anttip/media_tree.git si2168_fixMessage
Antti Palosaari
Jan. 22, 2015, 10:11 a.m. UTC
That patch must go also stable v3.16+ as tagged Cc. regards Antti The following changes since commit 2c0108e1c02f9fc95f465adc4d2ce1ad8688290a: [media] omap3isp: Correctly set QUERYCAP capabilities (2015-01-21 21:09:11 -0200) are available in the git repository at: git://linuxtv.org/anttip/media_tree.git si2168_fix for you to fetch changes up to a85385413c60602b529a1555146c4e81a5935e98: si2168: increase timeout to fix firmware loading (2015-01-22 12:06:20 +0200) ---------------------------------------------------------------- Jurgen Kramer (1): si2168: increase timeout to fix firmware loading drivers/media/dvb-frontends/si2168.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Mauro Did that patch went to stable? I see you have committed original patch from patchwork, but there is no stable tag. On 01/22/2015 12:11 PM, Antti Palosaari wrote: > That patch must go also stable v3.16+ as tagged Cc. > > regards > Antti > > The following changes since commit > 2c0108e1c02f9fc95f465adc4d2ce1ad8688290a: > > [media] omap3isp: Correctly set QUERYCAP capabilities (2015-01-21 > 21:09:11 -0200) > > are available in the git repository at: > > git://linuxtv.org/anttip/media_tree.git si2168_fix > > for you to fetch changes up to a85385413c60602b529a1555146c4e81a5935e98: > > si2168: increase timeout to fix firmware loading (2015-01-22 12:06:20 > +0200) > > ---------------------------------------------------------------- > Jurgen Kramer (1): > si2168: increase timeout to fix firmware loading > > drivers/media/dvb-frontends/si2168.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > https://patchwork.linuxtv.org/patch/27382/ commit 551c33e729f654ecfaed00ad399f5d2a631b72cb Author: Jurgen Kramer <gtmkramer@xs4all.nl> Date: Mon Dec 8 05:30:44 2014 -0300 [media] Si2168: increase timeout to fix firmware loading Increase si2168 cmd execute timeout to prevent firmware load failures. Tests shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware. Increase timeout to a safe value of 70ms. Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl> Reviewed-by: Antti Palosaari <crope@iki.fi> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> Antti
Em Fri, 20 Feb 2015 02:47:44 +0200 Antti Palosaari <crope@iki.fi> escreveu: > Mauro > Did that patch went to stable? I see you have committed original patch > from patchwork, but there is no stable tag. It went upstream, but I'm unsure if it arrived for 3.19 or 3.20. That's the upstream changeset: $ git show 551c33e729f6 commit 551c33e729f654ecfaed00ad399f5d2a631b72cb Author: Jurgen Kramer <gtmkramer@xs4all.nl> Date: Mon Dec 8 05:30:44 2014 -0300 [media] Si2168: increase timeout to fix firmware loading Increase si2168 cmd execute timeout to prevent firmware load failures. Tests shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware. Increase timeout to a safe value of 70ms. Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl> Reviewed-by: Antti Palosaari <crope@iki.fi> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> Weird, it is missing the Cc tag on its commit message. I double-checked re-applying it on a scratch branch: my scripts are properly recognizing the Cc tag. I've no idea what happened. Perhaps you've added this patch on some other branch that you asked me to pull? Anyway, now the proper solution is to send this patch directly to stable@vger.kernel.org, C/C the mailing list. Regards, Mauro > > > On 01/22/2015 12:11 PM, Antti Palosaari wrote: > > That patch must go also stable v3.16+ as tagged Cc. > > > > regards > > Antti > > > > The following changes since commit > > 2c0108e1c02f9fc95f465adc4d2ce1ad8688290a: > > > > [media] omap3isp: Correctly set QUERYCAP capabilities (2015-01-21 > > 21:09:11 -0200) > > > > are available in the git repository at: > > > > git://linuxtv.org/anttip/media_tree.git si2168_fix > > > > for you to fetch changes up to a85385413c60602b529a1555146c4e81a5935e98: > > > > si2168: increase timeout to fix firmware loading (2015-01-22 12:06:20 > > +0200) > > > > ---------------------------------------------------------------- > > Jurgen Kramer (1): > > si2168: increase timeout to fix firmware loading > > > > drivers/media/dvb-frontends/si2168.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > https://patchwork.linuxtv.org/patch/27382/ > > > > commit 551c33e729f654ecfaed00ad399f5d2a631b72cb > Author: Jurgen Kramer <gtmkramer@xs4all.nl> > Date: Mon Dec 8 05:30:44 2014 -0300 > > [media] Si2168: increase timeout to fix firmware loading > > Increase si2168 cmd execute timeout to prevent firmware load > failures. Tests > shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' > firmware. > Increase timeout to a safe value of 70ms. > > Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl> > Reviewed-by: Antti Palosaari <crope@iki.fi> > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > > Antti > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/20/2015 03:36 AM, Mauro Carvalho Chehab wrote: > Em Fri, 20 Feb 2015 02:47:44 +0200 > Antti Palosaari <crope@iki.fi> escreveu: > >> Mauro >> Did that patch went to stable? I see you have committed original patch >> from patchwork, but there is no stable tag. > > It went upstream, but I'm unsure if it arrived for 3.19 or 3.20. > > That's the upstream changeset: > > $ git show 551c33e729f6 > commit 551c33e729f654ecfaed00ad399f5d2a631b72cb > Author: Jurgen Kramer <gtmkramer@xs4all.nl> > Date: Mon Dec 8 05:30:44 2014 -0300 > > [media] Si2168: increase timeout to fix firmware loading > > Increase si2168 cmd execute timeout to prevent firmware load failures. Tests > shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware. > Increase timeout to a safe value of 70ms. > > Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl> > Reviewed-by: Antti Palosaari <crope@iki.fi> > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > > Weird, it is missing the Cc tag on its commit message. I double-checked > re-applying it on a scratch branch: my scripts are properly recognizing > the Cc tag. > > I've no idea what happened. Perhaps you've added this patch on some other > branch that you asked me to pull? > > Anyway, now the proper solution is to send this patch directly to > stable@vger.kernel.org, C/C the mailing list. I added proper stable tag to patchwork and then waited looong time you pick it from patchwork. After a month or so, I picked whole patch from patchwork to my tree, yet again added proper stable tags and made PULL-request. So there is stable tag on both patchwork and PULL-request. You applied patchwork - but without stable tag.... So I am very surprised to see original patch applied to master, but without stable tag. Si2168: increase timeout to fix firmware loading https://patchwork.linuxtv.org/patch/27382/ [GIT PULL 3.19] si2168 fix http://www.spinics.net/lists/linux-media/msg85713.html Antti > > Regards, > Mauro > >> >> >> On 01/22/2015 12:11 PM, Antti Palosaari wrote: >>> That patch must go also stable v3.16+ as tagged Cc. >>> >>> regards >>> Antti >>> >>> The following changes since commit >>> 2c0108e1c02f9fc95f465adc4d2ce1ad8688290a: >>> >>> [media] omap3isp: Correctly set QUERYCAP capabilities (2015-01-21 >>> 21:09:11 -0200) >>> >>> are available in the git repository at: >>> >>> git://linuxtv.org/anttip/media_tree.git si2168_fix >>> >>> for you to fetch changes up to a85385413c60602b529a1555146c4e81a5935e98: >>> >>> si2168: increase timeout to fix firmware loading (2015-01-22 12:06:20 >>> +0200) >>> >>> ---------------------------------------------------------------- >>> Jurgen Kramer (1): >>> si2168: increase timeout to fix firmware loading >>> >>> drivers/media/dvb-frontends/si2168.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >> >> >> https://patchwork.linuxtv.org/patch/27382/ >> >> >> >> commit 551c33e729f654ecfaed00ad399f5d2a631b72cb >> Author: Jurgen Kramer <gtmkramer@xs4all.nl> >> Date: Mon Dec 8 05:30:44 2014 -0300 >> >> [media] Si2168: increase timeout to fix firmware loading >> >> Increase si2168 cmd execute timeout to prevent firmware load >> failures. Tests >> shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' >> firmware. >> Increase timeout to a safe value of 70ms. >> >> Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl> >> Reviewed-by: Antti Palosaari <crope@iki.fi> >> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> >> >> Antti >> >> >> >> >>
Em Fri, 20 Feb 2015 03:44:28 +0200 Antti Palosaari <crope@iki.fi> escreveu: > On 02/20/2015 03:36 AM, Mauro Carvalho Chehab wrote: > > Em Fri, 20 Feb 2015 02:47:44 +0200 > > Antti Palosaari <crope@iki.fi> escreveu: > > > >> Mauro > >> Did that patch went to stable? I see you have committed original patch > >> from patchwork, but there is no stable tag. > > > > It went upstream, but I'm unsure if it arrived for 3.19 or 3.20. > > > > That's the upstream changeset: > > > > $ git show 551c33e729f6 > > commit 551c33e729f654ecfaed00ad399f5d2a631b72cb > > Author: Jurgen Kramer <gtmkramer@xs4all.nl> > > Date: Mon Dec 8 05:30:44 2014 -0300 > > > > [media] Si2168: increase timeout to fix firmware loading > > > > Increase si2168 cmd execute timeout to prevent firmware load failures. Tests > > shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware. > > Increase timeout to a safe value of 70ms. > > > > Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl> > > Reviewed-by: Antti Palosaari <crope@iki.fi> > > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > > > > Weird, it is missing the Cc tag on its commit message. I double-checked > > re-applying it on a scratch branch: my scripts are properly recognizing > > the Cc tag. > > > > I've no idea what happened. Perhaps you've added this patch on some other > > branch that you asked me to pull? > > > > Anyway, now the proper solution is to send this patch directly to > > stable@vger.kernel.org, C/C the mailing list. > > I added proper stable tag to patchwork and then waited looong time you > pick it from patchwork. After a month or so, I picked whole patch from > patchwork to my tree, yet again added proper stable tags and made > PULL-request. So there is stable tag on both patchwork and PULL-request. > You applied patchwork - but without stable tag.... > > So I am very surprised to see original patch applied to master, but > without stable tag. > > Si2168: increase timeout to fix firmware loading > https://patchwork.linuxtv.org/patch/27382/ > > [GIT PULL 3.19] si2168 fix > http://www.spinics.net/lists/linux-media/msg85713.html Ah, I know what happened: you replied with "Reviewed-by:" on 2014-12-08, but you sent the pull request only in 2015-01-22. The "Accepted" state for the #27382 patch indicates that I picked the version that was at patchwork, instead of the one from your pull request, because I saw that you've replied with a reviewed-by tag. Unfortunately, patchwork doesn't consider "Cc:" as a tag to honor, nor it brings the full history of the replies on its pwclient interface. So, I didn't notice the Cc: on your reply. Next time, if you intend to send the patch on a separate pull request, please don't reply with a "reviewed-by:" tag, as I my understanding when I see acked-by/reviewed-by from a driver maintainer is that he won't be sending me a pull request about that specific patch. When I have time, I sometimes double check, but, as I was just arriving from vacations in the end of January, I had a very long backlog to handle. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html