diff mbox

[v2] rtl2832: remove compiler warning

Message ID 20150211110851.GA30505@biggie (mailing list archive)
State Accepted, archived
Headers

Commit Message

Luis de Bethencourt Feb. 11, 2015, 11:08 a.m. UTC 
  Cleaning up the following compiler warning:
rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function

Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
tmp, this line would never run because we go to err. It is still nice to avoid
compiler warnings.

Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
---
 drivers/media/dvb-frontends/rtl2832.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Antti Palosaari Feb. 11, 2015, 1:07 p.m. UTC | #1 
On 02/11/2015 01:08 PM, Luis de Bethencourt wrote:
> Cleaning up the following compiler warning:
> rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
>
> Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
> tmp, this line would never run because we go to err. It is still nice to avoid
> compiler warnings.
>
> Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>


Reviewed-by: Antti Palosaari <crope@iki.fi>

Antti

> ---
>   drivers/media/dvb-frontends/rtl2832.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
> index 5d2d8f4..20fa245 100644
> --- a/drivers/media/dvb-frontends/rtl2832.c
> +++ b/drivers/media/dvb-frontends/rtl2832.c
> @@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
>   	struct rtl2832_dev *dev = fe->demodulator_priv;
>   	struct i2c_client *client = dev->client;
>   	int ret;
> -	u32 tmp;
> +	u32 uninitialized_var(tmp);
>
>   	dev_dbg(&client->dev, "\n");
>
>
Luis de Bethencourt Feb. 15, 2015, 10:46 p.m. UTC | #2 
On Wed, Feb 11, 2015 at 11:08:51AM +0000, Luis de Bethencourt wrote:
> Cleaning up the following compiler warning:
> rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
> 
> Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
> tmp, this line would never run because we go to err. It is still nice to avoid
> compiler warnings.
> 
> Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
> ---
>  drivers/media/dvb-frontends/rtl2832.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
> index 5d2d8f4..20fa245 100644
> --- a/drivers/media/dvb-frontends/rtl2832.c
> +++ b/drivers/media/dvb-frontends/rtl2832.c
> @@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
>  	struct rtl2832_dev *dev = fe->demodulator_priv;
>  	struct i2c_client *client = dev->client;
>  	int ret;
> -	u32 tmp;
> +	u32 uninitialized_var(tmp);
>  
>  	dev_dbg(&client->dev, "\n");
>  
> -- 
> 2.1.3
> 

Hi Mauro,

The warning is still happening. Just a reminder in case you want to apply this
patch.

Thanks,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
index 5d2d8f4..20fa245 100644
--- a/drivers/media/dvb-frontends/rtl2832.c
+++ b/drivers/media/dvb-frontends/rtl2832.c
@@ -685,7 +685,7 @@  static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
 	struct rtl2832_dev *dev = fe->demodulator_priv;
 	struct i2c_client *client = dev->client;
 	int ret;
-	u32 tmp;
+	u32 uninitialized_var(tmp);
 
 	dev_dbg(&client->dev, "\n");