Message ID | 1418651737-10016-1-git-send-email-geert@linux-m68k.org (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Hans Verkuil |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1Y0W7v-0006fX-Rs; Mon, 15 Dec 2014 14:55:55 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1Y0W7s-0006pm-l5; Mon, 15 Dec 2014 14:55:54 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751347AbaLONzh (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 15 Dec 2014 08:55:37 -0500 Received: from laurent.telenet-ops.be ([195.130.137.89]:58391 "EHLO laurent.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbaLONzh (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 15 Dec 2014 08:55:37 -0500 Received: from ayla.of.borg ([84.193.93.87]) by laurent.telenet-ops.be with bizsmtp id Tpva1p0151t5w8s01pvaYP; Mon, 15 Dec 2014 14:55:35 +0100 Received: from ramsan.of.borg ([192.168.97.29] helo=ramsan) by ayla.of.borg with esmtp (Exim 4.82) (envelope-from <geert@linux-m68k.org>) id 1Y0W7a-0006Q7-LW; Mon, 15 Dec 2014 14:55:34 +0100 Received: from geert by ramsan with local (Exim 4.82) (envelope-from <geert@linux-m68k.org>) id 1Y0W7e-0002cE-A7; Mon, 15 Dec 2014 14:55:38 +0100 From: Geert Uytterhoeven <geert@linux-m68k.org> To: Jonathan Corbet <corbet@lwn.net>, Mauro Carvalho Chehab <mchehab@osg.samsung.com> Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org> Subject: [PATCH/RESEND] [media] VIDEO_CAFE_CCIC should select VIDEOBUF2_DMA_SG Date: Mon, 15 Dec 2014 14:55:37 +0100 Message-Id: <1418651737-10016-1-git-send-email-geert@linux-m68k.org> X-Mailer: git-send-email 1.9.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.12.15.134819 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1300_1399 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Geert Uytterhoeven
Dec. 15, 2014, 1:55 p.m. UTC
If VIDEO_CAFE_CCIC=y, but VIDEOBUF2_DMA_SG=m:
drivers/built-in.o: In function `mcam_v4l_open':
mcam-core.c:(.text+0x1c2e81): undefined reference to `vb2_dma_sg_memops'
mcam-core.c:(.text+0x1c2eb0): undefined reference to `vb2_dma_sg_init_ctx'
drivers/built-in.o: In function `mcam_v4l_release':
mcam-core.c:(.text+0x1c34bf): undefined reference to `vb2_dma_sg_cleanup_ctx'
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
This is a resend of a patch from 2013-09-30. It's still valid.
drivers/media/platform/marvell-ccic/Kconfig | 1 +
1 file changed, 1 insertion(+)
Comments
On Mon, 15 Dec 2014 14:55:37 +0100 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > If VIDEO_CAFE_CCIC=y, but VIDEOBUF2_DMA_SG=m: > > drivers/built-in.o: In function `mcam_v4l_open': > mcam-core.c:(.text+0x1c2e81): undefined reference to `vb2_dma_sg_memops' > mcam-core.c:(.text+0x1c2eb0): undefined reference to `vb2_dma_sg_init_ctx' > drivers/built-in.o: In function `mcam_v4l_release': > mcam-core.c:(.text+0x1c34bf): undefined reference to `vb2_dma_sg_cleanup_ctx' I've been mildly resistant to this because I've never figured out how such a configuration can come about. The Cafe chip only appeared in the OLPC XO-1 and cannot even come close to doing S/G I/O. So this patch robs a bit of memory for no use on a platform that can ill afford it. OTOH, the number of people building contemporary kernels for the XO-1 has got to be pretty small. So, in the interest of mollifying randconfig users out there, you can add my: Acked-by: Jonathan Corbet <corbet@lwn.net> jon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jon, On Mon, Dec 15, 2014 at 3:04 PM, Jonathan Corbet <corbet@lwn.net> wrote: > On Mon, 15 Dec 2014 14:55:37 +0100 > Geert Uytterhoeven <geert@linux-m68k.org> wrote: > >> If VIDEO_CAFE_CCIC=y, but VIDEOBUF2_DMA_SG=m: >> >> drivers/built-in.o: In function `mcam_v4l_open': >> mcam-core.c:(.text+0x1c2e81): undefined reference to `vb2_dma_sg_memops' >> mcam-core.c:(.text+0x1c2eb0): undefined reference to `vb2_dma_sg_init_ctx' >> drivers/built-in.o: In function `mcam_v4l_release': >> mcam-core.c:(.text+0x1c34bf): undefined reference to `vb2_dma_sg_cleanup_ctx' > > I've been mildly resistant to this because I've never figured out how > such a configuration can come about. The Cafe chip only appeared in the > OLPC XO-1 and cannot even come close to doing S/G I/O. So this patch > robs a bit of memory for no use on a platform that can ill afford it. If the driver cannot do SG, perhaps this block should be removed from drivers/media/platform/marvell-ccic/mcam-core.h? #if IS_ENABLED(CONFIG_VIDEOBUF2_DMA_SG) #define MCAM_MODE_DMA_SG 1 #endif Oh, this seems to be a reason for the breakage, too: IS_ENABLED() evaluates to true for modular options... > OTOH, the number of people building contemporary kernels for the XO-1 has > got to be pretty small. So, in the interest of mollifying randconfig > users out there, you can add my: > > Acked-by: Jonathan Corbet <corbet@lwn.net> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 15 Dec 2014 15:10:38 +0100 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > If the driver cannot do SG, perhaps this block should be removed from > drivers/media/platform/marvell-ccic/mcam-core.h? > > #if IS_ENABLED(CONFIG_VIDEOBUF2_DMA_SG) > #define MCAM_MODE_DMA_SG 1 > #endif Other drivers using the Marvell core can do S/G, though, so that option needs to remain. Applying your patch is almost certainly the most straightforward solution at this point. Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/marvell-ccic/Kconfig b/drivers/media/platform/marvell-ccic/Kconfig index 6265d36adcebcb89..3d166568bd6955bd 100644 --- a/drivers/media/platform/marvell-ccic/Kconfig +++ b/drivers/media/platform/marvell-ccic/Kconfig @@ -5,6 +5,7 @@ config VIDEO_CAFE_CCIC select VIDEO_OV7670 select VIDEOBUF2_VMALLOC select VIDEOBUF2_DMA_CONTIG + select VIDEOBUF2_DMA_SG ---help--- This is a video4linux2 driver for the Marvell 88ALP01 integrated CMOS camera controller. This is the controller found on first-