Message ID | 1414325129-16570-1-git-send-email-tskd08@gmail.com (mailing list archive) |
---|---|
State | Changes Requested, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1XiMZs-00023u-5V; Sun, 26 Oct 2014 13:05:44 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1XiMZq-0000yi-7q; Sun, 26 Oct 2014 13:05:44 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751627AbaJZMFk (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Sun, 26 Oct 2014 08:05:40 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:64349 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbaJZMFk (ORCPT <rfc822;linux-media@vger.kernel.org>); Sun, 26 Oct 2014 08:05:40 -0400 Received: by mail-pa0-f42.google.com with SMTP id bj1so162577pad.15 for <linux-media@vger.kernel.org>; Sun, 26 Oct 2014 05:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=61bWpC76OCbqPyjoNNng8bdvepIv6lgKtkrzQw3PM7M=; b=lIN6+TD1r0GWqiVOlgJixkDouzP0TgLaNBvDNUwTRqsEL/BORUukHqv7qnwCpma9Lb aVfwRxLIpPkkHcj9CIsURvBLxDwjVamQtNCyis9cBAT0RLQPKIe+wrsjYr2EkGUcakhu wpArU8qLzLPu58sMskjOg0TTY//zJGvyryyYVzckTZyYNZx2FnDzU7Sh9BtMLbYJO2Ml IxPrpgF96KKM213B4oExJvPMKx0udx2oio/vPNrJr7Pna6DLn4/OWG0Tj8HZf6lT3qBm 250pqOb0llL5sJAFNQCF+xYkGf+G07mLkC0n9TZ4oSGFw6QaHaUWK4p5A8jsnMTKsteR uUuw== X-Received: by 10.68.69.76 with SMTP id c12mr16885078pbu.59.1414325139614; Sun, 26 Oct 2014 05:05:39 -0700 (PDT) Received: from seabird.localdomain.localdomain (softbank219203027033.bbtec.net. [219.203.27.33]) by mx.google.com with ESMTPSA id ra4sm8299410pab.33.2014.10.26.05.05.37 for <multiple recipients> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 26 Oct 2014 05:05:38 -0700 (PDT) From: tskd08@gmail.com To: linux-media@vger.kernel.org Cc: m.chehab@samsung.com, Akihiro Tsukada <tskd08@gmail.com> Subject: [PATCH] dvb:tc90522: bugfix of always-false expression Date: Sun, 26 Oct 2014 21:05:29 +0900 Message-Id: <1414325129-16570-1-git-send-email-tskd08@gmail.com> X-Mailer: git-send-email 2.1.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.10.26.115720 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_800_899 0, DKIM_SIGNATURE 0, NO_REAL_NAME 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Akihiro TSUKADA
Oct. 26, 2014, 12:05 p.m. UTC
From: Akihiro Tsukada <tskd08@gmail.com>
Reported by David Binderman
---
drivers/media/dvb-frontends/tc90522.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 10/26/2014 02:05 PM, tskd08@gmail.com wrote: > From: Akihiro Tsukada <tskd08@gmail.com> > > Reported by David Binderman ^^ See Documentation/SubmittingPatches Antti > --- > drivers/media/dvb-frontends/tc90522.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-frontends/tc90522.c b/drivers/media/dvb-frontends/tc90522.c > index d9905fb..bca81ef 100644 > --- a/drivers/media/dvb-frontends/tc90522.c > +++ b/drivers/media/dvb-frontends/tc90522.c > @@ -363,7 +363,7 @@ static int tc90522t_get_frontend(struct dvb_frontend *fe) > u8 v; > > c->isdbt_partial_reception = val[0] & 0x01; > - c->isdbt_sb_mode = (val[0] & 0xc0) == 0x01; > + c->isdbt_sb_mode = (val[0] & 0xc0) == 0x40; > > /* layer A */ > v = (val[2] & 0x78) >> 3; >
>> Reported by David Binderman > > ^^ See Documentation/SubmittingPatches Though I knew that Reported-by: tag should not be used, I wrote it just to express my appreciation for his report, and did not mean to attach the tag. But I admit that it is confusing, so I'd like to beg Mauro to do me the kindness to delete the line when this patch is committed. (or I'll re-send the patch if it is necessary.) regards, akihiro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/26/2014 03:58 PM, Akihiro TSUKADA wrote: >>> Reported by David Binderman >> >> ^^ See Documentation/SubmittingPatches > > Though I knew that Reported-by: tag should not be used, > I wrote it just to express my appreciation for his report, > and did not mean to attach the tag. > But I admit that it is confusing, > so I'd like to beg Mauro to do me the kindness > to delete the line when this patch is committed. > (or I'll re-send the patch if it is necessary.) Main reason I picked it up, was that tag was formally bad. regards Antti
Em Sun, 26 Oct 2014 18:27:28 +0200 Antti Palosaari <crope@iki.fi> escreveu: > > > On 10/26/2014 03:58 PM, Akihiro TSUKADA wrote: > >>> Reported by David Binderman > >> > >> ^^ See Documentation/SubmittingPatches > > > > Though I knew that Reported-by: tag should not be used, > > I wrote it just to express my appreciation for his report, > > and did not mean to attach the tag. > > But I admit that it is confusing, > > so I'd like to beg Mauro to do me the kindness > > to delete the line when this patch is committed. > > (or I'll re-send the patch if it is necessary.) > > Main reason I picked it up, was that tag was formally bad. Yeah, the tag should be Reported-by: and should have the email of the person who reported the issue. But that's not the only thing you forgot... there's no SOB on this patch ;) Please resend. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
I already posted v2 to this ML, but it was at top-level, not in-reply-to this thread. Sorry for the confusing posts. v2 of this patch: https://patchwork.linuxtv.org/patch/26652/ and the other two patches https://patchwork.linuxtv.org/patch/26651/ https://patchwork.linuxtv.org/patch/26653/ regards, Akihiro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/dvb-frontends/tc90522.c b/drivers/media/dvb-frontends/tc90522.c index d9905fb..bca81ef 100644 --- a/drivers/media/dvb-frontends/tc90522.c +++ b/drivers/media/dvb-frontends/tc90522.c @@ -363,7 +363,7 @@ static int tc90522t_get_frontend(struct dvb_frontend *fe) u8 v; c->isdbt_partial_reception = val[0] & 0x01; - c->isdbt_sb_mode = (val[0] & 0xc0) == 0x01; + c->isdbt_sb_mode = (val[0] & 0xc0) == 0x40; /* layer A */ v = (val[2] & 0x78) >> 3;