| Message ID | 1414709035-7729-1-git-send-email-zzam@gentoo.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1XjyS6-00071Z-Sq; Thu, 30 Oct 2014 23:44:22 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1XjyS3-0006FY-37; Thu, 30 Oct 2014 23:44:22 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161361AbaJ3WoR (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 30 Oct 2014 18:44:17 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:43002 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161345AbaJ3WoR (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 30 Oct 2014 18:44:17 -0400 Received: from gauss.fritz.box (aftr-88-217-181-163.dynamic.mnet-online.de [88.217.181.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: zzam) by smtp.gentoo.org (Postfix) with ESMTPSA id C1094340497; Thu, 30 Oct 2014 22:44:10 +0000 (UTC) From: Matthias Schwarzott <zzam@gentoo.org> To: mchehab@osg.samsung.com, crope@iki.fi, linux-media@vger.kernel.org Cc: Matthias Schwarzott <zzam@gentoo.org> Subject: [PATCH] cx231xx: remove direct register PWR_CTL_EN modification that switches port3 Date: Thu, 30 Oct 2014 23:43:55 +0100 Message-Id: <1414709035-7729-1-git-send-email-zzam@gentoo.org> X-Mailer: git-send-email 2.1.2 In-Reply-To: <20141030182706.09265d37@recife.lan> References: <20141030182706.09265d37@recife.lan> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.10.30.223023 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Matthias Schwarzott
Oct. 30, 2014, 10:43 p.m. UTC
The only remaining place that modifies the relevant bit is in function
cx231xx_set_Colibri_For_LowIF
Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
---
drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
Hi Mauro, this one is now based on your cx231xx branch. Regards Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em Thu, 30 Oct 2014 23:43:55 +0100 Matthias Schwarzott <zzam@gentoo.org> escreveu: > The only remaining place that modifies the relevant bit is in function > cx231xx_set_Colibri_For_LowIF > > Signed-off-by: Matthias Schwarzott <zzam@gentoo.org> > --- > drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c > index b56bc87..781908b 100644 > --- a/drivers/media/usb/cx231xx/cx231xx-avcore.c > +++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c > @@ -2270,7 +2270,6 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode) > case POLARIS_AVMODE_ANALOGT_TV: > > tmp |= PWR_DEMOD_EN; > - tmp |= (I2C_DEMOD_EN); > value[0] = (u8) tmp; > value[1] = (u8) (tmp >> 8); > value[2] = (u8) (tmp >> 16); > @@ -2366,7 +2365,7 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode) > } > > tmp &= (~PWR_AV_MODE); > - tmp |= POLARIS_AVMODE_DIGITAL | I2C_DEMOD_EN; > + tmp |= POLARIS_AVMODE_DIGITAL; > value[0] = (u8) tmp; > value[1] = (u8) (tmp >> 8); > value[2] = (u8) (tmp >> 16); Hmm... Not sure if this patch is right. There is one I2C bus internally at cx231xx. Some configurations need to go through this I2C bus. Did you test if changing from/to analog/digital mode is working? Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 31.10.2014 11:32, Mauro Carvalho Chehab wrote: > Em Thu, 30 Oct 2014 23:43:55 +0100 > Matthias Schwarzott <zzam@gentoo.org> escreveu: > >> The only remaining place that modifies the relevant bit is in function >> cx231xx_set_Colibri_For_LowIF >> >> Signed-off-by: Matthias Schwarzott <zzam@gentoo.org> >> --- >> drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c >> index b56bc87..781908b 100644 >> --- a/drivers/media/usb/cx231xx/cx231xx-avcore.c >> +++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c >> @@ -2270,7 +2270,6 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode) >> case POLARIS_AVMODE_ANALOGT_TV: >> >> tmp |= PWR_DEMOD_EN; >> - tmp |= (I2C_DEMOD_EN); >> value[0] = (u8) tmp; >> value[1] = (u8) (tmp >> 8); >> value[2] = (u8) (tmp >> 16); >> @@ -2366,7 +2365,7 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode) >> } >> >> tmp &= (~PWR_AV_MODE); >> - tmp |= POLARIS_AVMODE_DIGITAL | I2C_DEMOD_EN; >> + tmp |= POLARIS_AVMODE_DIGITAL; >> value[0] = (u8) tmp; >> value[1] = (u8) (tmp >> 8); >> value[2] = (u8) (tmp >> 16); > Hi Mauro, > Hmm... Not sure if this patch is right. There is one I2C bus internally > at cx231xx. Some configurations need to go through this I2C bus. > What exactly do you mean by configurations need to go through this I2C bus? Do you mean the port3 switch must have a specific value even when not doing i2c transfers? > Did you test if changing from/to analog/digital mode is working? > I did not yet check analog mode. Regards Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em Fri, 31 Oct 2014 14:09:58 +0100 Matthias Schwarzott <zzam@gentoo.org> escreveu: > On 31.10.2014 11:32, Mauro Carvalho Chehab wrote: > > Em Thu, 30 Oct 2014 23:43:55 +0100 > > Matthias Schwarzott <zzam@gentoo.org> escreveu: > > > >> The only remaining place that modifies the relevant bit is in function > >> cx231xx_set_Colibri_For_LowIF > >> > >> Signed-off-by: Matthias Schwarzott <zzam@gentoo.org> > >> --- > >> drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions(-) > >> > >> diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c > >> index b56bc87..781908b 100644 > >> --- a/drivers/media/usb/cx231xx/cx231xx-avcore.c > >> +++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c > >> @@ -2270,7 +2270,6 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode) > >> case POLARIS_AVMODE_ANALOGT_TV: > >> > >> tmp |= PWR_DEMOD_EN; > >> - tmp |= (I2C_DEMOD_EN); > >> value[0] = (u8) tmp; > >> value[1] = (u8) (tmp >> 8); > >> value[2] = (u8) (tmp >> 16); > >> @@ -2366,7 +2365,7 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode) > >> } > >> > >> tmp &= (~PWR_AV_MODE); > >> - tmp |= POLARIS_AVMODE_DIGITAL | I2C_DEMOD_EN; > >> + tmp |= POLARIS_AVMODE_DIGITAL; > >> value[0] = (u8) tmp; > >> value[1] = (u8) (tmp >> 8); > >> value[2] = (u8) (tmp >> 16); > > > > Hi Mauro, > > > Hmm... Not sure if this patch is right. There is one I2C bus internally > > at cx231xx. Some configurations need to go through this I2C bus. > > > > What exactly do you mean by configurations need to go through this I2C > bus? Do you mean the port3 switch must have a specific value even when > not doing i2c transfers? No, I think I miss expressed... What I meant to say is that, on Colibri (e. g. cx231xx), internal I2C buses are used to control some IP parts of the chip design. Maybe setting I2C_DEMOD_EN there is a requirement for those commands to go to the right IP block. > > > Did you test if changing from/to analog/digital mode is working? > > > > I did not yet check analog mode. Ok. I'll add analog to my test plan. > > Regards > Matthias > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c index b56bc87..781908b 100644 --- a/drivers/media/usb/cx231xx/cx231xx-avcore.c +++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c @@ -2270,7 +2270,6 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode) case POLARIS_AVMODE_ANALOGT_TV: tmp |= PWR_DEMOD_EN; - tmp |= (I2C_DEMOD_EN); value[0] = (u8) tmp; value[1] = (u8) (tmp >> 8); value[2] = (u8) (tmp >> 16); @@ -2366,7 +2365,7 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode) } tmp &= (~PWR_AV_MODE); - tmp |= POLARIS_AVMODE_DIGITAL | I2C_DEMOD_EN; + tmp |= POLARIS_AVMODE_DIGITAL; value[0] = (u8) tmp; value[1] = (u8) (tmp >> 8); value[2] = (u8) (tmp >> 16);