Message ID | 1408253089-9487-1-git-send-email-olli.salonen@iki.fi (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1XIt1Z-0003zN-JU; Sun, 17 Aug 2014 07:29:01 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1XIt1X-0005ti-85; Sun, 17 Aug 2014 07:29:01 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750792AbaHQF2o (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Sun, 17 Aug 2014 01:28:44 -0400 Received: from mta-out1.inet.fi ([62.71.2.194]:43046 "EHLO jenni2.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbaHQF2o (ORCPT <rfc822;linux-media@vger.kernel.org>); Sun, 17 Aug 2014 01:28:44 -0400 Received: from devlin.trsqr.net (84.249.202.144) by jenni2.inet.fi (8.5.142.08) id 53C62CBF02C6EF4C; Sun, 17 Aug 2014 08:24:52 +0300 From: Olli Salonen <olli.salonen@iki.fi> To: linux-media@vger.kernel.org Cc: Olli Salonen <olli.salonen@iki.fi> Subject: [PATCH] si2157: Add support for delivery system SYS_ATSC Date: Sun, 17 Aug 2014 08:24:49 +0300 Message-Id: <1408253089-9487-1-git-send-email-olli.salonen@iki.fi> X-Mailer: git-send-email 1.9.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.8.17.52118 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __DATE_TZ_RU 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Olli Salonen
Aug. 17, 2014, 5:24 a.m. UTC
Set the property for delivery system also in case of SYS_ATSC. This
behaviour is observed in the sniffs taken with Hauppauge HVR-955Q
Windows driver.
Signed-off-by: Olli Salonen <olli.salonen@iki.fi>
---
drivers/media/tuners/si2157.c | 3 +++
1 file changed, 3 insertions(+)
Comments
Hi Olli, Em Sun, 17 Aug 2014 08:24:49 +0300 Olli Salonen <olli.salonen@iki.fi> escreveu: > Set the property for delivery system also in case of SYS_ATSC. This > behaviour is observed in the sniffs taken with Hauppauge HVR-955Q > Windows driver. > > Signed-off-by: Olli Salonen <olli.salonen@iki.fi> > --- > drivers/media/tuners/si2157.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c > index 6c53edb..3b86d59 100644 > --- a/drivers/media/tuners/si2157.c > +++ b/drivers/media/tuners/si2157.c > @@ -239,6 +239,9 @@ static int si2157_set_params(struct dvb_frontend *fe) > bandwidth = 0x0f; > > switch (c->delivery_system) { > + case SYS_ATSC: > + delivery_system = 0x00; > + break; Did you check if it uses the same delivery system also for clear-QAM? If so, this patch is missing SYS_DVBC_ANNEX_B inside this case. Ah, FYI, I merged the demod used on HVR-955Q at a separate topic branch upstream: http://git.linuxtv.org/cgit.cgi/media_tree.git/log/?h=lgdt3306a Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mauro, No, for ClearQAM the delivery_system should be set to 0x10 and this patch does not include that. At the time of submission of that patch I only had the trace from the ATSC case. ATSC & ClearQAM USB sniffs here: http://trsqr.net/olli/hvr955q/ Cheers, -olli On 29 October 2014 11:08, Mauro Carvalho Chehab <mchehab@osg.samsung.com> wrote: > Hi Olli, > > Em Sun, 17 Aug 2014 08:24:49 +0300 > Olli Salonen <olli.salonen@iki.fi> escreveu: > >> Set the property for delivery system also in case of SYS_ATSC. This >> behaviour is observed in the sniffs taken with Hauppauge HVR-955Q >> Windows driver. >> >> Signed-off-by: Olli Salonen <olli.salonen@iki.fi> >> --- >> drivers/media/tuners/si2157.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c >> index 6c53edb..3b86d59 100644 >> --- a/drivers/media/tuners/si2157.c >> +++ b/drivers/media/tuners/si2157.c >> @@ -239,6 +239,9 @@ static int si2157_set_params(struct dvb_frontend *fe) >> bandwidth = 0x0f; >> >> switch (c->delivery_system) { >> + case SYS_ATSC: >> + delivery_system = 0x00; >> + break; > > Did you check if it uses the same delivery system also for clear-QAM? > > If so, this patch is missing SYS_DVBC_ANNEX_B inside this case. > > Ah, FYI, I merged the demod used on HVR-955Q at a separate topic branch > upstream: > http://git.linuxtv.org/cgit.cgi/media_tree.git/log/?h=lgdt3306a > > Regards, > Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em Thu, 30 Oct 2014 08:04:29 +0200 Olli Salonen <olli.salonen@iki.fi> escreveu: > Hi Mauro, > > No, for ClearQAM the delivery_system should be set to 0x10 and this > patch does not include that. At the time of submission of that patch I > only had the trace from the ATSC case. Ah, ok. Are you planning to submit a patch for it, and the patches adding support for HVR-955Q? > > ATSC & ClearQAM USB sniffs here: > http://trsqr.net/olli/hvr955q/ Thanks! Regards, Mauro > > Cheers, > -olli > > On 29 October 2014 11:08, Mauro Carvalho Chehab <mchehab@osg.samsung.com> wrote: > > Hi Olli, > > > > Em Sun, 17 Aug 2014 08:24:49 +0300 > > Olli Salonen <olli.salonen@iki.fi> escreveu: > > > >> Set the property for delivery system also in case of SYS_ATSC. This > >> behaviour is observed in the sniffs taken with Hauppauge HVR-955Q > >> Windows driver. > >> > >> Signed-off-by: Olli Salonen <olli.salonen@iki.fi> > >> --- > >> drivers/media/tuners/si2157.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c > >> index 6c53edb..3b86d59 100644 > >> --- a/drivers/media/tuners/si2157.c > >> +++ b/drivers/media/tuners/si2157.c > >> @@ -239,6 +239,9 @@ static int si2157_set_params(struct dvb_frontend *fe) > >> bandwidth = 0x0f; > >> > >> switch (c->delivery_system) { > >> + case SYS_ATSC: > >> + delivery_system = 0x00; > >> + break; > > > > Did you check if it uses the same delivery system also for clear-QAM? > > > > If so, this patch is missing SYS_DVBC_ANNEX_B inside this case. > > > > Ah, FYI, I merged the demod used on HVR-955Q at a separate topic branch > > upstream: > > http://git.linuxtv.org/cgit.cgi/media_tree.git/log/?h=lgdt3306a > > > > Regards, > > Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 30 Oct 2014, Mauro Carvalho Chehab wrote: > Ah, ok. Are you planning to submit a patch for it, and the patches adding > support for HVR-955Q? I can submit a patch for that, no problem. However, I'm not working with HVR-955Q at the moment. I don't have access to ATSC/ClearQAM signal. If someone is working with that, I can put you in contact with someone who is interested in that device and is able to test. Cheers, -olli -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Olli, Em Thu, 30 Oct 2014 12:32:33 +0200 Olli Salonen <olli.salonen@iki.fi> escreveu: > On Thu, 30 Oct 2014, Mauro Carvalho Chehab wrote: > > > Ah, ok. Are you planning to submit a patch for it, and the patches adding > > support for HVR-955Q? > > I can submit a patch for that, no problem. Yes, please do that. > However, I'm not working with > HVR-955Q at the moment. I don't have access to ATSC/ClearQAM signal. Ah, ok. I have it here and I have ATSC/ClearQAM here, so I can do the patches. I was just wanting to know if someone else is doing it already. > If someone is working with that, I can put you in contact with someone > who is interested in that device and is able to test. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c index 6c53edb..3b86d59 100644 --- a/drivers/media/tuners/si2157.c +++ b/drivers/media/tuners/si2157.c @@ -239,6 +239,9 @@ static int si2157_set_params(struct dvb_frontend *fe) bandwidth = 0x0f; switch (c->delivery_system) { + case SYS_ATSC: + delivery_system = 0x00; + break; case SYS_DVBT: case SYS_DVBT2: /* it seems DVB-T and DVB-T2 both are 0x20 here */ delivery_system = 0x20;