Message ID | 1412586626.4054.42.camel@x220 (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Sylwester Nawrocki |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1Xb4Jb-0002fD-QO; Mon, 06 Oct 2014 11:10:47 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1Xb4JZ-0000UO-lq; Mon, 06 Oct 2014 11:10:47 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752162AbaJFJK3 (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 6 Oct 2014 05:10:29 -0400 Received: from cpsmtpb-ews04.kpnxchange.com ([213.75.39.7]:49229 "EHLO cpsmtpb-ews04.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbaJFJK3 (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 6 Oct 2014 05:10:29 -0400 Received: from cpsps-ews18.kpnxchange.com ([10.94.84.184]) by cpsmtpb-ews04.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Mon, 6 Oct 2014 11:10:27 +0200 Received: from CPSMTPM-TLF101.kpnxchange.com ([195.121.3.4]) by cpsps-ews18.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Mon, 6 Oct 2014 11:10:27 +0200 Received: from [192.168.10.104] ([77.173.140.92]) by CPSMTPM-TLF101.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Mon, 6 Oct 2014 11:10:26 +0200 Message-ID: <1412586626.4054.42.camel@x220> Subject: [PATCH 3/4] [media] Remove optional dependency on PLAT_S5P From: Paul Bolle <pebolle@tiscali.nl> To: Kyungmin Park <kyungmin.park@samsung.com>, Tomasz Stanislawski <t.stanislaws@samsung.com>, Mauro Carvalho Chehab <m.chehab@samsung.com> Cc: Valentin Rothberg <valentinrothberg@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 06 Oct 2014 11:10:26 +0200 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 06 Oct 2014 09:10:26.0880 (UTC) FILETIME=[5E573400:01CFE145] X-RcptDomain: vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.10.6.90626 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MIME_LOWER_CASE 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CT_TEXT_PLAIN_UTF8_CAPS 0, INVALID_MSGID_NO_FQDN 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_XOAT 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __INT_PROD_TV 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Paul Bolle
Oct. 6, 2014, 9:10 a.m. UTC
Commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
removed the Kconfig symbol PLAT_S5P. Remove an optional dependency on
that symbol from this Kconfig file too.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
drivers/media/platform/s5p-tv/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Monday 06 October 2014 11:10:26 Paul Bolle wrote: > config VIDEO_SAMSUNG_S5P_TV > bool "Samsung TV driver for S5P platform" > depends on PM_RUNTIME > - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST > + depends on ARCH_EXYNOS || COMPILE_TEST > default n > ---help--- > Say Y here to enable selecting the TV output devices for > I wonder if it should now allow being built for ARCH_S5PV210. Maybe it was a mistake to remove the PLAT_S5P symbol without changing the use here? Does S5PV210 have this device? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/10/14 11:26, Arnd Bergmann wrote: > On Monday 06 October 2014 11:10:26 Paul Bolle wrote: >> config VIDEO_SAMSUNG_S5P_TV >> bool "Samsung TV driver for S5P platform" >> depends on PM_RUNTIME >> - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST >> + depends on ARCH_EXYNOS || COMPILE_TEST >> default n >> ---help--- >> Say Y here to enable selecting the TV output devices for >> > > I wonder if it should now allow being built for ARCH_S5PV210. > Maybe it was a mistake to remove the PLAT_S5P symbol without changing > the use here? > > Does S5PV210 have this device? Yes, it does. Indeed, in all patches in this series we should have replaced PLAT_S5P with ARCH_S5PV210. -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2014-10-06 at 11:26 +0200, Arnd Bergmann wrote: > On Monday 06 October 2014 11:10:26 Paul Bolle wrote: > > config VIDEO_SAMSUNG_S5P_TV > > bool "Samsung TV driver for S5P platform" > > depends on PM_RUNTIME > > - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST > > + depends on ARCH_EXYNOS || COMPILE_TEST > > default n > > ---help--- > > Say Y here to enable selecting the TV output devices for > > > > I wonder if it should now allow being built for ARCH_S5PV210. That was what Tomasz Figa claimed in http://lkml.kernel.org/r/53C676DB.6070002@samsung.com > Maybe it was a mistake to remove the PLAT_S5P symbol without changing > the use here? At least it was a bit sloppy to remove the symbol without touching this (and six other) dependencies. But after nearly three months I lost patience waiting for a fix to be submitted. My cleanup doesn't really change a thing. And a proper fix, if needed, is still possible after this has landed. > Does S5PV210 have this device? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2014-10-06 at 11:34 +0200, Sylwester Nawrocki wrote: > On 06/10/14 11:26, Arnd Bergmann wrote: > > > > Does S5PV210 have this device? > > Yes, it does. Indeed, in all patches in this series we should > have replaced PLAT_S5P with ARCH_S5PV210. If somebody would actually do that, that would be great. I lost patience waiting for a patch that did that. So I submitted these cleanup patches that basically change nothing. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/s5p-tv/Kconfig b/drivers/media/platform/s5p-tv/Kconfig index a9d56f8936b4..3d11fea5cc92 100644 --- a/drivers/media/platform/s5p-tv/Kconfig +++ b/drivers/media/platform/s5p-tv/Kconfig @@ -9,7 +9,7 @@ config VIDEO_SAMSUNG_S5P_TV bool "Samsung TV driver for S5P platform" depends on PM_RUNTIME - depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST + depends on ARCH_EXYNOS || COMPILE_TEST default n ---help--- Say Y here to enable selecting the TV output devices for