mbox

[GIT,PULL,FOR,v3.18] tw68: add new driver for tw68xx grabber cards

Message ID 53EC8240.5080801@cisco.com (mailing list archive)
State Changes Requested, archived
Headers

Pull-request

git://linuxtv.org/hverkuil/media_tree.git tw68

Message

Hans Verkuil (hansverk) Aug. 14, 2014, 9:32 a.m. UTC 
  The following changes since commit 0f3bf3dc1ca394a8385079a5653088672b65c5c4:
                                                                                                                                       
   [media] cx23885: fix UNSET/TUNER_ABSENT confusion (2014-08-01 15:30:59 -0300)
                                                                                                                                       
are available in the git repository at:
                                                                                                                                       
   git://linuxtv.org/hverkuil/media_tree.git tw68
                                                                                                                                       
for you to fetch changes up to 64889b98f7ed20ab630a47eff4a5847c3aa0555e:
                                                                                                                                       
   MAINTAINERS: add tw68 entry (2014-08-10 10:36:10 +0200)
                                                                                                                                       
----------------------------------------------------------------
Hans Verkuil (2):
       tw68: add support for Techwell tw68xx PCI grabber boards
       MAINTAINERS: add tw68 entry
                                                                                                                                       
  MAINTAINERS                         |    8 +
  drivers/media/pci/Kconfig           |    1 +
  drivers/media/pci/Makefile          |    1 +
  drivers/media/pci/tw68/Kconfig      |   10 +
  drivers/media/pci/tw68/Makefile     |    3 +
  drivers/media/pci/tw68/tw68-core.c  |  458 ++++++++++++++++++++++++++++++++++++++
  drivers/media/pci/tw68/tw68-reg.h   |  195 ++++++++++++++++
  drivers/media/pci/tw68/tw68-risc.c  |  230 +++++++++++++++++++
  drivers/media/pci/tw68/tw68-video.c | 1082 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  drivers/media/pci/tw68/tw68.h       |  235 ++++++++++++++++++++
  10 files changed, 2223 insertions(+)
  create mode 100644 drivers/media/pci/tw68/Kconfig
  create mode 100644 drivers/media/pci/tw68/Makefile
  create mode 100644 drivers/media/pci/tw68/tw68-core.c
  create mode 100644 drivers/media/pci/tw68/tw68-reg.h
  create mode 100644 drivers/media/pci/tw68/tw68-risc.c
  create mode 100644 drivers/media/pci/tw68/tw68-video.c
  create mode 100644 drivers/media/pci/tw68/tw68.h
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Mauro Carvalho Chehab Aug. 14, 2014, 11:54 a.m. UTC | #1 
Em Thu, 14 Aug 2014 11:32:48 +0200
Hans Verkuil <hansverk@cisco.com> escreveu:

> The following changes since commit 0f3bf3dc1ca394a8385079a5653088672b65c5c4:
>                                                                                                                                        
>    [media] cx23885: fix UNSET/TUNER_ABSENT confusion (2014-08-01 15:30:59 -0300)
>                                                                                                                                        
> are available in the git repository at:
>                                                                                                                                        
>    git://linuxtv.org/hverkuil/media_tree.git tw68
>                                                                                                                                        
> for you to fetch changes up to 64889b98f7ed20ab630a47eff4a5847c3aa0555e:
>                                                                                                                                        
>    MAINTAINERS: add tw68 entry (2014-08-10 10:36:10 +0200)
>                                                                                                                                        
> ----------------------------------------------------------------
> Hans Verkuil (2):
>        tw68: add support for Techwell tw68xx PCI grabber boards

NACK. This patch breaks compilation with allyesconfig:

drivers/media/pci/tw68/tw68-video.c: In function 'tw68_s_input':
drivers/media/pci/tw68/tw68-video.c:751:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
  if (i < 0 || i >= TW68_INPUT_MAX)
  ^
drivers/media/pci/tw68/built-in.o:(.bss+0x568): multiple definition of `video_debug'
drivers/media/pci/saa7134/built-in.o:(.bss+0x3b08): first defined here
make[2]: *** [drivers/media/pci/built-in.o] Error 1
make[1]: *** [drivers/media/pci] Error 2
make: *** [_module_drivers/media] Error 2

PS.: It likely makes sense to also rename video_debug at saa7134, or
to get rid of both, in favor of using dynamic debug printks.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html