[1/1] dvb-frontends: remove unnecessary break after goto

Message ID 1404840181-29822-1-git-send-email-fabf@skynet.be (mailing list archive)
State Accepted, archived
Delegated to: Michael Krufky
Headers

Commit Message

Fabian Frederick July 8, 2014, 5:23 p.m. UTC
  Cc: Antti Palosaari <crope@iki.fi>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: linux-media@vger.kernel.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 drivers/media/dvb-frontends/af9013.c | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Antti Palosaari July 8, 2014, 6:35 p.m. UTC | #1
Moikka Fabian!
I have no reason to decline that patch (I will apply it) even it has 
hardly meaning. But is there now some new tool which warns that kind of 
issues?

regards
Atnti


On 07/08/2014 08:23 PM, Fabian Frederick wrote:
> Cc: Antti Palosaari <crope@iki.fi>
> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
> Cc: linux-media@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>   drivers/media/dvb-frontends/af9013.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/af9013.c b/drivers/media/dvb-frontends/af9013.c
> index fb504f1..ecf6388 100644
> --- a/drivers/media/dvb-frontends/af9013.c
> +++ b/drivers/media/dvb-frontends/af9013.c
> @@ -470,7 +470,6 @@ static int af9013_statistics_snr_result(struct dvb_frontend *fe)
>   		break;
>   	default:
>   		goto err;
> -		break;
>   	}
>
>   	for (i = 0; i < len; i++) {
>
  
Fabian Frederick July 9, 2014, 2:12 a.m. UTC | #2
On Tue, 08 Jul 2014 21:35:58 +0300
Antti Palosaari <crope@iki.fi> wrote:

> Moikka Fabian!
> I have no reason to decline that patch (I will apply it) even it has 
> hardly meaning. But is there now some new tool which warns that kind of 
> issues?
Hello Antti,

	Thanks :) AFAIK there's still no automatic detection of those cases.

Regards,
Fabian
> 
> regards
> Atnti
> 
> 
> On 07/08/2014 08:23 PM, Fabian Frederick wrote:
> > Cc: Antti Palosaari <crope@iki.fi>
> > Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
> > Cc: linux-media@vger.kernel.org
> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
> > ---
> >   drivers/media/dvb-frontends/af9013.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/media/dvb-frontends/af9013.c b/drivers/media/dvb-frontends/af9013.c
> > index fb504f1..ecf6388 100644
> > --- a/drivers/media/dvb-frontends/af9013.c
> > +++ b/drivers/media/dvb-frontends/af9013.c
> > @@ -470,7 +470,6 @@ static int af9013_statistics_snr_result(struct dvb_frontend *fe)
> >   		break;
> >   	default:
> >   		goto err;
> > -		break;
> >   	}
> >
> >   	for (i = 0; i < len; i++) {
> >
> 
> -- 
> http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Patch

diff --git a/drivers/media/dvb-frontends/af9013.c b/drivers/media/dvb-frontends/af9013.c
index fb504f1..ecf6388 100644
--- a/drivers/media/dvb-frontends/af9013.c
+++ b/drivers/media/dvb-frontends/af9013.c
@@ -470,7 +470,6 @@  static int af9013_statistics_snr_result(struct dvb_frontend *fe)
 		break;
 	default:
 		goto err;
-		break;
 	}
 
 	for (i = 0; i < len; i++) {