diff mbox

[14/15] - zl10353

Message ID 4B69DEDA.3020200@arcor.de (mailing list archive)
State Superseded, archived
Headers

Commit Message

Stefan Ringel Feb. 3, 2010, 8:38 p.m. UTC 
  signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>

Comments

Devin Heitmueller Feb. 3, 2010, 8:49 p.m. UTC | #1 
On Wed, Feb 3, 2010 at 3:38 PM, Stefan Ringel <stefan.ringel@arcor.de> wrote:
> signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
>
> --- a/drivers/media/dvb/frontends/zl10353.h
> +++ b/drivers/media/dvb/frontends/zl10353.h
> @@ -45,6 +45,8 @@ struct zl10353_config
>        /* clock control registers (0x51-0x54) */
>        u8 clock_ctl_1;  /* default: 0x46 */
>        u8 pll_0;        /* default: 0x15 */
> +
> +       int tm6000:1;
>  };

Why is this being submitted as its own patch?  It is code that is not
used by *anything*.  If you really did require a new field in the
zl10353 config, that field should be added in the same patch as
whatever requires it.

Devin
Stefan Ringel Feb. 3, 2010, 9:07 p.m. UTC | #2 
Am 03.02.2010 21:49, schrieb Devin Heitmueller:
> On Wed, Feb 3, 2010 at 3:38 PM, Stefan Ringel <stefan.ringel@arcor.de> wrote:
>   
>> signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
>>
>> --- a/drivers/media/dvb/frontends/zl10353.h
>> +++ b/drivers/media/dvb/frontends/zl10353.h
>> @@ -45,6 +45,8 @@ struct zl10353_config
>>        /* clock control registers (0x51-0x54) */
>>        u8 clock_ctl_1;  /* default: 0x46 */
>>        u8 pll_0;        /* default: 0x15 */
>> +
>> +       int tm6000:1;
>>  };
>>     
> Why is this being submitted as its own patch?  It is code that is not
> used by *anything*.  If you really did require a new field in the
> zl10353 config, that field should be added in the same patch as
> whatever requires it.
>
> Devin
>
>   
Actually doesn't work zl10353 with tm6010, it have a little different
between a few registers, so I think that I use it.

for example:
zl10353 use 0x64 , but not mine (0x63)
register 0x5f is 0x17 not 0x13
register 0x5e is 0x40 not 0x00 for auto
and tuner go is 0x70 not 0x71

the other register are ok. I have no idea how I can set it.
diff mbox

Patch

--- a/drivers/media/dvb/frontends/zl10353.h
+++ b/drivers/media/dvb/frontends/zl10353.h
@@ -45,6 +45,8 @@  struct zl10353_config
 	/* clock control registers (0x51-0x54) */
 	u8 clock_ctl_1;  /* default: 0x46 */
 	u8 pll_0;        /* default: 0x15 */
+	
+	int tm6000:1;
 };
 
 #if defined(CONFIG_DVB_ZL10353) || (defined(CONFIG_DVB_ZL10353_MODULE) && defined(MODULE))