diff mbox

[1/15] - tm6000 build hunk

Message ID 4B69D83D.5050809@arcor.de (mailing list archive)
State Superseded, archived
Headers

Commit Message

Stefan Ringel Feb. 3, 2010, 8:10 p.m. UTC

Comments

Mauro Carvalho Chehab Feb. 3, 2010, 8:16 p.m. UTC | #1 
Stefan Ringel wrote:

OK, patch is correct, but you should:

- Use the email subject to summarize what the patch does
- Add more detailed patch description;
- Add your Signed-off-by.

In this specific case, you could have:

Subject: Fix compilation breakage

Signed-off-by: your name <your@email>

(this is a really trivial patch - so, you don't need a detailed description)

> --- a/drivers/staging/tm6000/tm6000-cards.c
> +++ b/drivers/staging/tm6000/tm6000-cards.c
> @@ -32,7 +32,7 @@
>  #include "tm6000.h"
>  #include "tm6000-regs.h"
>  #include "tuner-xc2028.h"
> -#include "tuner-xc5000.h"
> +#include "xc5000.h"
>  
>  #define TM6000_BOARD_UNKNOWN            0
>  #define TM5600_BOARD_GENERIC            1
>
Devin Heitmueller Feb. 3, 2010, 8:17 p.m. UTC | #2 
On Wed, Feb 3, 2010 at 3:10 PM, Stefan Ringel <stefan.ringel@arcor.de> wrote:
> --- a/drivers/staging/tm6000/tm6000-cards.c
> +++ b/drivers/staging/tm6000/tm6000-cards.c

Before you send too many of these, I should point out that there is a
well-defined format expected for patches.  Look here:

http://linuxtv.org/wiki/index.php/Development:_How_to_submit_patches

And you can see an example here:

http://kernellabs.com/hg/~dheitmueller/em28xx-test/rev/42272c1dd883

Devin
diff mbox

Patch

--- a/drivers/staging/tm6000/tm6000-cards.c
+++ b/drivers/staging/tm6000/tm6000-cards.c
@@ -32,7 +32,7 @@ 
 #include "tm6000.h"
 #include "tm6000-regs.h"
 #include "tuner-xc2028.h"
-#include "tuner-xc5000.h"
+#include "xc5000.h"
 
 #define TM6000_BOARD_UNKNOWN            0
 #define TM5600_BOARD_GENERIC            1