diff mbox

[1/5] s5p-fimc: Changed RGB32 to BGR32

Message ID 1395780923.11851.21.camel@nicolas-tpx230 (mailing list archive)
State Accepted, archived
Delegated to: Sylwester Nawrocki
Headers

Commit Message

Nicolas Dufresne March 25, 2014, 8:55 p.m. UTC 
  Testing showed that HW produces BGR32 rather then RGB32 as exposed
in the driver. The documentation seems to state the pixels are stored
in little endian order.

Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
---
 drivers/media/platform/exynos4-is/fimc-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Sylwester Nawrocki April 1, 2014, 2:34 p.m. UTC | #1 
On 25/03/14 21:55, Nicolas Dufresne wrote:
> Testing showed that HW produces BGR32 rather then RGB32 as exposed
> in the driver. The documentation seems to state the pixels are stored
> in little endian order.
> 
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
>  drivers/media/platform/exynos4-is/fimc-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/exynos4-is/fimc-core.c b/drivers/media/platform/exynos4-is/fimc-core.c
> index da2fc86..bfb80fb 100644
> --- a/drivers/media/platform/exynos4-is/fimc-core.c
> +++ b/drivers/media/platform/exynos4-is/fimc-core.c
> @@ -56,8 +56,8 @@ static struct fimc_fmt fimc_formats[] = {
>  		.colplanes	= 1,
>  		.flags		= FMT_FLAGS_M2M,
>  	}, {
> -		.name		= "ARGB8888, 32 bpp",
> -		.fourcc		= V4L2_PIX_FMT_RGB32,
> +		.name		= "BGRB888, 32 bpp",

It should be "BGRA8888, 32 bpp", I can fix it when applying, if
you won't send next version of this patch until then.

> +		.fourcc		= V4L2_PIX_FMT_BGR32,
>  		.depth		= { 32 },
>  		.color		= FIMC_FMT_RGB888,
>  		.memplanes	= 1,

--
Thanks!
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Nicolas Dufresne April 1, 2014, 3:16 p.m. UTC | #2 
Le mardi 01 avril 2014 à 16:34 +0200, Sylwester Nawrocki a écrit :
> It should be "BGRA8888, 32 bpp", I can fix it when applying, if
> you won't send next version of this patch until then.

Good catch, I'll let you fix when applying.

thanks,
Nicolas
diff mbox

Patch

diff --git a/drivers/media/platform/exynos4-is/fimc-core.c b/drivers/media/platform/exynos4-is/fimc-core.c
index da2fc86..bfb80fb 100644
--- a/drivers/media/platform/exynos4-is/fimc-core.c
+++ b/drivers/media/platform/exynos4-is/fimc-core.c
@@ -56,8 +56,8 @@  static struct fimc_fmt fimc_formats[] = {
 		.colplanes	= 1,
 		.flags		= FMT_FLAGS_M2M,
 	}, {
-		.name		= "ARGB8888, 32 bpp",
-		.fourcc		= V4L2_PIX_FMT_RGB32,
+		.name		= "BGRB888, 32 bpp",
+		.fourcc		= V4L2_PIX_FMT_BGR32,
 		.depth		= { 32 },
 		.color		= FIMC_FMT_RGB888,
 		.memplanes	= 1,