diff mbox

[6/7] drivers/media/dvb/frontends/stv090x.c: fix use-uninitialised

Message ID 201002022240.o12MeokZ018918@imap1.linux-foundation.org (mailing list archive)
State Superseded, archived
Headers

Commit Message

Andrew Morton Feb. 2, 2010, 10:40 p.m. UTC 
  From: Andrew Morton <akpm@linux-foundation.org>

drivers/media/dvb/frontends/stv090x.c: In function 'stv090x_blind_search':
drivers/media/dvb/frontends/stv090x.c:1967: warning: 'coarse_fail' may be used uninitialized in this function

Cc: Manu Abraham <manu@linuxtv.org>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/media/dvb/frontends/stv090x.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Manu Abraham Feb. 2, 2010, 10:52 p.m. UTC | #1 
On Wed, Feb 3, 2010 at 2:40 AM,  <akpm@linux-foundation.org> wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
>
> drivers/media/dvb/frontends/stv090x.c: In function 'stv090x_blind_search':
> drivers/media/dvb/frontends/stv090x.c:1967: warning: 'coarse_fail' may be used uninitialized in this function
>
> Cc: Manu Abraham <manu@linuxtv.org>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
>  drivers/media/dvb/frontends/stv090x.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -puN drivers/media/dvb/frontends/stv090x.c~drivers-media-dvb-frontends-stv090xc-fix-use-uninitialised drivers/media/dvb/frontends/stv090x.c
> --- a/drivers/media/dvb/frontends/stv090x.c~drivers-media-dvb-frontends-stv090xc-fix-use-uninitialised
> +++ a/drivers/media/dvb/frontends/stv090x.c
> @@ -1964,7 +1964,8 @@ static int stv090x_blind_search(struct s
>        u32 agc2, reg, srate_coarse;
>        s32 cpt_fail, agc2_ovflw, i;
>        u8 k_ref, k_max, k_min;
> -       int coarse_fail, lock;
> +       int coarse_fail = 0;
> +       int lock;
>
>        k_max = 110;
>        k_min = 10;
> _
>

Looks good

Reviewed-by: Manu Abraham <manu@linuxtv.org>
Acked-by: Manu Abraham <manu@linuxtv.org>

Thanks,
Manu
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff -puN drivers/media/dvb/frontends/stv090x.c~drivers-media-dvb-frontends-stv090xc-fix-use-uninitialised drivers/media/dvb/frontends/stv090x.c
--- a/drivers/media/dvb/frontends/stv090x.c~drivers-media-dvb-frontends-stv090xc-fix-use-uninitialised
+++ a/drivers/media/dvb/frontends/stv090x.c
@@ -1964,7 +1964,8 @@  static int stv090x_blind_search(struct s
 	u32 agc2, reg, srate_coarse;
 	s32 cpt_fail, agc2_ovflw, i;
 	u8 k_ref, k_max, k_min;
-	int coarse_fail, lock;
+	int coarse_fail = 0;
+	int lock;
 
 	k_max = 110;
 	k_min = 10;