Message ID | 1394197299-17528-3-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
---|---|
State | Changes Requested, archived |
Delegated to: | Laurent Pinchart |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1WLuQs-0006Bi-2r; Fri, 07 Mar 2014 14:03:22 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1WLuQq-00074i-70; Fri, 07 Mar 2014 14:03:21 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752983AbaCGNBw (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Fri, 7 Mar 2014 08:01:52 -0500 Received: from 82-68-191-81.dsl.posilan.com ([82.68.191.81]:59412 "EHLO rainbowdash.ducie.codethink.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752749AbaCGNBs (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 7 Mar 2014 08:01:48 -0500 Received: from ben by rainbowdash.ducie.codethink.co.uk with local (Exim 4.82) (envelope-from <ben.dooks@codethink.co.uk>) id 1WLuPF-0004Zb-Pt; Fri, 07 Mar 2014 13:01:41 +0000 From: Ben Dooks <ben.dooks@codethink.co.uk> To: linux-media@vger.kernel.org Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>, Mauro Carvalho Chehab <m.chehab@samsung.com>, linux-kernel@vger.kernel.org, magnus.damm@opensource.se, linux-sh@vger.kernel.org, linux-kernel@lists.codethink.co.uk, Ben Dooks <ben.dooks@codethink.co.uk> Subject: [PATCH 2/5] ARM: lager: add vin1 node Date: Fri, 7 Mar 2014 13:01:36 +0000 Message-Id: <1394197299-17528-3-git-send-email-ben.dooks@codethink.co.uk> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1394197299-17528-1-git-send-email-ben.dooks@codethink.co.uk> References: <1394197299-17528-1-git-send-email-ben.dooks@codethink.co.uk> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.3.7.125715 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1400_1499 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Ben Dooks
March 7, 2014, 1:01 p.m. UTC
Add device-tree for vin1 (composite video in) on the
lager board.
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
arch/arm/boot/dts/r8a7790-lager.dts | 38 +++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
Comments
On 07/03/14 16:50, Sergei Shtylyov wrote: > Hello. > > On 03/07/2014 04:01 PM, Ben Dooks wrote: > >> Add device-tree for vin1 (composite video in) on the >> lager board. > >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > > This patch should have been preceded by the VIN driver patch and > bindings description, don't you think? > >> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts >> b/arch/arm/boot/dts/r8a7790-lager.dts >> index a087421..7528cfc 100644 >> --- a/arch/arm/boot/dts/r8a7790-lager.dts >> +++ b/arch/arm/boot/dts/r8a7790-lager.dts > [...] >> @@ -239,8 +244,41 @@ >> status = "ok"; >> pinctrl-0 = <&i2c2_pins>; >> pinctrl-names = "default"; >> + >> + adv7180: adv7180@0x20 { > > ePAPR standard [1] tells us that: > > "The name of a node should be somewhat generic, reflecting the function > of the device and not its precise programming model." > > So, I would suggest something like "video-decoder" instead. And > remove "0x" from the address part of the node name please. Personally I'm not fussed about names in the tree. I will look at changing it to something like vin1_decoder
Hello. On 03/07/2014 04:01 PM, Ben Dooks wrote: > Add device-tree for vin1 (composite video in) on the > lager board. > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> This patch should have been preceded by the VIN driver patch and bindings description, don't you think? > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts > index a087421..7528cfc 100644 > --- a/arch/arm/boot/dts/r8a7790-lager.dts > +++ b/arch/arm/boot/dts/r8a7790-lager.dts [...] > @@ -239,8 +244,41 @@ > status = "ok"; > pinctrl-0 = <&i2c2_pins>; > pinctrl-names = "default"; > + > + adv7180: adv7180@0x20 { ePAPR standard [1] tells us that: "The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model." So, I would suggest something like "video-decoder" instead. And remove "0x" from the address part of the node name please. [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/07/2014 07:06 PM, Ben Dooks wrote: >>> Add device-tree for vin1 (composite video in) on the >>> lager board. >>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >> This patch should have been preceded by the VIN driver patch and >> bindings description, don't you think? >>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts >>> b/arch/arm/boot/dts/r8a7790-lager.dts >>> index a087421..7528cfc 100644 >>> --- a/arch/arm/boot/dts/r8a7790-lager.dts >>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts >> [...] >>> @@ -239,8 +244,41 @@ >>> status = "ok"; >>> pinctrl-0 = <&i2c2_pins>; >>> pinctrl-names = "default"; >>> + >>> + adv7180: adv7180@0x20 { >> ePAPR standard [1] tells us that: >> "The name of a node should be somewhat generic, reflecting the function >> of the device and not its precise programming model." >> So, I would suggest something like "video-decoder" instead. And >> remove "0x" from the address part of the node name please. > Personally I'm not fussed about names in the tree. I quoted the standard everybody should follow. > I will look at changing it to something like vin1_decoder Please give it a generic name instead, without indexes and underscores. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 07, 2014 at 01:01:36PM +0000, Ben Dooks wrote: > Add device-tree for vin1 (composite video in) on the > lager board. Please update the prefix of the subject of this patch to: ARM: shmobile: lager: > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > arch/arm/boot/dts/r8a7790-lager.dts | 38 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts > index a087421..7528cfc 100644 > --- a/arch/arm/boot/dts/r8a7790-lager.dts > +++ b/arch/arm/boot/dts/r8a7790-lager.dts > @@ -158,6 +158,11 @@ > renesas,groups = "i2c2"; > renesas,function = "i2c2"; > }; > + > + vin1_pins: vin { > + renesas,groups = "vin1_data8", "vin1_clk"; > + renesas,function = "vin1"; > + }; > }; > > &mmcif1 { > @@ -239,8 +244,41 @@ > status = "ok"; > pinctrl-0 = <&i2c2_pins>; > pinctrl-names = "default"; > + > + adv7180: adv7180@0x20 { > + compatible = "adi,adv7180"; > + reg = <0x20>; > + remote = <&vin1>; > + > + port { > + adv7180_1: endpoint { > + bus-width = <8>; > + remote-endpoint = <&vin1ep0>; > + }; > + }; > + }; > + > }; > > &i2c3 { > status = "ok"; > }; > + > +/* composite video input */ > +&vin1 { > + pinctrl-0 = <&vin1_pins>; > + pinctrl-names = "default"; > + > + status = "ok"; > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + vin1ep0: endpoint { > + remote-endpoint = <&adv7180_1>; > + bus-width = <8>; > + }; > + }; > +}; > + > -- > 1.9.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts index a087421..7528cfc 100644 --- a/arch/arm/boot/dts/r8a7790-lager.dts +++ b/arch/arm/boot/dts/r8a7790-lager.dts @@ -158,6 +158,11 @@ renesas,groups = "i2c2"; renesas,function = "i2c2"; }; + + vin1_pins: vin { + renesas,groups = "vin1_data8", "vin1_clk"; + renesas,function = "vin1"; + }; }; &mmcif1 { @@ -239,8 +244,41 @@ status = "ok"; pinctrl-0 = <&i2c2_pins>; pinctrl-names = "default"; + + adv7180: adv7180@0x20 { + compatible = "adi,adv7180"; + reg = <0x20>; + remote = <&vin1>; + + port { + adv7180_1: endpoint { + bus-width = <8>; + remote-endpoint = <&vin1ep0>; + }; + }; + }; + }; &i2c3 { status = "ok"; }; + +/* composite video input */ +&vin1 { + pinctrl-0 = <&vin1_pins>; + pinctrl-names = "default"; + + status = "ok"; + + port { + #address-cells = <1>; + #size-cells = <0>; + + vin1ep0: endpoint { + remote-endpoint = <&adv7180_1>; + bus-width = <8>; + }; + }; +}; +