Message ID | 1391958577.25424.22.camel@x220 (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Laurent Pinchart |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1WCW18-0006HK-G8; Sun, 09 Feb 2014 16:09:58 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1WCW16-00010X-4K; Sun, 09 Feb 2014 16:09:58 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751948AbaBIPJj (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Sun, 9 Feb 2014 10:09:39 -0500 Received: from cpsmtpb-ews07.kpnxchange.com ([213.75.39.10]:58915 "EHLO cpsmtpb-ews07.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbaBIPJi (ORCPT <rfc822;linux-media@vger.kernel.org>); Sun, 9 Feb 2014 10:09:38 -0500 X-Greylist: delayed 799 seconds by postgrey-1.27 at vger.kernel.org; Sun, 09 Feb 2014 10:09:38 EST Received: from cpsps-ews08.kpnxchange.com ([10.94.84.175]) by cpsmtpb-ews07.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Sun, 9 Feb 2014 16:09:37 +0100 Received: from CPSMTPM-TLF104.kpnxchange.com ([195.121.3.7]) by cpsps-ews08.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Sun, 9 Feb 2014 16:09:37 +0100 Received: from [192.168.1.104] ([82.169.24.127]) by CPSMTPM-TLF104.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Sun, 9 Feb 2014 16:09:37 +0100 Message-ID: <1391958577.25424.22.camel@x220> Subject: [PATCH] [media] v4l: omap4iss: Remove VIDEO_OMAP4_DEBUG From: Paul Bolle <pebolle@tiscali.nl> To: Mauro Carvalho Chehab <m.chehab@samsung.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sun, 09 Feb 2014 16:09:37 +0100 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.3 (3.10.3-1.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 09 Feb 2014 15:09:37.0201 (UTC) FILETIME=[F29AFA10:01CF25A8] X-RcptDomain: vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.2.9.150017 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MIME_LOWER_CASE 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1300_1399 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CT_TEXT_PLAIN_UTF8_CAPS 0, INVALID_MSGID_NO_FQDN 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_XOAT 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SXL_RIP_ERROR_SERVFAIL , __SXL_SIG_ERROR_SERVFAIL , __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Paul Bolle
Feb. 9, 2014, 3:09 p.m. UTC
Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4
camera interface - Build system") added a Kconfig entry for
VIDEO_OMAP4_DEBUG. But nothing uses that symbol.
This entry was apparently copied from a similar entry for "OMAP 3
Camera debug messages". But a corresponding Makefile line is missing.
Besides, the debug code also depends on a mysterious ISS_ISR_DEBUG
macro. This Kconfig entry can be removed.
Someone familiar with the code might be able to say what to do with the
code depending on the DEBUG and ISS_ISR_DEBUG macros.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested.
drivers/staging/media/omap4iss/Kconfig | 6 ------
1 file changed, 6 deletions(-)
Comments
Hi Paul, Thank you for the patch. On Sunday 09 February 2014 16:09:37 Paul Bolle wrote: > Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4 > camera interface - Build system") added a Kconfig entry for > VIDEO_OMAP4_DEBUG. But nothing uses that symbol. > > This entry was apparently copied from a similar entry for "OMAP 3 > Camera debug messages". But a corresponding Makefile line is missing. > Besides, the debug code also depends on a mysterious ISS_ISR_DEBUG > macro. This Kconfig entry can be removed. What about adding the associated Makefile line instead to #define DEBUG when VIDEO_OMAP4_DEBUG is selected, as with the OMAP3 ISP driver ? > Someone familiar with the code might be able to say what to do with the > code depending on the DEBUG and ISS_ISR_DEBUG macros. ISS_ISR_DEBUG is expected to be set by manually modifying the source code, as it prints lots of messages in interrupt context. > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > Untested. > > drivers/staging/media/omap4iss/Kconfig | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/staging/media/omap4iss/Kconfig > b/drivers/staging/media/omap4iss/Kconfig index b9fe753..78b0fba 100644 > --- a/drivers/staging/media/omap4iss/Kconfig > +++ b/drivers/staging/media/omap4iss/Kconfig > @@ -4,9 +4,3 @@ config VIDEO_OMAP4 > select VIDEOBUF2_DMA_CONTIG > ---help--- > Driver for an OMAP 4 ISS controller. > - > -config VIDEO_OMAP4_DEBUG > - bool "OMAP 4 Camera debug messages" > - depends on VIDEO_OMAP4 > - ---help--- > - Enable debug messages on OMAP 4 ISS controller driver.
Laurent, On Mon, 2014-02-10 at 15:13 +0100, Laurent Pinchart wrote: > On Sunday 09 February 2014 16:09:37 Paul Bolle wrote: > > Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4 > > camera interface - Build system") added a Kconfig entry for > > VIDEO_OMAP4_DEBUG. But nothing uses that symbol. > > > > This entry was apparently copied from a similar entry for "OMAP 3 > > Camera debug messages". But a corresponding Makefile line is missing. > > Besides, the debug code also depends on a mysterious ISS_ISR_DEBUG > > macro. This Kconfig entry can be removed. > > What about adding the associated Makefile line instead to #define DEBUG when > VIDEO_OMAP4_DEBUG is selected, as with the OMAP3 ISP driver ? > > > Someone familiar with the code might be able to say what to do with the > > code depending on the DEBUG and ISS_ISR_DEBUG macros. > > ISS_ISR_DEBUG is expected to be set by manually modifying the source code, as > it prints lots of messages in interrupt context. Which renders the DEBUG macro pointless. Or does the code use some dev_dbg()-like magic, which is only triggered if the DEBUG macro is set? Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Paul, On Monday 10 February 2014 16:13:51 Paul Bolle wrote: > On Mon, 2014-02-10 at 15:13 +0100, Laurent Pinchart wrote: > > On Sunday 09 February 2014 16:09:37 Paul Bolle wrote: > > > Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4 > > > camera interface - Build system") added a Kconfig entry for > > > VIDEO_OMAP4_DEBUG. But nothing uses that symbol. > > > > > > This entry was apparently copied from a similar entry for "OMAP 3 > > > Camera debug messages". But a corresponding Makefile line is missing. > > > Besides, the debug code also depends on a mysterious ISS_ISR_DEBUG > > > macro. This Kconfig entry can be removed. > > > > What about adding the associated Makefile line instead to #define DEBUG > > when VIDEO_OMAP4_DEBUG is selected, as with the OMAP3 ISP driver ? > > > > > Someone familiar with the code might be able to say what to do with the > > > code depending on the DEBUG and ISS_ISR_DEBUG macros. > > > > ISS_ISR_DEBUG is expected to be set by manually modifying the source code, > > as it prints lots of messages in interrupt context. > > Which renders the DEBUG macro pointless. Or does the code use some > dev_dbg()-like magic, which is only triggered if the DEBUG macro is set? Yes, dev_dbg() is used.
diff --git a/drivers/staging/media/omap4iss/Kconfig b/drivers/staging/media/omap4iss/Kconfig index b9fe753..78b0fba 100644 --- a/drivers/staging/media/omap4iss/Kconfig +++ b/drivers/staging/media/omap4iss/Kconfig @@ -4,9 +4,3 @@ config VIDEO_OMAP4 select VIDEOBUF2_DMA_CONTIG ---help--- Driver for an OMAP 4 ISS controller. - -config VIDEO_OMAP4_DEBUG - bool "OMAP 4 Camera debug messages" - depends on VIDEO_OMAP4 - ---help--- - Enable debug messages on OMAP 4 ISS controller driver.