Message ID | 4B2552A4.5090901@freemail.hu (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-path: <linux-media-owner@vger.kernel.org> Envelope-to: mchehab@infradead.org Delivery-date: Sun, 13 Dec 2009 20:46:36 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for <mchehab@localhost> (single-drop); Sun, 13 Dec 2009 18:52:47 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NJvKu-0004dP-8h; Sun, 13 Dec 2009 20:46:36 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753559AbZLMUqd (ORCPT <rfc822; kmpark@infradead.org> + 1 other); Sun, 13 Dec 2009 15:46:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753539AbZLMUqd (ORCPT <rfc822;linux-media-outgoing>); Sun, 13 Dec 2009 15:46:33 -0500 Received: from mail02d.mail.t-online.hu ([84.2.42.7]:61202 "HELO mail02d.mail.t-online.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753322AbZLMUqc convert rfc822-to-8bit (ORCPT <rfc822;linux-media@vger.kernel.org>); Sun, 13 Dec 2009 15:46:32 -0500 Received: from [192.168.1.64] (dsl5402C437.pool.t-online.hu [84.2.196.55]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail02d.mail.t-online.hu (Postfix) with ESMTPSA id 519D97588C7; Sun, 13 Dec 2009 21:45:27 +0100 (CET) Message-ID: <4B2552A4.5090901@freemail.hu> Date: Sun, 13 Dec 2009 21:46:28 +0100 From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= <nm127@freemail.hu> User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16 MIME-Version: 1.0 To: Hans Verkuil <hverkuil@xs4all.nl> CC: linux-media@vger.kernel.org Subject: Re: [cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS References: <200912131922.nBDJMMUm030337@smtp-vbr6.xs4all.nl> In-Reply-To: <200912131922.nBDJMMUm030337@smtp-vbr6.xs4all.nl> Content-Type: text/plain; charset=UTF-8 X-DCC-mail.t-online.hu-Metrics: mail02d.mail.t-online.hu 32711; Body=2 Fuz1=2 Fuz2=2 Content-Transfer-Encoding: 8BIT Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Commit Message
Németh Márton
Dec. 13, 2009, 8:46 p.m. UTC
Hans Verkuil wrote: > Detailed results are available here: > > http://www.xs4all.nl/~hverkuil/logs/Sunday.log >> linux-2.6.24.7-i686: ERRORS >> >> /marune/build/v4l-dvb-master/v4l/conex.c:1049: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__devinitconst' >> /marune/build/v4l-dvb-master/v4l/conex.c:1065: error: 'device_table' undeclared here (not in a function) >> make[3]: *** [/marune/build/v4l-dvb-master/v4l/conex.o] Error 1 >> make[3]: *** Waiting for unfinished jobs.... >> /marune/build/v4l-dvb-master/v4l/etoms.c:873: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__devinitconst' >> /marune/build/v4l-dvb-master/v4l/etoms.c:893: error: 'device_table' undeclared here (not in a function) >> make[3]: *** [/marune/build/v4l-dvb-master/v4l/etoms.o] Error 1 >> make[2]: *** [_module_/marune/build/v4l-dvb-master/v4l] Error 2 >> make[2]: Leaving directory `/marune/build/trees/i686/linux-2.6.24.7' >> make[1]: *** [default] Error 2 >> make[1]: Leaving directory `/marune/build/v4l-dvb-master/v4l' >> make: *** [all] Error 2 >> Sun Dec 13 19:13:59 CET 2009 It seems that kernels before 2.6.24 (inclusively) do not have "__devinitconst", so conex.c and etoms.c can only build with 2.6.25 and later. Should USB_GSPCA_CONEX and USB_GSPCA_ETOMS be added to v4l/versions.txt? --- From: Márton Németh <nm127@freemail.hu> The conex and etoms drivers only build with kernel version 2.6.25 and later. Signed-off-by: Márton Németh <nm127@freemail.hu> --- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
On Sun, 13 Dec 2009 21:46:28 +0100 Németh Márton <nm127@freemail.hu> wrote: > It seems that kernels before 2.6.24 (inclusively) do not have > "__devinitconst", so conex.c and etoms.c can only build with 2.6.25 > and later. Should USB_GSPCA_CONEX and USB_GSPCA_ETOMS be added to > v4l/versions.txt? The fix is not the right one. Some other gspca subdrivers use "__devinitconst" (pac7302, pac7311, sonixb and spca506). The fix is to define the macro for kernels < 2.6.25: diff -r 174ad3097f17 linux/drivers/media/video/gspca/gspca.h --- a/linux/drivers/media/video/gspca/gspca.h Sun Dec 13 18:11:07 2009 +0100 +++ b/linux/drivers/media/video/gspca/gspca.h Mon Dec 14 09:28:51 2009 +0100 @@ -11,6 +11,10 @@ /* compilation option */ #define GSPCA_DEBUG 1 +#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 25) +#define __devinitconst __section(.devinit.rodata) +#endif + #ifdef GSPCA_DEBUG /* GSPCA our debug messages */ extern int gspca_debug; I will ask to upload the changeset (actually in my test repository) as soon as it is validated (i.e. if it works with hal).
Jean-Francois Moine wrote: > On Sun, 13 Dec 2009 21:46:28 +0100 > Németh Márton <nm127@freemail.hu> wrote: > >> It seems that kernels before 2.6.24 (inclusively) do not have >> "__devinitconst", so conex.c and etoms.c can only build with 2.6.25 >> and later. Should USB_GSPCA_CONEX and USB_GSPCA_ETOMS be added to >> v4l/versions.txt? > > The fix is not the right one. Some other gspca subdrivers use > "__devinitconst" (pac7302, pac7311, sonixb and spca506). The fix is to > define the macro for kernels < 2.6.25: > > diff -r 174ad3097f17 linux/drivers/media/video/gspca/gspca.h > --- a/linux/drivers/media/video/gspca/gspca.h Sun Dec 13 18:11:07 > 2009 +0100 > +++ b/linux/drivers/media/video/gspca/gspca.h Mon Dec 14 09:28:51 > 2009 +0100 @@ -11,6 +11,10 @@ /* compilation option */ > #define GSPCA_DEBUG 1 > > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 25) > +#define __devinitconst __section(.devinit.rodata) > +#endif > + Better to add it at v4l/compat.h, to avoid polluting the drivers with compat code. Cheers Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -r e2f13778b5dc v4l/versions.txt --- a/v4l/versions.txt Sat Dec 12 17:25:43 2009 +0100 +++ b/v4l/versions.txt Sun Dec 13 21:40:58 2009 +0100 @@ -54,6 +54,11 @@ RADIO_SI4713 I2C_SI4713 +[2.6.25] +# The drivers uses "__devinitconst" +USB_GSPCA_CONEX +USB_GSPCA_ETOMS + [2.6.24] # Some freezer routines USB_GSPCA_SN9C20X_EVDEV