Message ID | CAPgLHd-0+fYLMh+Ff+cgewBPy1itjp-EtbAjzs5UrJsqrY3aNg@mail.gmail.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1VChbe-0001rG-5K; Fri, 23 Aug 2013 05:00:10 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1VChbc-0005RD-jw; Fri, 23 Aug 2013 05:00:10 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753958Ab3HWDAF (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 22 Aug 2013 23:00:05 -0400 Received: from mail-bk0-f42.google.com ([209.85.214.42]:61009 "EHLO mail-bk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752763Ab3HWDAD (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 22 Aug 2013 23:00:03 -0400 Received: by mail-bk0-f42.google.com with SMTP id my10so31305bkb.29 for <linux-media@vger.kernel.org>; Thu, 22 Aug 2013 20:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=MYLPQIloLxLAEU6mX/tzoYnZ+Q+Yhba8XSM3FHX2VhU=; b=lizebNCQyOUsAe1h2CGFUbwu7Lm2MsIpT1Ix7g8pYADxwAzG12CwpKIHERGhE1ddbC EmvjPSo2rgWuqdq+gMwTkmzXOvPeGatF8On22Pq6IaB7JdWwvmOtxrLgtkwAofovYz+1 RCoEEmmWT8aYgs32UkBplFgf345XSviQ4eRksU+UaITAZV+BtFgal7ZNu9mBq0TtBa13 01U3fkUJbaxsN+by5j7aQ36wDkULnZURFhlX+JTBXnduvByfVB1zScWgXR9gpvZUInIU SHPnCSd0yBSaxk43a0BdjDGlSIypSD9Z0quiBWCcw3qk2KsxORmKQLLpcfgDlkcUM8mE gFgw== MIME-Version: 1.0 X-Received: by 10.205.120.78 with SMTP id fx14mr12992216bkc.7.1377226801816; Thu, 22 Aug 2013 20:00:01 -0700 (PDT) Received: by 10.205.13.74 with HTTP; Thu, 22 Aug 2013 20:00:01 -0700 (PDT) Date: Fri, 23 Aug 2013 11:00:01 +0800 Message-ID: <CAPgLHd-0+fYLMh+Ff+cgewBPy1itjp-EtbAjzs5UrJsqrY3aNg@mail.gmail.com> Subject: [PATCH -next] [media] davinci: vpif_capture: fix error return code in vpif_probe() From: Wei Yongjun <weiyj.lk@gmail.com> To: prabhakar.csengg@gmail.com, m.chehab@samsung.com Cc: yongjun_wei@trendmicro.com.cn, linux-media@vger.kernel.org, davinci-linux-open-source@linux.davincidsp.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.8.23.25128 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' CN_TLD 0.1, FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __DATE_TZ_HK 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Wei Yongjun
Aug. 23, 2013, 3 a.m. UTC
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Fix to return -ENODEV in the subdevice register error handling case instead of 0, as done elsewhere in this function. Introduced by commit 873229e4fdf34196aa5d707957c59ba54c25eaba ([media] media: davinci: vpif: capture: add V4L2-async support) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> --- drivers/media/platform/davinci/vpif_capture.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
Hi Wei, Thanks for the patch. On Fri, Aug 23, 2013 at 8:30 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fix to return -ENODEV in the subdevice register error handling > case instead of 0, as done elsewhere in this function. > > Introduced by commit 873229e4fdf34196aa5d707957c59ba54c25eaba > ([media] media: davinci: vpif: capture: add V4L2-async support) > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Wei, I retract my Ack. On Fri, Aug 23, 2013 at 8:30 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fix to return -ENODEV in the subdevice register error handling > case instead of 0, as done elsewhere in this function. > > Introduced by commit 873229e4fdf34196aa5d707957c59ba54c25eaba > ([media] media: davinci: vpif: capture: add V4L2-async support) > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > drivers/media/platform/davinci/vpif_capture.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c > index 7fbde6d..e4b6a26 100644 > --- a/drivers/media/platform/davinci/vpif_capture.c > +++ b/drivers/media/platform/davinci/vpif_capture.c > @@ -2160,6 +2160,7 @@ static __init int vpif_probe(struct platform_device *pdev) > > if (!vpif_obj.sd[i]) { > vpif_err("Error registering v4l2 subdevice\n"); > + err = -ENOMEM; This should be err = -ENODEV Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Wei, On Fri, Aug 23, 2013 at 8:50 AM, Prabhakar Lad <prabhakar.csengg@gmail.com> wrote: > Hi Wei, > > I retract my Ack. > > On Fri, Aug 23, 2013 at 8:30 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote: >> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> >> >> Fix to return -ENODEV in the subdevice register error handling >> case instead of 0, as done elsewhere in this function. >> >> Introduced by commit 873229e4fdf34196aa5d707957c59ba54c25eaba >> ([media] media: davinci: vpif: capture: add V4L2-async support) >> >> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> >> --- >> drivers/media/platform/davinci/vpif_capture.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c >> index 7fbde6d..e4b6a26 100644 >> --- a/drivers/media/platform/davinci/vpif_capture.c >> +++ b/drivers/media/platform/davinci/vpif_capture.c >> @@ -2160,6 +2160,7 @@ static __init int vpif_probe(struct platform_device *pdev) >> >> if (!vpif_obj.sd[i]) { >> vpif_err("Error registering v4l2 subdevice\n"); >> + err = -ENOMEM; > > This should be err = -ENODEV > I assume you will fix it and repost this patch. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index 7fbde6d..e4b6a26 100644 --- a/drivers/media/platform/davinci/vpif_capture.c +++ b/drivers/media/platform/davinci/vpif_capture.c @@ -2160,6 +2160,7 @@ static __init int vpif_probe(struct platform_device *pdev) if (!vpif_obj.sd[i]) { vpif_err("Error registering v4l2 subdevice\n"); + err = -ENOMEM; goto probe_subdev_out; } v4l2_info(&vpif_obj.v4l2_dev,