| Message ID | 521C5493.1050407@cisco.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1VEDfR-0005cM-LQ; Tue, 27 Aug 2013 09:26:21 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1VEDfP-00010K-l3; Tue, 27 Aug 2013 09:26:21 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752739Ab3H0H0R (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Tue, 27 Aug 2013 03:26:17 -0400 Received: from ams-iport-1.cisco.com ([144.254.224.140]:30770 "EHLO ams-iport-1.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466Ab3H0H0Q (ORCPT <rfc822;linux-media@vger.kernel.org>); Tue, 27 Aug 2013 03:26:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=740; q=dns/txt; s=iport; t=1377588376; x=1378797976; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; bh=H1mjvpScVU4r3tTizc09Y7GEs0lW96v7xymOMHhaKog=; b=DiTVXp/sOmJWTLQJtihMBO/dafyLenLkhDSKrubgcFWAlibxOuFFqTKo 5BZ5GngEXVxqL+ZQvNmeFedfacq4Sy6SK+quLk+5BCgFLb3SGsaio67VY SwXeNV/onHtiFOQkv4RKqwAECtJBX2AvVFZ0YYckwpbfITEdX2TX2y4Z1 I=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AggFAOFTHFKQ/khR/2dsb2JhbABagwe+N4J5gSQWdIIkAQEBBHgBEAsYCRYPCQMCAQIBRQYNAQcCh324FJB3B4QZA5duhiqLN4MgOg X-IronPort-AV: E=Sophos;i="4.89,966,1367971200"; d="scan'208";a="158932058" Received: from ams-core-1.cisco.com ([144.254.72.81]) by ams-iport-1.cisco.com with ESMTP; 27 Aug 2013 07:26:14 +0000 Received: from [10.61.81.153] (ams3-vpn-dhcp4506.cisco.com [10.61.81.153]) (authenticated bits=0) by ams-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id r7R7QB4O030003 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 27 Aug 2013 07:26:12 GMT Message-ID: <521C5493.1050407@cisco.com> Date: Tue, 27 Aug 2013 09:26:11 +0200 From: Hans Verkuil <hansverk@cisco.com> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130821 Icedove/17.0.8 MIME-Version: 1.0 To: Knut Petersen <Knut_Petersen@t-online.de> CC: Mauro Carvalho Chehab <mchehab@infradead.org>, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [REGRESSION 3.11-rc] wm8775 9-001b: I2C: cannot write ??? to register R?? References: <521A269D.3020909@t-online.de> In-Reply-To: <521A269D.3020909@t-online.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Authenticated-User: hansverk Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.8.27.71816 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FORWARDED_MSG 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MOZILLA_USER_AGENT 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' |
Commit Message
Hans Verkuil (hansverk)
Aug. 27, 2013, 7:26 a.m. UTC
On 08/25/2013 05:45 PM, Knut Petersen wrote: > Booting current git kernel dmesg shows a set of new warnings: > > "wm8775 9-001b: I2C: cannot write ??? to register R??" > > Nevertheless, the hardware seems to work fine. > > This is a new problem, introduced after kernel 3.10. > If necessary I can bisect. Can you try this patch? I'm pretty sure this will fix it. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Comments
On 27.08.2013 09:26, Hans Verkuil wrote: > On 08/25/2013 05:45 PM, Knut Petersen wrote: >> Booting current git kernel dmesg shows a set of new warnings: >> >> "wm8775 9-001b: I2C: cannot write ??? to register R??" >> >> Nevertheless, the hardware seems to work fine. >> >> This is a new problem, introduced after kernel 3.10. >> If necessary I can bisect. > Can you try this patch? I'm pretty sure this will fix it. Indeed, it does cure the problem. Thanks. Tested-by: Knut Petersen <Knut_Petersen@t-online.de> > > Regards, > > Hans > > diff --git a/drivers/media/pci/cx88/cx88.h b/drivers/media/pci/cx88/cx88.h > index afe0eae..28893a6 100644 > --- a/drivers/media/pci/cx88/cx88.h > +++ b/drivers/media/pci/cx88/cx88.h > @@ -259,7 +259,7 @@ struct cx88_input { > }; > > enum cx88_audio_chip { > - CX88_AUDIO_WM8775, > + CX88_AUDIO_WM8775 = 1, > CX88_AUDIO_TVAUDIO, > }; > > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/27/2013 11:35 AM, Knut Petersen wrote: > On 27.08.2013 09:26, Hans Verkuil wrote: >> On 08/25/2013 05:45 PM, Knut Petersen wrote: >>> Booting current git kernel dmesg shows a set of new warnings: >>> >>> "wm8775 9-001b: I2C: cannot write ??? to register R??" >>> >>> Nevertheless, the hardware seems to work fine. >>> >>> This is a new problem, introduced after kernel 3.10. >>> If necessary I can bisect. >> Can you try this patch? I'm pretty sure this will fix it. > > Indeed, it does cure the problem. Thanks. > > Tested-by: Knut Petersen <Knut_Petersen@t-online.de> Thanks for testing this! I've posted the pull request for this. Hopefully it will make 3.11 before it is released. Regards, Hans > > >> >> Regards, >> >> Hans >> >> diff --git a/drivers/media/pci/cx88/cx88.h b/drivers/media/pci/cx88/cx88.h >> index afe0eae..28893a6 100644 >> --- a/drivers/media/pci/cx88/cx88.h >> +++ b/drivers/media/pci/cx88/cx88.h >> @@ -259,7 +259,7 @@ struct cx88_input { >> }; >> enum cx88_audio_chip { >> - CX88_AUDIO_WM8775, >> + CX88_AUDIO_WM8775 = 1, >> CX88_AUDIO_TVAUDIO, >> }; >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 27.08.2013 11:51, Hans Verkuil wrote: > On 08/27/2013 11:35 AM, Knut Petersen wrote: >> On 27.08.2013 09:26, Hans Verkuil wrote: >>> On 08/25/2013 05:45 PM, Knut Petersen wrote: >>>> Booting current git kernel dmesg shows a set of new warnings: >>>> >>>> "wm8775 9-001b: I2C: cannot write ??? to register R??" >>>> >>>> Nevertheless, the hardware seems to work fine. >>>> >>>> This is a new problem, introduced after kernel 3.10. >>>> If necessary I can bisect. >>> Can you try this patch? I'm pretty sure this will fix it. >> Indeed, it does cure the problem. Thanks. >> >> Tested-by: Knut Petersen <Knut_Petersen@t-online.de> > Thanks for testing this! I've posted the pull request for this. > Hopefully it will make 3.11 before it is released. As I wrote in the initial bug report, the problem has been introduced _after_ kernel 3.10, facd23664f1d63c33fbc6da52261c8548ed3fbd4 is _not_ part of kernel 3.10.x Therefore the CC to stable@vger.kernel.org for v3.10 in b9a1dfd3ba3ae00b0c1d1a396ed43fac85a32990 is wrong. cu, Knut > Regards, > > Hans > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Linus! It would be nice to have head cx88fix of git.linuxtv.org/hverkuil/media_tree.git (git.linuxtv.org/hverkuil/media_tree.git/commit/5dce3635bf803cfe9dde84e00f5f9594439e6c02) in 3.11 as it is a trivial and tested fix for a regression introduced between 3.10 and 3.11-rc1. see http://www.gossamer-threads.com/lists/linux/kernel/1771751?#1771751 cu, Knut -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Aug 31, 2013 at 1:00 AM, Knut Petersen <Knut_Petersen@t-online.de> wrote: > Hi Linus! > > It would be nice to have head cx88fix of > git.linuxtv.org/hverkuil/media_tree.git > (git.linuxtv.org/hverkuil/media_tree.git/commit/5dce3635bf803cfe9dde84e00f5f9594439e6c02) > in 3.11 as it is a trivial and tested fix for a regression introduced > between 3.10 and 3.11-rc1. I can't take partial pull requests - I can take individual patches from email (with proper sign-off chains etc, of course), but I don't do "take this patch from this git tree". Git pulls need to go through the tree owner and with all the normal pull request rules, and the rest of that tree doesn't look critical. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/pci/cx88/cx88.h b/drivers/media/pci/cx88/cx88.h index afe0eae..28893a6 100644 --- a/drivers/media/pci/cx88/cx88.h +++ b/drivers/media/pci/cx88/cx88.h @@ -259,7 +259,7 @@ struct cx88_input { }; enum cx88_audio_chip { - CX88_AUDIO_WM8775, + CX88_AUDIO_WM8775 = 1, CX88_AUDIO_TVAUDIO, };