| Message ID | 1377532073-12864-1-git-send-email-s.nawrocki@samsung.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Sylwester Nawrocki |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1VDz27-0003er-9w; Mon, 26 Aug 2013 17:48:47 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-7) with esmtp id 1VDz25-0000kq-1O; Mon, 26 Aug 2013 17:48:47 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752191Ab3HZPsn (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Mon, 26 Aug 2013 11:48:43 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:42594 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751909Ab3HZPsn (ORCPT <rfc822;linux-media@vger.kernel.org>); Mon, 26 Aug 2013 11:48:43 -0400 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MS500KG3AL55060@mailout2.samsung.com> for linux-media@vger.kernel.org; Tue, 27 Aug 2013 00:48:41 +0900 (KST) X-AuditID: cbfee61b-b7f776d0000016c8-6a-521b78d9ea13 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id E3.F4.05832.9D87B125; Tue, 27 Aug 2013 00:48:41 +0900 (KST) Received: from amdc1344.digital.local ([106.116.147.32]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MS5009O5AKWQ270@mmp2.samsung.com>; Tue, 27 Aug 2013 00:48:41 +0900 (KST) From: Sylwester Nawrocki <s.nawrocki@samsung.com> To: linux-media@vger.kernel.org Cc: m.szyprowski@samsung.com, pawel@osciak.com, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, m.chehab@samsung.com, Sylwester Nawrocki <s.nawrocki@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com> Subject: [PATCH] vb2: Add debug print for the output buffer planes lengths checks Date: Mon, 26 Aug 2013 17:47:53 +0200 Message-id: <1377532073-12864-1-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPJMWRmVeSWpSXmKPExsVy+t9jQd2bFdJBBl+uqlks+bmLyeJs0xt2 i86JS9gtejZsZbW4uE7eYu2Ru+wWU97+ZLc4/Kad1YHDY8rvjawesztmsno8/vWSzaNvyypG j8+b5AJYo7hsUlJzMstSi/TtErgyTr+7y1bwjb3iwvIXjA2M59m6GDk4JARMJCbNC+5i5AQy xSQu3FsPFObiEBKYzijxeM9iZging0libvdRNpAqNgFDid6jfYwgtoiAvMST3htgHcwCdxkl Tn/YyA6SEBYIlli8/joTiM0ioCqxtPcGM4jNK+Am0bLhH9RmBYk5k2wmMHIvYGRYxSiaWpBc UJyUnmukV5yYW1yal66XnJ+7iREcLM+kdzCuarA4xCjAwajEwxvAJh0kxJpYVlyZe4hRgoNZ SYSXIxUoxJuSWFmVWpQfX1Sak1p8iFGag0VJnPdgq3WgkEB6YklqdmpqQWoRTJaJg1OqgZEx cW2r15zHXD8O1388ODuDK9v0Y9cNNvaEdTFsihdMGML2eTB9OTtjllDJAzVuroTpj2/lzWOc cDx+7+bXglv2NzZ6n/FZPv19gMS/uBz9l5554Sbse14t2Sbb7CMQJPd25o7EmOtBoosjFY6f b2D9WXisu+rkAwFvm7eqYVmndvdXfow7+FOJpTgj0VCLuag4EQAjr/ryEgIAAA== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.8.26.143028 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Sylwester Nawrocki
Aug. 26, 2013, 3:47 p.m. UTC
Add debug print so it's easier to find any errors resulting from the planes' configuration checks added in commit 8023ed09cb278004a2 "videobuf2-core: Verify planes lengths for output buffers". Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- drivers/media/v4l2-core/videobuf2-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Comments
Hi Sylwester, Thank you for the patch. On Monday 26 August 2013 17:47:53 Sylwester Nawrocki wrote: > Add debug print so it's easier to find any errors resulting from > the planes' configuration checks added in commit 8023ed09cb278004a2 > "videobuf2-core: Verify planes lengths for output buffers". > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/v4l2-core/videobuf2-core.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/videobuf2-core.c > b/drivers/media/v4l2-core/videobuf2-core.c index de0e87f..6bffc96 100644 > --- a/drivers/media/v4l2-core/videobuf2-core.c > +++ b/drivers/media/v4l2-core/videobuf2-core.c > @@ -1205,8 +1205,11 @@ static int __buf_prepare(struct vb2_buffer *vb, const > struct v4l2_buffer *b) int ret; > > ret = __verify_length(vb, b); > - if (ret < 0) > + if (ret < 0) { > + dprintk(1, "%s(): plane parameters verification failed: %d\n", > + __func__, ret); > return ret; > + } > > switch (q->memory) { > case V4L2_MEMORY_MMAP:
Hello, On 8/26/2013 5:47 PM, Sylwester Nawrocki wrote: > Add debug print so it's easier to find any errors resulting from > the planes' configuration checks added in commit 8023ed09cb278004a2 > "videobuf2-core: Verify planes lengths for output buffers". > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> Acked-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/media/v4l2-core/videobuf2-core.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c > index de0e87f..6bffc96 100644 > --- a/drivers/media/v4l2-core/videobuf2-core.c > +++ b/drivers/media/v4l2-core/videobuf2-core.c > @@ -1205,8 +1205,11 @@ static int __buf_prepare(struct vb2_buffer *vb, const struct v4l2_buffer *b) > int ret; > > ret = __verify_length(vb, b); > - if (ret < 0) > + if (ret < 0) { > + dprintk(1, "%s(): plane parameters verification failed: %d\n", > + __func__, ret); > return ret; > + } > > switch (q->memory) { > case V4L2_MEMORY_MMAP: Best regards
diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index de0e87f..6bffc96 100644 --- a/drivers/media/v4l2-core/videobuf2-core.c +++ b/drivers/media/v4l2-core/videobuf2-core.c @@ -1205,8 +1205,11 @@ static int __buf_prepare(struct vb2_buffer *vb, const struct v4l2_buffer *b) int ret; ret = __verify_length(vb, b); - if (ret < 0) + if (ret < 0) { + dprintk(1, "%s(): plane parameters verification failed: %d\n", + __func__, ret); return ret; + } switch (q->memory) { case V4L2_MEMORY_MMAP: