| Message ID | 1374677852-2006-1-git-send-email-s.nawrocki@samsung.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Sylwester Nawrocki |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1V20Vi-00025e-Em; Wed, 24 Jul 2013 16:57:50 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-8) with esmtp id 1V20Vg-0004uy-ky; Wed, 24 Jul 2013 16:57:50 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753563Ab3GXO5p (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 24 Jul 2013 10:57:45 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:35883 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753548Ab3GXO5n (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 24 Jul 2013 10:57:43 -0400 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MQG009AM47KQN80@mailout2.samsung.com> for linux-media@vger.kernel.org; Wed, 24 Jul 2013 23:57:41 +0900 (KST) X-AuditID: cbfee61b-b7efe6d000007b11-74-51efeb65b478 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id B3.26.31505.56BEFE15; Wed, 24 Jul 2013 23:57:41 +0900 (KST) Received: from amdc1344.digital.local ([106.116.147.32]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MQG008KO47Y2S40@mmp1.samsung.com>; Wed, 24 Jul 2013 23:57:41 +0900 (KST) From: Sylwester Nawrocki <s.nawrocki@samsung.com> To: linux-media@vger.kernel.org Cc: Andrzej Hajda <a.hajda@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, Sylwester Nawrocki <s.nawrocki@samsung.com> Subject: [PATCH] V4L: s5c73m3: Add format propagation for TRY formats Date: Wed, 24 Jul 2013 16:57:32 +0200 Message-id: <1374677852-2006-1-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNJMWRmVeSWpSXmKPExsVy+t9jAd3U1+8DDebfVLa4te4cq8XZpjfs Fj0btrJaHH7TzurA4tG3ZRWjx+dNcgFMUVw2Kak5mWWpRfp2CVwZndP5Cv5zVMxf8I21gfEk excjJ4eEgIlE/71OFghbTOLCvfVsILaQwCJGiXmfSroYuYDsDiaJSRfbWUESbAKGEr1H+xhB bBEBeYknvTfAGpgFmhklFh4OA7GFBVwllh7ZAzaURUBVYsHdf2A2L1C88ddSoDkcQMsUJOZM spnAyL2AkWEVo2hqQXJBcVJ6rpFecWJucWleul5yfu4mRrCXn0nvYFzVYHGIUYCDUYmHt2DW u0Ah1sSy4srcQ4wSHMxKIrxvH7wPFOJNSaysSi3Kjy8qzUktPsQozcGiJM57sNU6UEggPbEk NTs1tSC1CCbLxMEp1cAYKbpjH3PkvLpfCtv82jw/HfdRZciU1Fq3tcO7Iiv1UMd7+WPiMu+j /wtb71x+YJGSMtf1xVFbZmVZpVbPbXsQbaLTJ7P11XzvBCnb7cXmAe9bt6dNtsvbc+3h+py/ /zyZCqPXVv6b8PTuEomn3mfy1/d+8At7FmRcHBVVscZaLnRzgOudJ3eUWIozEg21mIuKEwEY wOt87gEAAA== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.7.24.145122 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' HTML_NO_HTTP 0.1, MULTIPLE_RCPTS 0.1, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1300_1399 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_HTML 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Sylwester Nawrocki
July 24, 2013, 2:57 p.m. UTC
From: Andrzej Hajda <a.hajda@samsung.com> Resolution set on ISP pad of S5C73M3-OIF subdev should be propagated to source pad for TRY and ACTIVE formats. The patch adds missing propagation for TRY format. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- drivers/media/i2c/s5c73m3/s5c73m3-core.c | 5 +++++ 1 file changed, 5 insertions(+)
Comments
Hello, On Wednesday 24 July 2013 16:57:32 Sylwester Nawrocki wrote: > From: Andrzej Hajda <a.hajda@samsung.com> > > Resolution set on ISP pad of S5C73M3-OIF subdev should be > propagated to source pad for TRY and ACTIVE formats. > The patch adds missing propagation for TRY format. I might be missing something, but where's the propagation for the ACTIVE format ? > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > drivers/media/i2c/s5c73m3/s5c73m3-core.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c > b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index 825ea86..b76ec0e 100644 > --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c > +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c > @@ -1111,6 +1111,11 @@ static int s5c73m3_oif_set_fmt(struct v4l2_subdev > *sd, if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) { > mf = v4l2_subdev_get_try_format(fh, fmt->pad); > *mf = fmt->format; > + if (fmt->pad == OIF_ISP_PAD) { > + mf = v4l2_subdev_get_try_format(fh, OIF_SOURCE_PAD); > + mf->width = fmt->format.width; > + mf->height = fmt->format.height; > + } > } else { > switch (fmt->pad) { > case OIF_ISP_PAD:
Hi Laurent, Thank you for the review. On 08/09/2013 12:58 AM, Laurent Pinchart wrote: > Hello, > > On Wednesday 24 July 2013 16:57:32 Sylwester Nawrocki wrote: >> From: Andrzej Hajda <a.hajda@samsung.com> >> >> Resolution set on ISP pad of S5C73M3-OIF subdev should be >> propagated to source pad for TRY and ACTIVE formats. >> The patch adds missing propagation for TRY format. > I might be missing something, but where's the propagation for the ACTIVE > format ? In case of active format there are no separate containers for the format of each pad, instead they shares common fields, precisely .oif_pix_size and .mbus_code. This way there is no need for extra code for format propagation. Regards Andrzej > >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> >> --- >> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c >> b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index 825ea86..b76ec0e 100644 >> --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c >> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c >> @@ -1111,6 +1111,11 @@ static int s5c73m3_oif_set_fmt(struct v4l2_subdev >> *sd, if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) { >> mf = v4l2_subdev_get_try_format(fh, fmt->pad); >> *mf = fmt->format; >> + if (fmt->pad == OIF_ISP_PAD) { >> + mf = v4l2_subdev_get_try_format(fh, OIF_SOURCE_PAD); >> + mf->width = fmt->format.width; >> + mf->height = fmt->format.height; >> + } >> } else { >> switch (fmt->pad) { >> case OIF_ISP_PAD: -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Andrzej, On Friday 09 August 2013 08:24:10 Andrzej Hajda wrote: > On 08/09/2013 12:58 AM, Laurent Pinchart wrote: > > On Wednesday 24 July 2013 16:57:32 Sylwester Nawrocki wrote: > >> From: Andrzej Hajda <a.hajda@samsung.com> > >> > >> Resolution set on ISP pad of S5C73M3-OIF subdev should be > >> propagated to source pad for TRY and ACTIVE formats. > >> The patch adds missing propagation for TRY format. > > > > I might be missing something, but where's the propagation for the ACTIVE > > format ? > > In case of active format there are no separate containers > for the format of each pad, instead they shares common fields, > precisely .oif_pix_size and .mbus_code. > This way there is no need for extra code for format propagation. I got confused by the s5c73m3_oif_get_fmt() implementation that retrieves the pixel code and frame size from different internal state fields for the soruce pad. The code looks correct. > >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > >> --- > >> > >> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c > >> b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index 825ea86..b76ec0e 100644 > >> --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c > >> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c > >> @@ -1111,6 +1111,11 @@ static int s5c73m3_oif_set_fmt(struct v4l2_subdev > >> *sd, if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) { > >> > >> mf = v4l2_subdev_get_try_format(fh, fmt->pad); > >> *mf = fmt->format; > >> > >> + if (fmt->pad == OIF_ISP_PAD) { > >> + mf = v4l2_subdev_get_try_format(fh, OIF_SOURCE_PAD); > >> + mf->width = fmt->format.width; > >> + mf->height = fmt->format.height; > >> + } > >> > >> } else { > >> > >> switch (fmt->pad) { > >> case OIF_ISP_PAD:
diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index 825ea86..b76ec0e 100644 --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c @@ -1111,6 +1111,11 @@ static int s5c73m3_oif_set_fmt(struct v4l2_subdev *sd, if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) { mf = v4l2_subdev_get_try_format(fh, fmt->pad); *mf = fmt->format; + if (fmt->pad == OIF_ISP_PAD) { + mf = v4l2_subdev_get_try_format(fh, OIF_SOURCE_PAD); + mf->width = fmt->format.width; + mf->height = fmt->format.height; + } } else { switch (fmt->pad) { case OIF_ISP_PAD: