Add new TV cards of Beholder

Message ID 20091110133743.21cb7dc5@glory.loctelecom.ru (mailing list archive)
State Superseded, archived
Headers

Commit Message

Dmitri Belimov Nov. 10, 2009, 4:37 a.m. UTC
  Hi All

Add new TV cards of Beholder for autodetect.

Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov <d.belimov@gmail.com>

With my best regards, Dmitry.
  

Comments

Mauro Carvalho Chehab Nov. 23, 2009, 9:28 p.m. UTC | #1
Hi Dmitri,

I added this patch, but the driver is essentially broken. It would
be wonderful if you have some time to fix it.

Cheers,
Mauro.

Dmitri Belimov wrote:
> Hi All
> 
> Add new TV cards of Beholder for autodetect.
> 
> diff -r 3919b17dc88e linux/drivers/staging/tm6000/tm6000-cards.c
> --- a/linux/drivers/staging/tm6000/tm6000-cards.c	Wed Oct 14 12:52:55 2009 -0300
> +++ b/linux/drivers/staging/tm6000/tm6000-cards.c	Tue Nov 10 08:05:15 2009 +0900
> @@ -33,6 +33,7 @@
>  #include "tm6000.h"
>  #include "tm6000-regs.h"
>  #include "tuner-xc2028.h"
> +#include "tuner-xc5000.h"
>  
>  #define TM6000_BOARD_UNKNOWN			0
>  #define TM5600_BOARD_GENERIC			1
> @@ -193,6 +194,36 @@
>  		},
>  		.gpio_addr_tun_reset = TM6000_GPIO_2,
>  	},
> +	[TM6010_BOARD_BEHOLD_WANDER] = {
> +		.name         = "Beholder Wander DVB-T/TV/FM USB2.0",
> +		.tuner_type   = TUNER_XC5000,
> +		.tuner_addr   = 0xc2 >> 1,
> +		.demod_addr   = 0x1e >> 1,
> +		.type         = TM6010,
> +		.caps = {
> +			.has_tuner    = 1,
> +			.has_dvb      = 1,
> +			.has_zl10353  = 1,
> +			.has_eeprom   = 1,
> +			.has_remote   = 1,
> +		},
> +		.gpio_addr_tun_reset = TM6000_GPIO_2,
> +	},
> +	[TM6010_BOARD_BEHOLD_VOYAGER] = {
> +		.name         = "Beholder Voyager TV/FM USB2.0",
> +		.tuner_type   = TUNER_XC5000,
> +		.tuner_addr   = 0xc2 >> 1,
> +		.type         = TM6010,
> +		.caps = {
> +			.has_tuner    = 1,
> +			.has_dvb      = 0,
> +			.has_zl10353  = 0,
> +			.has_eeprom   = 1,
> +			.has_remote   = 1,
> +		},
> +		.gpio_addr_tun_reset = TM6000_GPIO_2,
> +	},
> +
>  };
>  
>  /* table of devices that work with this driver */
> @@ -203,6 +234,8 @@
>  	{ USB_DEVICE(0x14aa, 0x0620), .driver_info = TM6000_BOARD_FREECOM_AND_SIMILAR },
>  	{ USB_DEVICE(0x06e1, 0xb339), .driver_info = TM6000_BOARD_ADSTECH_MINI_DUAL_TV },
>  	{ USB_DEVICE(0x2040, 0x6600), .driver_info = TM6010_BOARD_HAUPPAUGE_900H },
> +	{ USB_DEVICE(0x6000, 0xdec0), .driver_info = TM6010_BOARD_BEHOLD_WANDER },
> +	{ USB_DEVICE(0x6000, 0xdec1), .driver_info = TM6010_BOARD_BEHOLD_VOYAGER },
>  	{ },
>  };
>  
> Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov <d.belimov@gmail.com>
> 
> With my best regards, Dmitry.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  
Devin Heitmueller Nov. 23, 2009, 9:39 p.m. UTC | #2
On Mon, Nov 23, 2009 at 4:28 PM, Mauro Carvalho Chehab
<mchehab@redhat.com> wrote:
> Hi Dmitri,
>
> I added this patch, but the driver is essentially broken. It would
> be wonderful if you have some time to fix it.
>
> Cheers,
> Mauro.

Yeah, I saw his patch and was wondering why on Earth he submitted a
patch adding card support for a completely broken driver.  How could
he have validated the patch is correct?

Devin
  
Dmitri Belimov Nov. 24, 2009, 6:40 a.m. UTC | #3
Hi

Working tm6000 driver is my next task. I'll start with tm6000 around New Year.

With my best regards, Dmitry.

> On Mon, Nov 23, 2009 at 4:28 PM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
> > Hi Dmitri,
> >
> > I added this patch, but the driver is essentially broken. It would
> > be wonderful if you have some time to fix it.
> >
> > Cheers,
> > Mauro.
> 
> Yeah, I saw his patch and was wondering why on Earth he submitted a
> patch adding card support for a completely broken driver.  How could
> he have validated the patch is correct?
> 
> Devin
> 
> -- 
> Devin J. Heitmueller - Kernel Labs
> http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  
Dmitri Belimov Jan. 12, 2010, 8:24 a.m. UTC | #4
Hi

Who is maintainer of the tm6000 module??

With my best regards, Dmitry.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  
Mauro Carvalho Chehab Jan. 12, 2010, 11:50 a.m. UTC | #5
Dmitri Belimov wrote:
> Hi
> 
> Who is maintainer of the tm6000 module??
> 
> With my best regards, Dmitry.
I wrote it, although I'm currently lacking time to fix the bugs.
Feel free to fix if you want. I have some boards here and I can
help testing on them.

Cheers,
Mauro.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Patch

diff -r 3919b17dc88e linux/drivers/staging/tm6000/tm6000-cards.c
--- a/linux/drivers/staging/tm6000/tm6000-cards.c	Wed Oct 14 12:52:55 2009 -0300
+++ b/linux/drivers/staging/tm6000/tm6000-cards.c	Tue Nov 10 08:05:15 2009 +0900
@@ -33,6 +33,7 @@ 
 #include "tm6000.h"
 #include "tm6000-regs.h"
 #include "tuner-xc2028.h"
+#include "tuner-xc5000.h"
 
 #define TM6000_BOARD_UNKNOWN			0
 #define TM5600_BOARD_GENERIC			1
@@ -193,6 +194,36 @@ 
 		},
 		.gpio_addr_tun_reset = TM6000_GPIO_2,
 	},
+	[TM6010_BOARD_BEHOLD_WANDER] = {
+		.name         = "Beholder Wander DVB-T/TV/FM USB2.0",
+		.tuner_type   = TUNER_XC5000,
+		.tuner_addr   = 0xc2 >> 1,
+		.demod_addr   = 0x1e >> 1,
+		.type         = TM6010,
+		.caps = {
+			.has_tuner    = 1,
+			.has_dvb      = 1,
+			.has_zl10353  = 1,
+			.has_eeprom   = 1,
+			.has_remote   = 1,
+		},
+		.gpio_addr_tun_reset = TM6000_GPIO_2,
+	},
+	[TM6010_BOARD_BEHOLD_VOYAGER] = {
+		.name         = "Beholder Voyager TV/FM USB2.0",
+		.tuner_type   = TUNER_XC5000,
+		.tuner_addr   = 0xc2 >> 1,
+		.type         = TM6010,
+		.caps = {
+			.has_tuner    = 1,
+			.has_dvb      = 0,
+			.has_zl10353  = 0,
+			.has_eeprom   = 1,
+			.has_remote   = 1,
+		},
+		.gpio_addr_tun_reset = TM6000_GPIO_2,
+	},
+
 };
 
 /* table of devices that work with this driver */
@@ -203,6 +234,8 @@ 
 	{ USB_DEVICE(0x14aa, 0x0620), .driver_info = TM6000_BOARD_FREECOM_AND_SIMILAR },
 	{ USB_DEVICE(0x06e1, 0xb339), .driver_info = TM6000_BOARD_ADSTECH_MINI_DUAL_TV },
 	{ USB_DEVICE(0x2040, 0x6600), .driver_info = TM6010_BOARD_HAUPPAUGE_900H },
+	{ USB_DEVICE(0x6000, 0xdec0), .driver_info = TM6010_BOARD_BEHOLD_WANDER },
+	{ USB_DEVICE(0x6000, 0xdec1), .driver_info = TM6010_BOARD_BEHOLD_VOYAGER },
 	{ },
 };
 
Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov <d.belimov@gmail.com>